From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65])
 by mx.groups.io with SMTP id smtpd.web12.9531.1581614592176975367
 for <devel@edk2.groups.io>;
 Thu, 13 Feb 2020 09:23:12 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=cj+dQu5D;
 spf=pass (domain: nuviainc.com, ip: 209.85.128.65, mailfrom: leif@nuviainc.com)
Received: by mail-wm1-f65.google.com with SMTP id a6so7685229wme.2
        for <devel@edk2.groups.io>; Thu, 13 Feb 2020 09:23:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=DDOW1Q0iWMKgffY/PejPsstn+rGzdnROFbrlNH7HjUg=;
        b=cj+dQu5DIGxxrKdwLjmdKtJStMAuVsAbwx5THYylZSFJav9rp0wIds/EXd2o087VpH
         yz4TIduN/lzjadDDuvR1BT2nGnuIIzpxvFG+rX6lPKrjOAkMPag+89tLT26pPMENiGIr
         YjUvYQRWLK3cwSM00LUvphqBRSlpNd52squqZdd/67cwDl2rnSEHz5kapJWCT1ORkQVB
         2DttqqEFZlXkLOLl+WpuchltrCbeOGF2HZczj0ChgptH+ppkCiydyecexIWYUIcp4jhr
         YzQGbMlTobX+s5yiyJt1fnhQ7DOLsT0Ta+KlY8n1ZIpZrWixn8WWXhFrKsfu2XUaEprt
         UAyA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=DDOW1Q0iWMKgffY/PejPsstn+rGzdnROFbrlNH7HjUg=;
        b=B/gsTbunjk7e/XAJXN6wM+Q+ohgekmCPiS7AyoJmMzBsuDrYQCEjBjiRl+4fSCnSCy
         km3/rjipEwlNh7tiCK0IceGVMO4qONekbIk6LR7dSvZXax9iiyZuZV/gpdIsR3yNJuMz
         beCRNJX8ztKeL/HkeCCAoxy5gvZVLJg7th6nhw0Wysjg6zPRLxUGi/BSIM+tFM792lN7
         evpREeGW1tMsIHCYxajrX75eghJjsnAwFzCGDiwvTjdbkEfwRGvnMPGKZu/j2bW3bb6J
         /heigJuCLTFpkUZ6Q27mbVgze+zAoQilTs0ue1yCzWfJil+Sib299aCyw1649FlyWKuL
         W/Rg==
X-Gm-Message-State: APjAAAW0QglC+0wVhlwNxwyZZxvWrowdYVXolQbigpGQ58Q98lWlEJEt
	FBKQad3ncaEXMjV14CmS4wZ2hQ==
X-Google-Smtp-Source: APXvYqyAcmPLLpJP1jOjrbnY+JJP/5HzXTGbJEz9qcMK2MjyUNHKWQbd/fml15kesSqPP4ZfcJhbxQ==
X-Received: by 2002:a05:600c:2552:: with SMTP id e18mr6757970wma.103.1581614590835;
        Thu, 13 Feb 2020 09:23:10 -0800 (PST)
Return-Path: <leif@nuviainc.com>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id 2sm3537396wrq.31.2020.02.13.09.23.10
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 13 Feb 2020 09:23:10 -0800 (PST)
Date: Thu, 13 Feb 2020 17:23:08 +0000
From: "Leif Lindholm" <leif@nuviainc.com>
To: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
Cc: devel@edk2.groups.io, michael.d.kinney@intel.com,
	Ard.Biesheuvel@arm.com, thomas.abraham@arm.com
Subject: Re: [edk2-platforms] [PATCH v2 5/5] Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform
Message-ID: <20200213172308.GP23627@bivouac.eciton.net>
References: <1581514167-1340-1-git-send-email-vijayenthiran.subramaniam@arm.com>
 <1581514167-1340-6-git-send-email-vijayenthiran.subramaniam@arm.com>
MIME-Version: 1.0
In-Reply-To: <1581514167-1340-6-git-send-email-vijayenthiran.subramaniam@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 12, 2020 at 18:59:27 +0530, Vijayenthiran Subramaniam wrote:
> For RD-N1-Edge platforms, use multi-chip-mode information from the
> SGI platform descriptor HOB to pick the correct ACPI table to be
> installed.
> 
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>

> ---
>  Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 +
>  Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c   | 5 +++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
> index a95c0d1dddd6..741dcc75ed6a 100644
> --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
> +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
> @@ -32,6 +32,7 @@ [Guids]
>    gArmSgiPlatformIdDescriptorGuid
>    gSgi575AcpiTablesFileGuid
>    gRdN1EdgeAcpiTablesFileGuid
> +  gRdN1EdgeX2AcpiTablesFileGuid
>    gRdE1EdgeAcpiTablesFileGuid
>  
>  [FeaturePcd]
> diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> index a2250a37bb57..3ef775187ac6 100644
> --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> @@ -38,6 +38,11 @@ STATIC SGI_PLATFORM_ACPI_TABLE_GUID_LOOKUP AcpiTableGuidLookup[] = {
>        &gRdN1EdgeAcpiTablesFileGuid),
>    ACPI_GUID_LOOKUP (
>        RD_N1E1_EDGE_PART_NUM,
> +      RD_N1_EDGE_CONF_ID,
> +      MULTI_CHIP_MODE_ENABLED,
> +      &gRdN1EdgeX2AcpiTablesFileGuid),
> +  ACPI_GUID_LOOKUP (
> +      RD_N1E1_EDGE_PART_NUM,
>        RD_E1_EDGE_CONF_ID,
>        MULTI_CHIP_MODE_DISABLED,
>        &gRdE1EdgeAcpiTablesFileGuid),
> -- 
> 2.7.4
>