From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web12.116.1581615110657403640 for ; Thu, 13 Feb 2020 09:31:51 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=NgOcSzCH; spf=pass (domain: nuviainc.com, ip: 209.85.128.65, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f65.google.com with SMTP id s144so223343wme.1 for ; Thu, 13 Feb 2020 09:31:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8DFMTdqqZKNqS2nPL+QgFYIdlHNeVemEH/nIMrBtxSY=; b=NgOcSzCHYApj63Fqw7cF6LFhEi8KVdtF8nawXLZOoaH399DLU4AMOj9y1bgmz9h/p+ 05koflvLJKB50MehEidza24/c1/61j/xsp4UNNQXPiBloZ6dd93kKpeBmPGFZNsaarsn PCq+82PFeAnho/fjeDsKezvyvywqlShy0bpbNwHXNh70pHHn/fsjFlXwDFiZtVQvZKjC GZVlcSw7LyOQiIOqF9sxYlmQ6++JCUwLfBhn4yqFrtWxivO9qGlkv+OuQnEVq6C0pNGs 7msqpqcq7hckMksv0z9RJDW67FcWV48QPwgek9JdLVyIQ1dIVbMT1OPYvuJS9te7e/7w FLDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8DFMTdqqZKNqS2nPL+QgFYIdlHNeVemEH/nIMrBtxSY=; b=rZWYZpNrXkNbgEswxcIHJqWzP5+JyhvZch34AfukJc8RRjEQE4N941D2HboAaLFxT0 TM5kUaGDhn2cU4XLtXxOJ1/HrDMtB4dMrYgFQ+e0fmvXK7pFeUCMd2I+3VgzZenNKmDU hme0vivmQYV20nVm6qcjti8xHz0OJ1xlwpMOazSCJtrvINmSCZoWQK1ogC19kb/StZNh oAV2Kwe2u5168KqewGPUUmzSYWPpPzaK53ro+Qc8NdE0bqBXDiMTw30nxwzRALKmWC1b X+xwiehBIBPhRfoK1Rkq5sS90uZQtTGg1jno6+aNDCykhINu6VOJKSwYSz1zvUWiqRBV ucMQ== X-Gm-Message-State: APjAAAUogiwePO2WKfOAQAq7vggSLOGKWqCclZY/H5E5viNhj+SUSew4 5zJjiL95KpxABVLKwLKYt1D7rQ== X-Google-Smtp-Source: APXvYqwOQZer8QY4NDtVTUefLyxMqMWVX92yRXUY0aJFMqnonn4Jp2Zpai4dk//QvF+HxeGlujhzPg== X-Received: by 2002:a1c:9e13:: with SMTP id h19mr7054546wme.21.1581615109180; Thu, 13 Feb 2020 09:31:49 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x7sm3643471wrq.41.2020.02.13.09.31.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2020 09:31:48 -0800 (PST) Date: Thu, 13 Feb 2020 17:31:47 +0000 From: "Leif Lindholm" To: Vijayenthiran Subramaniam Cc: devel@edk2.groups.io, michael.d.kinney@intel.com, Ard.Biesheuvel@arm.com, thomas.abraham@arm.com Subject: Re: [edk2-platforms] [PATCH v2 0/5] Platform/ARM/SgiPkg: Add support for RD-N1-Edge-Dual platform Message-ID: <20200213173147.GQ23627@bivouac.eciton.net> References: <1581514167-1340-1-git-send-email-vijayenthiran.subramaniam@arm.com> MIME-Version: 1.0 In-Reply-To: <1581514167-1340-1-git-send-email-vijayenthiran.subramaniam@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On the whole, looks good. If you can resubmit v3 versions of patches 2-3 only based on feedback, that would suffice. On a separate note: Could someone in ARM take an action item to go and figure out who should be default reviewer for the various ARM ltd platforms (virtual or not), and submit a patch to Maintainers.txt adding some R:? Best Regards, Leif On Wed, Feb 12, 2020 at 18:59:22 +0530, Vijayenthiran Subramaniam wrote: > Changes since v1: > - Fix typo which caused build error > > This patch series adds support for RD-N1-Edge platform with multi-chip > capability. The first patch in this series is an improvement to SgiPkg to avoid > any usage of deprecated APIs. The second patch refactors the existing code to > use lookup table in order to identify the platform. The rest of the patch adds > multi-chip support for the RD-N1-Edge platform. > > Vijayenthiran Subramaniam (5): > Platform/ARM/SgiPkg: Disable use of deprecated APIs > Platform/ARM/SgiPkg: Use lookup table to install ACPI table > Platform/ARM/SgiPkg: Add MultiChipMode to Platform Descriptor > Platform/ARM/Sgi: Add ACPI tables for dual-chip RD-N1-Edge platform > Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform > > Platform/ARM/SgiPkg/SgiPlatform.dec | 1 + > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 3 + > Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 + > Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 + > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 59 ++++++ > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 + > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 + > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 61 +++++- > Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 8 + > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc | 198 ++++++++++++++++++++ > 10 files changed, 333 insertions(+), 10 deletions(-) > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc > > -- > 2.7.4 >