From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web10.1527.1582058067326988745 for ; Tue, 18 Feb 2020 12:34:27 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=I+7BvS83; spf=pass (domain: nuviainc.com, ip: 209.85.128.66, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f66.google.com with SMTP id q9so4116285wmj.5 for ; Tue, 18 Feb 2020 12:34:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LlXqERgtdjrhoBcd+MHBqtMHyr35VyK8HgyVlfQ776U=; b=I+7BvS83W99/YBxv4iEm7FnU3kTel/XqOKpPMUEbGHoktsowQqWRtd1mcvim5B3SFg ELSs9PyaJO6J/L/XeJxExGYQt+qdFjLIp9CGA9UZOUy6+D9hLBrN+2SEPAvNjS5yv2a/ hsLiq3XjNLk/Di1i4hm4nEy45o7Im5ls3pJ0V6uCtiUHMzh6rVCTy/U4VUCyvqja7A9B kSEiC5cqpKcWVSy7mXOG+R5MevSlk3VIwVzy1D1Ykrt12TUDOUmgrk9hGUuwne4jZ3bt huMLhOBCvlQ42nsUwAvPcXIalbz0HuWtZzrUEM6mJGAJ8/pvsgAlI0OZARINSysgThE5 IFFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LlXqERgtdjrhoBcd+MHBqtMHyr35VyK8HgyVlfQ776U=; b=TSwQ7fdr/mMO5PbJMTvKLGeDbzIXMvJdOxZfYd1+o9RAOKvDhyK4LQcE71Mth4ke0L V9ixx9yq4DX5jA0Z0zBCuwkyK2mGi584XxU9DvReMSEssF8i0ETpxPzQIcHacjLfEx99 GRix4sCK/kwSBETLZMCy8FBx69PVXuXDrHc9OjCm2qP0Yzrl6Gio0rw0cqVzlMFaaYIn xd/IwldWYnNu/Llu4fgExNRPaRe+6jHUMVkm5DQ+9N55O3q1plyxxIUQGNH5KRs9mtCi 1gAtTWsHYHQmKzQ4B9EXeQpFX9fQwLE4Y73fsNaf0iaJNqCTvx43o8oUEnjoctXJOtQB aezQ== X-Gm-Message-State: APjAAAVJeslfZdFWiyvT8nyTEPyW2jkIVRxdZrmenqj2ZKoOUD4s+cFS Sb9HAehbKyzYjnOXFcpyI7PMfg== X-Google-Smtp-Source: APXvYqxubuwVA0oXg2B/u95PBNjoqb2ewO0ykmNiN27FA7vnuh3yRW1DcpS4Ga/8+RbRc9ZEVFm+aw== X-Received: by 2002:a1c:7717:: with SMTP id t23mr5196903wmi.17.1582058065821; Tue, 18 Feb 2020 12:34:25 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a198sm4729187wme.12.2020.02.18.12.34.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 12:34:25 -0800 (PST) Date: Tue, 18 Feb 2020 20:34:23 +0000 From: "Leif Lindholm" To: Vijayenthiran Subramaniam Cc: devel@edk2.groups.io, michael.d.kinney@intel.com, Ard.Biesheuvel@arm.com, thomas.abraham@arm.com Subject: Re: [edk2-platforms] [PATCH v3 0/5] Platform/ARM/SgiPkg: Add support for RD-N1-Edge-Dual platform Message-ID: <20200218203423.GY23627@bivouac.eciton.net> References: <1581687694-12752-1-git-send-email-vijayenthiran.subramaniam@arm.com> MIME-Version: 1.0 In-Reply-To: <1581687694-12752-1-git-send-email-vijayenthiran.subramaniam@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 14, 2020 at 19:11:29 +0530, Vijayenthiran Subramaniam wrote: > Changes since v2: > - Rename i to Idx in Patch 2/5 > - Retaining R-b in rest of the patches as there's no change > > Changes since v1: > - Fix typo which caused build error > > This patch series adds support for RD-N1-Edge platform with multi-chip > capability. The first patch in this series is an improvement to SgiPkg to avoid > any usage of deprecated APIs. The second patch refactors the existing code to > use lookup table in order to identify the platform. The rest of the patch adds > multi-chip support for the RD-N1-Edge platform. For remaining patches: Reviewed-by: Leif Lindholm Series pushed as 41c1d9ba3304..2fb4670d9f68. However, while test building I noticed the SGI platform currently fails to build with clang (version 7 in my case). This fails also before this set however. But could you please look into the warnings in Platform/ARM/SgiPkg/Drivers/PlatformDxe/VirtioDevices.c ? Regards, Leif > Vijayenthiran Subramaniam (5): > Platform/ARM/SgiPkg: Disable use of deprecated APIs > Platform/ARM/SgiPkg: Use lookup table to install ACPI table > Platform/ARM/SgiPkg: Add MultiChipMode to Platform Descriptor > Platform/ARM/Sgi: Add ACPI tables for dual-chip RD-N1-Edge platform > Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform > > Platform/ARM/SgiPkg/SgiPlatform.dec | 1 + > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 3 + > Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 + > Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 + > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 59 ++++++ > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 + > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 + > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 61 +++++- > Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 8 + > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc | 198 ++++++++++++++++++++ > 10 files changed, 333 insertions(+), 10 deletions(-) > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc > > -- > 2.7.4 >