From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.4689.1582071257479493971 for ; Tue, 18 Feb 2020 16:14:17 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2020 16:14:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,458,1574150400"; d="scan'208";a="434295183" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by fmsmga005.fm.intel.com with ESMTP; 18 Feb 2020 16:14:16 -0800 Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 18 Feb 2020 16:14:15 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.140]) by ORSMSX160.amr.corp.intel.com ([169.254.13.167]) with mapi id 14.03.0439.000; Tue, 18 Feb 2020 16:14:15 -0800 From: "Nate DeSimone" To: "Agyeman, Prince" CC: "devel@edk2.groups.io" , "Chiu, Chasel" Subject: Re: [edk2-platforms] [PATCH v2 1/4] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove BoardFuncInit Thread-Topic: [edk2-platforms] [PATCH v2 1/4] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove BoardFuncInit Thread-Index: AQHV4pbADGji6NtaTkKylkJ4OUIiK6giM/cA Date: Wed, 19 Feb 2020 00:14:15 +0000 Message-ID: <20200219001414.GD7915@nate-virtualbox> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.7.159.63] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone On Thu, Feb 13, 2020 at 05:55:08PM +0000, Agyeman, Prince wrote: > Removes BoardFuncInit related functionality in WhiskeylakeURvp. >=20 > Co-authored-by: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Prince Agyeman > --- > .../Library/BoardInitLib/BoardFunc.c | 19 ------------ > .../Library/BoardInitLib/BoardFunc.h | 20 ------------- > .../Library/BoardInitLib/BoardFuncInit.c | 26 ----------------- > .../BoardInitLib/BoardFuncInitPreMem.c | 29 +++++-------------- > .../BoardInitLib/BoardPchInitPreMemLib.c | 3 +- > .../PeiMultiBoardInitPostMemLib.inf | 4 --- > .../PeiWhiskeylakeURvpInitPostMemLib.c | 8 ----- > .../PeiWhiskeylakeURvpInitPreMemLib.c | 10 +------ > 8 files changed, 9 insertions(+), 110 deletions(-) > delete mode 100644 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURv= p/Library/BoardInitLib/BoardFunc.c > delete mode 100644 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURv= p/Library/BoardInitLib/BoardFunc.h > delete mode 100644 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURv= p/Library/BoardInitLib/BoardFuncInit.c >=20 > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Libra= ry/BoardInitLib/BoardFunc.c b/Platform/Intel/WhiskeylakeOpenBoardPkg/Whiske= ylakeURvp/Library/BoardInitLib/BoardFunc.c > deleted file mode 100644 > index 7a2fed9904..0000000000 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar= dInitLib/BoardFunc.c > +++ /dev/null > @@ -1,19 +0,0 @@ > -/** @file > - Board's PCD function hook. > - > - > - Copyright (c) 2019, Intel Corporation. All rights reserved.
> - SPDX-License-Identifier: BSD-2-Clause-Patent > -**/ > - > -#include > - > -EFI_STATUS > -PeiBoardSpecificInitPostMemNull ( > - VOID > - ) > -{ > - return EFI_SUCCESS; > -} > - > - > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Libra= ry/BoardInitLib/BoardFunc.h b/Platform/Intel/WhiskeylakeOpenBoardPkg/Whiske= ylakeURvp/Library/BoardInitLib/BoardFunc.h > deleted file mode 100644 > index 9e0ff8d033..0000000000 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar= dInitLib/BoardFunc.h > +++ /dev/null > @@ -1,20 +0,0 @@ > -/** @file > - Header file for Board Hook function intance. > - > - > - Copyright (c) 2019, Intel Corporation. All rights reserved.
> - SPDX-License-Identifier: BSD-2-Clause-Patent > -**/ > - > -#ifndef _BOARD_FUNC_H_ > -#define _BOARD_FUNC_H_ > - > -#include > - > -EFI_STATUS > -PeiBoardSpecificInitPostMemNull ( > - VOID > - ); > - > -#endif // _BOARD_FUNC_H_ > - > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Libra= ry/BoardInitLib/BoardFuncInit.c b/Platform/Intel/WhiskeylakeOpenBoardPkg/Wh= iskeylakeURvp/Library/BoardInitLib/BoardFuncInit.c > deleted file mode 100644 > index b8c69166ed..0000000000 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar= dInitLib/BoardFuncInit.c > +++ /dev/null > @@ -1,26 +0,0 @@ > -/** @file > - Source code for the board configuration init function in Post Memory i= nit phase. > - > - > - Copyright (c) 2019, Intel Corporation. All rights reserved.
> - SPDX-License-Identifier: BSD-2-Clause-Patent > -**/ > - > -#include "BoardFunc.h" > - > -/** > - Board's PCD function hook init function for PEI post memory phase. > - > - @param[in] BoardId An unsigned integrer represent the board id. > - > - @retval EFI_SUCCESS The function completed successfully. > -**/ > -EFI_STATUS > -BoardFunctionInit ( > - IN UINT16 BoardId > -) > -{ > - > - return EFI_SUCCESS; > -} > - > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Libra= ry/BoardInitLib/BoardFuncInitPreMem.c b/Platform/Intel/WhiskeylakeOpenBoard= Pkg/WhiskeylakeURvp/Library/BoardInitLib/BoardFuncInitPreMem.c > index 1944a02bf1..06ff64da8d 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar= dInitLib/BoardFuncInitPreMem.c > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar= dInitLib/BoardFuncInitPreMem.c > @@ -2,39 +2,24 @@ > Source code for the board configuration init function in Post Memory i= nit phase. > =20 > =20 > - Copyright (c) 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > =20 > #include > + > // > // Null function for nothing GOP VBT update. > // > VOID > -GopVbtSpecificUpdateNull( > +GopVbtSpecificUpdateNull ( > IN CHILD_STRUCT **ChildStructPtr > -); > + ); > + > // > // for CFL U DDR4 > // > VOID > -CflUDdr4GopVbtSpecificUpdate( > +CflUDdr4GopVbtSpecificUpdate ( > IN CHILD_STRUCT **ChildStructPtr > -); > -/** > - Board's PCD function hook init function for PEI post memory phase. > - > - @param[in] BoardId An unsigned integrer represent the board id. > - > - @retval EFI_SUCCESS The function completed successfully. > -**/ > -EFI_STATUS > -BoardFunctionInitPreMem ( > - IN UINT16 BoardId > - ) > -{ > - > - return EFI_SUCCESS; > -} > - > - > + ); > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Libra= ry/BoardInitLib/BoardPchInitPreMemLib.c b/Platform/Intel/WhiskeylakeOpenBoa= rdPkg/WhiskeylakeURvp/Library/BoardInitLib/BoardPchInitPreMemLib.c > index 5305ec7f7c..1f778c4f7e 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar= dInitLib/BoardPchInitPreMemLib.c > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar= dInitLib/BoardPchInitPreMemLib.c > @@ -2,7 +2,7 @@ > Source code for the board PCH configuration Pcd init functions for Pre-= Memory Init phase. > =20 > =20 > - Copyright (c) 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > =20 > @@ -310,7 +310,6 @@ GpioGroupTierInit ( > // > // GPIO Group Tier > // > - > switch (BoardId) { > case BoardIdWhiskeyLakeRvp: > PcdSet32S (PcdGpioGroupToGpeDw0, GPIO_CNL_LP_GROUP_GPP_G); > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Libra= ry/BoardInitLib/PeiMultiBoardInitPostMemLib.inf b/Platform/Intel/Whiskeylak= eOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiMultiBoardInitPostMem= Lib.inf > index 436314a6a3..845790209f 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar= dInitLib/PeiMultiBoardInitPostMemLib.inf > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar= dInitLib/PeiMultiBoardInitPostMemLib.inf > @@ -44,13 +44,9 @@ > [Sources] > PeiWhiskeylakeURvpInitPostMemLib.c > PeiMultiBoardInitPostMemLib.c > - BoardFunc.c > - BoardFuncInit.c > GpioTableDefault.c > GpioTableWhiskeylakeUDdr4Rvp.c > =20 > -[FixedPcd] > - > [Pcd] > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdBoardGpioTable > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdBoardGpioTableSize > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Libra= ry/BoardInitLib/PeiWhiskeylakeURvpInitPostMemLib.c b/Platform/Intel/Whiskey= lakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiWhiskeylakeURvpIni= tPostMemLib.c > index f704c42f2d..c61743acdc 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar= dInitLib/PeiWhiskeylakeURvpInitPostMemLib.c > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar= dInitLib/PeiWhiskeylakeURvpInitPostMemLib.c > @@ -33,11 +33,6 @@ > #include "WhiskeylakeURvpInit.h" > #include > =20 > -EFI_STATUS > -BoardFunctionInit ( > - IN UINT16 BoardId > - ); > - > /** > GPIO init function for PEI post memory phase. > =20 > @@ -168,9 +163,6 @@ BoardConfigInit ( > Status =3D BoardMiscInit (BoardId); > ASSERT_EFI_ERROR (Status); > =20 > - Status =3D BoardFunctionInit (BoardId); > - ASSERT_EFI_ERROR (Status); > - > Status =3D BoardSecurityInit (BoardId); > ASSERT_EFI_ERROR (Status); > } > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Libra= ry/BoardInitLib/PeiWhiskeylakeURvpInitPreMemLib.c b/Platform/Intel/Whiskeyl= akeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiWhiskeylakeURvpInit= PreMemLib.c > index 75813ff351..69fed14c06 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar= dInitLib/PeiWhiskeylakeURvpInitPreMemLib.c > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar= dInitLib/PeiWhiskeylakeURvpInitPreMemLib.c > @@ -1,6 +1,6 @@ > /** @file > =20 > - Copyright (c) 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > =20 > @@ -120,11 +120,6 @@ SaDisplayConfigInit ( > IN UINT16 BoardId > ); > =20 > -EFI_STATUS > -BoardFunctionInitPreMem ( > - IN UINT16 BoardId > - ); > - > EFI_STATUS > EFIAPI > PlatformInitPreMemCallBack ( > @@ -273,9 +268,6 @@ BoardConfigInitPreMem ( > =20 > Status =3D SaDisplayConfigInit (BoardId); > ASSERT_EFI_ERROR (Status); > - > - Status =3D BoardFunctionInitPreMem (BoardId); > - ASSERT_EFI_ERROR (Status); > } > =20 > /** > --=20 > 2.19.1.windows.1 > =