Re: [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg

["Nate DeSimone" <nathaniel.l.desimone@intel.com>]

Hi Kathappan,

Please see my feedback inline.

Thanks,
Nate

On Tue, Feb 18, 2020 at 02:53:43PM +0000, Esakkithevar, Kathappan wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
> 
> This change adds the configuration to enable build for CometlakeURvp.
> Also it updates Cometlake U Rvp details to the Readme.md.
> 
> Signed-off-by: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> ---
>  Platform/Intel/Readme.md | 11 +++++++++++
>  Platform/Intel/build.cfg |  3 ++-
>  2 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md
> index 02d9517d19..b5ad8ed5fe 100644
> --- a/Platform/Intel/Readme.md
> +++ b/Platform/Intel/Readme.md
> @@ -56,6 +56,7 @@ A UEFI firmware implementation using MinPlatformPkg is constructed using the fol
>  * The `KabylakeOpenBoardPkg` contains board implementations for Kaby Lake systems.
>  * The `SimicsOpenBoardPkg` contains board implementations for the Simics hardware simulator.
>  * The `WhiskeylakeOpenBoardPkg` contains board implementations for Whiskey Lake systems.
> +* The `CometlakeOpenBoardPkg` contains board implementations for Comet Lake systems.
>  
>  ### **Supported Hardware**
>  
> @@ -67,6 +68,7 @@ A UEFI firmware implementation using MinPlatformPkg is constructed using the fol
>  ----------------------------------------|--------------------------------------------|------------------------------|--------------------|
>  | RVP 3                                 | Sky Lake, Kaby Lake, Kaby Lake Refresh     | KabylakeOpenBoardPkg         | KabylakeRvp3       |
>  | WHL-U DDR4 RVP                        | Whiskey Lake                               | WhiskeylakeOpenBoardPkg      | WhiskeylakeURvp    |

This should be "Comet Lake V1" not "COmet Lake V1"

> +| CML-U LPDDR3 RVP                      | COmet Lake V1                              | CometlakeOpenBoardPkg        | CometlakeURvp      |
>  
>  *Note: RVP = Reference and Validation Platform*
>  
> @@ -237,6 +239,11 @@ return back to the minimum platform caller.
>            |       |        |               |---build_config.cfg: WhiskeylakeURvp specific build
>            |       |        |                                     settings environment variables.
>            |       |        |
> +          |       |        |------CometlakeOpenBoardPkg
> +          |       |        |       |------CometlakeURvp
> +          |       |        |               |---build_config.cfg: CometlakeURvp specific build
> +          |       |        |                                     settings environment variables.
> +          |       |        |
>            |------FSP
>    </pre>
>  
> @@ -257,6 +264,10 @@ return back to the minimum platform caller.
>  1. This firmware project has only been tested booting to Microsoft Windows 10 x64 with AHCI mode and Integrated Graphic
>     Device.
>  
> +**CometlakeOpenBoardPkg**
> +1. This firmware project has been tested booting to Microsoft Windows 10 x64 with AHCI mode and External Graphic Device.
> +2. This firmware project has been also tested booting to Ubuntu 17.10 with AHCI mode and Integrated Graphic Device.
> +
>  ### **Package Builds**
>  
>  In some cases, such as BoardModulePkg, a package may provide a set of functionality that is included in other
> diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg
> index 86a9115021..5bc1dea43c 100644
> --- a/Platform/Intel/build.cfg
> +++ b/Platform/Intel/build.cfg
> @@ -1,7 +1,7 @@
>  # @ build.cfg
>  # This is the main/default build configuration file
>  #
> -# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.<BR>
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
>  
> @@ -58,3 +58,4 @@ BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
>  GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg
>  KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
>  WhiskeylakeURvp = WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
> +CometlakeURvp = CometlakeOpenBoardPkg/CometlakeURvp/build_config.cfg
> -- 
> 2.16.2.windows.1
>