From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.7524.1582085174620028923 for ; Tue, 18 Feb 2020 20:06:14 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2020 20:06:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,459,1574150400"; d="scan'208";a="436099211" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga006.fm.intel.com with ESMTP; 18 Feb 2020 20:06:13 -0800 Received: from orsmsx122.amr.corp.intel.com (10.22.225.227) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 18 Feb 2020 20:06:13 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.140]) by ORSMSX122.amr.corp.intel.com ([169.254.11.66]) with mapi id 14.03.0439.000; Tue, 18 Feb 2020 20:06:13 -0800 From: "Nate DeSimone" To: "Esakkithevar, Kathappan" CC: "devel@edk2.groups.io" , "Chaganty, Rangasai V" , "Chiu, Chasel" , "Kethi Reddy, Deepika" , "Agyeman, Prince" Subject: Re: [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg Thread-Topic: [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg Thread-Index: AQHV5mtLFl1aQ2AZZ0qEkhyttlVa0KgibROA Date: Wed, 19 Feb 2020 04:06:12 +0000 Message-ID: <20200219040603.GA2439@nate-virtualbox> References: <20200218145343.11820-1-kathappan.esakkithevar@intel.com> <20200218145343.11820-3-kathappan.esakkithevar@intel.com> In-Reply-To: <20200218145343.11820-3-kathappan.esakkithevar@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.7.159.63] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable Hi Kathappan, Please see my feedback inline. Thanks, Nate On Tue, Feb 18, 2020 at 02:53:43PM +0000, Esakkithevar, Kathappan wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2280 >=20 > This change adds the configuration to enable build for CometlakeURvp. > Also it updates Cometlake U Rvp details to the Readme.md. >=20 > Signed-off-by: Kathappan Esakkithevar > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Deepika Kethi Reddy > Cc: Prince Agyeman > --- > Platform/Intel/Readme.md | 11 +++++++++++ > Platform/Intel/build.cfg | 3 ++- > 2 files changed, 13 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md > index 02d9517d19..b5ad8ed5fe 100644 > --- a/Platform/Intel/Readme.md > +++ b/Platform/Intel/Readme.md > @@ -56,6 +56,7 @@ A UEFI firmware implementation using MinPlatformPkg is = constructed using the fol > * The `KabylakeOpenBoardPkg` contains board implementations for Kaby Lak= e systems. > * The `SimicsOpenBoardPkg` contains board implementations for the Simics= hardware simulator. > * The `WhiskeylakeOpenBoardPkg` contains board implementations for Whisk= ey Lake systems. > +* The `CometlakeOpenBoardPkg` contains board implementations for Comet L= ake systems. > =20 > ### **Supported Hardware** > =20 > @@ -67,6 +68,7 @@ A UEFI firmware implementation using MinPlatformPkg is = constructed using the fol > ----------------------------------------|-------------------------------= -------------|------------------------------|--------------------| > | RVP 3 | Sky Lake, Kaby Lake, Kaby Lake= Refresh | KabylakeOpenBoardPkg | KabylakeRvp3 | > | WHL-U DDR4 RVP | Whiskey Lake = | WhiskeylakeOpenBoardPkg | WhiskeylakeURvp | This should be "Comet Lake V1" not "COmet Lake V1" > +| CML-U LPDDR3 RVP | COmet Lake V1 = | CometlakeOpenBoardPkg | CometlakeURvp | > =20 > *Note: RVP =3D Reference and Validation Platform* > =20 > @@ -237,6 +239,11 @@ return back to the minimum platform caller. > | | | |---build_config.cfg: Whiskey= lakeURvp specific build > | | | setting= s environment variables. > | | | > + | | |------CometlakeOpenBoardPkg > + | | | |------CometlakeURvp > + | | | |---build_config.cfg: Cometla= keURvp specific build > + | | | setting= s environment variables. > + | | | > |------FSP > > =20 > @@ -257,6 +264,10 @@ return back to the minimum platform caller. > 1. This firmware project has only been tested booting to Microsoft Windo= ws 10 x64 with AHCI mode and Integrated Graphic > Device. > =20 > +**CometlakeOpenBoardPkg** > +1. This firmware project has been tested booting to Microsoft Windows 10= x64 with AHCI mode and External Graphic Device. > +2. This firmware project has been also tested booting to Ubuntu 17.10 wi= th AHCI mode and Integrated Graphic Device. > + > ### **Package Builds** > =20 > In some cases, such as BoardModulePkg, a package may provide a set of fu= nctionality that is included in other > diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg > index 86a9115021..5bc1dea43c 100644 > --- a/Platform/Intel/build.cfg > +++ b/Platform/Intel/build.cfg > @@ -1,7 +1,7 @@ > # @ build.cfg > # This is the main/default build configuration file > # > -# Copyright (c) 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent > # > =20 > @@ -58,3 +58,4 @@ BoardX58Ich10 =3D SimicsOpenBoardPkg/BoardX58Ich10/buil= d_config.cfg > GalagoPro3 =3D KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg > KabylakeRvp3 =3D KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > WhiskeylakeURvp =3D WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config= .cfg > +CometlakeURvp =3D CometlakeOpenBoardPkg/CometlakeURvp/build_config.cfg > --=20 > 2.16.2.windows.1 > =