* [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg
2020-02-18 14:53 [edk2-platforms] [PATCH V1 0/2] Add Cometlake U Silicon support and Enable build Kathappan Esakkithevar
@ 2020-02-18 14:53 ` Kathappan Esakkithevar
2020-02-19 4:06 ` Nate DeSimone
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Kathappan Esakkithevar @ 2020-02-18 14:53 UTC (permalink / raw)
To: devel
Cc: Sai Chaganty, Chasel Chiu, Nate DeSimone, Deepika Kethi Reddy,
Prince Agyeman
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
This change adds the configuration to enable build for CometlakeURvp.
Also it updates Cometlake U Rvp details to the Readme.md.
Signed-off-by: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
Platform/Intel/Readme.md | 11 +++++++++++
Platform/Intel/build.cfg | 3 ++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md
index 02d9517d19..b5ad8ed5fe 100644
--- a/Platform/Intel/Readme.md
+++ b/Platform/Intel/Readme.md
@@ -56,6 +56,7 @@ A UEFI firmware implementation using MinPlatformPkg is constructed using the fol
* The `KabylakeOpenBoardPkg` contains board implementations for Kaby Lake systems.
* The `SimicsOpenBoardPkg` contains board implementations for the Simics hardware simulator.
* The `WhiskeylakeOpenBoardPkg` contains board implementations for Whiskey Lake systems.
+* The `CometlakeOpenBoardPkg` contains board implementations for Comet Lake systems.
### **Supported Hardware**
@@ -67,6 +68,7 @@ A UEFI firmware implementation using MinPlatformPkg is constructed using the fol
----------------------------------------|--------------------------------------------|------------------------------|--------------------|
| RVP 3 | Sky Lake, Kaby Lake, Kaby Lake Refresh | KabylakeOpenBoardPkg | KabylakeRvp3 |
| WHL-U DDR4 RVP | Whiskey Lake | WhiskeylakeOpenBoardPkg | WhiskeylakeURvp |
+| CML-U LPDDR3 RVP | COmet Lake V1 | CometlakeOpenBoardPkg | CometlakeURvp |
*Note: RVP = Reference and Validation Platform*
@@ -237,6 +239,11 @@ return back to the minimum platform caller.
| | | |---build_config.cfg: WhiskeylakeURvp specific build
| | | settings environment variables.
| | |
+ | | |------CometlakeOpenBoardPkg
+ | | | |------CometlakeURvp
+ | | | |---build_config.cfg: CometlakeURvp specific build
+ | | | settings environment variables.
+ | | |
|------FSP
</pre>
@@ -257,6 +264,10 @@ return back to the minimum platform caller.
1. This firmware project has only been tested booting to Microsoft Windows 10 x64 with AHCI mode and Integrated Graphic
Device.
+**CometlakeOpenBoardPkg**
+1. This firmware project has been tested booting to Microsoft Windows 10 x64 with AHCI mode and External Graphic Device.
+2. This firmware project has been also tested booting to Ubuntu 17.10 with AHCI mode and Integrated Graphic Device.
+
### **Package Builds**
In some cases, such as BoardModulePkg, a package may provide a set of functionality that is included in other
diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg
index 86a9115021..5bc1dea43c 100644
--- a/Platform/Intel/build.cfg
+++ b/Platform/Intel/build.cfg
@@ -1,7 +1,7 @@
# @ build.cfg
# This is the main/default build configuration file
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -58,3 +58,4 @@ BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg
KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
WhiskeylakeURvp = WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
+CometlakeURvp = CometlakeOpenBoardPkg/CometlakeURvp/build_config.cfg
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg
2020-02-18 14:53 ` [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg Kathappan Esakkithevar
@ 2020-02-19 4:06 ` Nate DeSimone
2020-02-19 6:43 ` Chiu, Chasel
2020-02-19 7:49 ` Chaganty, Rangasai V
2 siblings, 0 replies; 6+ messages in thread
From: Nate DeSimone @ 2020-02-19 4:06 UTC (permalink / raw)
To: Esakkithevar, Kathappan
Cc: devel@edk2.groups.io, Chaganty, Rangasai V, Chiu, Chasel,
Kethi Reddy, Deepika, Agyeman, Prince
Hi Kathappan,
Please see my feedback inline.
Thanks,
Nate
On Tue, Feb 18, 2020 at 02:53:43PM +0000, Esakkithevar, Kathappan wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
>
> This change adds the configuration to enable build for CometlakeURvp.
> Also it updates Cometlake U Rvp details to the Readme.md.
>
> Signed-off-by: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> ---
> Platform/Intel/Readme.md | 11 +++++++++++
> Platform/Intel/build.cfg | 3 ++-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md
> index 02d9517d19..b5ad8ed5fe 100644
> --- a/Platform/Intel/Readme.md
> +++ b/Platform/Intel/Readme.md
> @@ -56,6 +56,7 @@ A UEFI firmware implementation using MinPlatformPkg is constructed using the fol
> * The `KabylakeOpenBoardPkg` contains board implementations for Kaby Lake systems.
> * The `SimicsOpenBoardPkg` contains board implementations for the Simics hardware simulator.
> * The `WhiskeylakeOpenBoardPkg` contains board implementations for Whiskey Lake systems.
> +* The `CometlakeOpenBoardPkg` contains board implementations for Comet Lake systems.
>
> ### **Supported Hardware**
>
> @@ -67,6 +68,7 @@ A UEFI firmware implementation using MinPlatformPkg is constructed using the fol
> ----------------------------------------|--------------------------------------------|------------------------------|--------------------|
> | RVP 3 | Sky Lake, Kaby Lake, Kaby Lake Refresh | KabylakeOpenBoardPkg | KabylakeRvp3 |
> | WHL-U DDR4 RVP | Whiskey Lake | WhiskeylakeOpenBoardPkg | WhiskeylakeURvp |
This should be "Comet Lake V1" not "COmet Lake V1"
> +| CML-U LPDDR3 RVP | COmet Lake V1 | CometlakeOpenBoardPkg | CometlakeURvp |
>
> *Note: RVP = Reference and Validation Platform*
>
> @@ -237,6 +239,11 @@ return back to the minimum platform caller.
> | | | |---build_config.cfg: WhiskeylakeURvp specific build
> | | | settings environment variables.
> | | |
> + | | |------CometlakeOpenBoardPkg
> + | | | |------CometlakeURvp
> + | | | |---build_config.cfg: CometlakeURvp specific build
> + | | | settings environment variables.
> + | | |
> |------FSP
> </pre>
>
> @@ -257,6 +264,10 @@ return back to the minimum platform caller.
> 1. This firmware project has only been tested booting to Microsoft Windows 10 x64 with AHCI mode and Integrated Graphic
> Device.
>
> +**CometlakeOpenBoardPkg**
> +1. This firmware project has been tested booting to Microsoft Windows 10 x64 with AHCI mode and External Graphic Device.
> +2. This firmware project has been also tested booting to Ubuntu 17.10 with AHCI mode and Integrated Graphic Device.
> +
> ### **Package Builds**
>
> In some cases, such as BoardModulePkg, a package may provide a set of functionality that is included in other
> diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg
> index 86a9115021..5bc1dea43c 100644
> --- a/Platform/Intel/build.cfg
> +++ b/Platform/Intel/build.cfg
> @@ -1,7 +1,7 @@
> # @ build.cfg
> # This is the main/default build configuration file
> #
> -# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
>
> @@ -58,3 +58,4 @@ BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
> GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg
> KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> WhiskeylakeURvp = WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
> +CometlakeURvp = CometlakeOpenBoardPkg/CometlakeURvp/build_config.cfg
> --
> 2.16.2.windows.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg
@ 2020-02-19 5:37 Kathappan Esakkithevar
0 siblings, 0 replies; 6+ messages in thread
From: Kathappan Esakkithevar @ 2020-02-19 5:37 UTC (permalink / raw)
To: devel
Cc: Sai Chaganty, Chasel Chiu, Nate DeSimone, Deepika Kethi Reddy,
Prince Agyeman
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
This change adds the configuration to enable build for CometlakeURvp.
Also it updates Cometlake U Rvp details to the Readme.md.
Signed-off-by: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
Platform/Intel/Readme.md | 11 +++++++++++
Platform/Intel/build.cfg | 3 ++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md
index 02d9517d19..b5ad8ed5fe 100644
--- a/Platform/Intel/Readme.md
+++ b/Platform/Intel/Readme.md
@@ -56,6 +56,7 @@ A UEFI firmware implementation using MinPlatformPkg is constructed using the fol
* The `KabylakeOpenBoardPkg` contains board implementations for Kaby Lake systems.
* The `SimicsOpenBoardPkg` contains board implementations for the Simics hardware simulator.
* The `WhiskeylakeOpenBoardPkg` contains board implementations for Whiskey Lake systems.
+* The `CometlakeOpenBoardPkg` contains board implementations for Comet Lake systems.
### **Supported Hardware**
@@ -67,6 +68,7 @@ A UEFI firmware implementation using MinPlatformPkg is constructed using the fol
----------------------------------------|--------------------------------------------|------------------------------|--------------------|
| RVP 3 | Sky Lake, Kaby Lake, Kaby Lake Refresh | KabylakeOpenBoardPkg | KabylakeRvp3 |
| WHL-U DDR4 RVP | Whiskey Lake | WhiskeylakeOpenBoardPkg | WhiskeylakeURvp |
+| CML-U LPDDR3 RVP | Comet Lake V1 | CometlakeOpenBoardPkg | CometlakeURvp |
*Note: RVP = Reference and Validation Platform*
@@ -237,6 +239,11 @@ return back to the minimum platform caller.
| | | |---build_config.cfg: WhiskeylakeURvp specific build
| | | settings environment variables.
| | |
+ | | |------CometlakeOpenBoardPkg
+ | | | |------CometlakeURvp
+ | | | |---build_config.cfg: CometlakeURvp specific build
+ | | | settings environment variables.
+ | | |
|------FSP
</pre>
@@ -257,6 +264,10 @@ return back to the minimum platform caller.
1. This firmware project has only been tested booting to Microsoft Windows 10 x64 with AHCI mode and Integrated Graphic
Device.
+**CometlakeOpenBoardPkg**
+1. This firmware project has been tested booting to Microsoft Windows 10 x64 with AHCI mode and External Graphic Device.
+2. This firmware project has been also tested booting to Ubuntu 17.10 with AHCI mode and Integrated Graphic Device.
+
### **Package Builds**
In some cases, such as BoardModulePkg, a package may provide a set of functionality that is included in other
diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg
index 86a9115021..5bc1dea43c 100644
--- a/Platform/Intel/build.cfg
+++ b/Platform/Intel/build.cfg
@@ -1,7 +1,7 @@
# @ build.cfg
# This is the main/default build configuration file
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -58,3 +58,4 @@ BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg
KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
WhiskeylakeURvp = WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
+CometlakeURvp = CometlakeOpenBoardPkg/CometlakeURvp/build_config.cfg
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg
2020-02-18 14:53 ` [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg Kathappan Esakkithevar
2020-02-19 4:06 ` Nate DeSimone
@ 2020-02-19 6:43 ` Chiu, Chasel
2020-02-19 7:49 ` Chaganty, Rangasai V
2 siblings, 0 replies; 6+ messages in thread
From: Chiu, Chasel @ 2020-02-19 6:43 UTC (permalink / raw)
To: Esakkithevar, Kathappan, devel@edk2.groups.io
Cc: Chaganty, Rangasai V, Desimone, Nathaniel L, Kethi Reddy, Deepika,
Agyeman, Prince
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com>
> Sent: Tuesday, February 18, 2020 10:54 PM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kethi Reddy, Deepika
> <deepika.kethi.reddy@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> Subject: [edk2-platforms] [PATCH V1 2/2] Enable build for
> CometlakeOpenBoardPkg
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
>
> This change adds the configuration to enable build for CometlakeURvp.
> Also it updates Cometlake U Rvp details to the Readme.md.
>
> Signed-off-by: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> ---
> Platform/Intel/Readme.md | 11 +++++++++++ Platform/Intel/build.cfg | 3
> ++-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index
> 02d9517d19..b5ad8ed5fe 100644
> --- a/Platform/Intel/Readme.md
> +++ b/Platform/Intel/Readme.md
> @@ -56,6 +56,7 @@ A UEFI firmware implementation using MinPlatformPkg
> is constructed using the fol
> * The `KabylakeOpenBoardPkg` contains board implementations for Kaby
> Lake systems.
> * The `SimicsOpenBoardPkg` contains board implementations for the Simics
> hardware simulator.
> * The `WhiskeylakeOpenBoardPkg` contains board implementations for
> Whiskey Lake systems.
> +* The `CometlakeOpenBoardPkg` contains board implementations for Comet
> Lake systems.
>
> ### **Supported Hardware**
>
> @@ -67,6 +68,7 @@ A UEFI firmware implementation using MinPlatformPkg
> is constructed using the fol
> ----------------------------------------|--------------------------------------------|-------------
> -----------------|--------------------|
> | RVP 3 | Sky Lake, Kaby Lake, Kaby
> Lake Refresh | KabylakeOpenBoardPkg | KabylakeRvp3
> |
> | WHL-U DDR4 RVP | Whiskey Lake
> | WhiskeylakeOpenBoardPkg | WhiskeylakeURvp |
> +| CML-U LPDDR3 RVP | COmet Lake V1
> | CometlakeOpenBoardPkg | CometlakeURvp |
>
> *Note: RVP = Reference and Validation Platform*
>
> @@ -237,6 +239,11 @@ return back to the minimum platform caller.
> | | | |---build_config.cfg:
> WhiskeylakeURvp specific build
> | | |
> settings environment variables.
> | | |
> + | | |------CometlakeOpenBoardPkg
> + | | | |------CometlakeURvp
> + | | | |---build_config.cfg:
> CometlakeURvp specific build
> + | | |
> settings environment variables.
> + | | |
> |------FSP
> </pre>
>
> @@ -257,6 +264,10 @@ return back to the minimum platform caller.
> 1. This firmware project has only been tested booting to Microsoft Windows
> 10 x64 with AHCI mode and Integrated Graphic
> Device.
>
> +**CometlakeOpenBoardPkg**
> +1. This firmware project has been tested booting to Microsoft Windows 10
> x64 with AHCI mode and External Graphic Device.
> +2. This firmware project has been also tested booting to Ubuntu 17.10 with
> AHCI mode and Integrated Graphic Device.
> +
> ### **Package Builds**
>
> In some cases, such as BoardModulePkg, a package may provide a set of
> functionality that is included in other diff --git a/Platform/Intel/build.cfg
> b/Platform/Intel/build.cfg index 86a9115021..5bc1dea43c 100644
> --- a/Platform/Intel/build.cfg
> +++ b/Platform/Intel/build.cfg
> @@ -1,7 +1,7 @@
> # @ build.cfg
> # This is the main/default build configuration file # -# Copyright (c) 2019,
> Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent #
>
> @@ -58,3 +58,4 @@ BoardX58Ich10 =
> SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
> GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg
> KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> WhiskeylakeURvp =
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
> +CometlakeURvp =
> CometlakeOpenBoardPkg/CometlakeURvp/build_config.cfg
> --
> 2.16.2.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg
2020-02-18 14:53 ` [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg Kathappan Esakkithevar
2020-02-19 4:06 ` Nate DeSimone
2020-02-19 6:43 ` Chiu, Chasel
@ 2020-02-19 7:49 ` Chaganty, Rangasai V
2020-02-19 12:11 ` Kathappan Esakkithevar
2 siblings, 1 reply; 6+ messages in thread
From: Chaganty, Rangasai V @ 2020-02-19 7:49 UTC (permalink / raw)
To: Esakkithevar, Kathappan, devel@edk2.groups.io
Cc: Chiu, Chasel, Desimone, Nathaniel L, Kethi Reddy, Deepika,
Agyeman, Prince
Minor comments - Please see inline
Thanks,
Sai
-----Original Message-----
From: Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com>
Sent: Tuesday, February 18, 2020 6:54 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kethi Reddy, Deepika <deepika.kethi.reddy@intel.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
This change adds the configuration to enable build for CometlakeURvp.
Also it updates Cometlake U Rvp details to the Readme.md.
Signed-off-by: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
Platform/Intel/Readme.md | 11 +++++++++++ Platform/Intel/build.cfg | 3 ++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index 02d9517d19..b5ad8ed5fe 100644
--- a/Platform/Intel/Readme.md
+++ b/Platform/Intel/Readme.md
@@ -56,6 +56,7 @@ A UEFI firmware implementation using MinPlatformPkg is constructed using the fol
[Sai]: typo - it should be "following"
* The `KabylakeOpenBoardPkg` contains board implementations for Kaby Lake systems.
* The `SimicsOpenBoardPkg` contains board implementations for the Simics hardware simulator.
* The `WhiskeylakeOpenBoardPkg` contains board implementations for Whiskey Lake systems.
+* The `CometlakeOpenBoardPkg` contains board implementations for Comet Lake systems.
[Sai]: The systems names should be one word - e.g. CometLake
### **Supported Hardware**
@@ -67,6 +68,7 @@ A UEFI firmware implementation using MinPlatformPkg is constructed using the fol ----------------------------------------|--------------------------------------------|------------------------------|--------------------|
| RVP 3 | Sky Lake, Kaby Lake, Kaby Lake Refresh | KabylakeOpenBoardPkg | KabylakeRvp3 |
| WHL-U DDR4 RVP | Whiskey Lake | WhiskeylakeOpenBoardPkg | WhiskeylakeURvp |
+| CML-U LPDDR3 RVP | COmet Lake V1 | CometlakeOpenBoardPkg | CometlakeURvp |
*Note: RVP = Reference and Validation Platform*
@@ -237,6 +239,11 @@ return back to the minimum platform caller.
| | | |---build_config.cfg: WhiskeylakeURvp specific build
| | | settings environment variables.
| | |
+ | | |------CometlakeOpenBoardPkg
+ | | | |------CometlakeURvp
+ | | | |---build_config.cfg: CometlakeURvp specific build
+ | | | settings environment variables.
+ | | |
|------FSP
</pre>
@@ -257,6 +264,10 @@ return back to the minimum platform caller.
1. This firmware project has only been tested booting to Microsoft Windows 10 x64 with AHCI mode and Integrated Graphic
Device.
+**CometlakeOpenBoardPkg**
+1. This firmware project has been tested booting to Microsoft Windows 10 x64 with AHCI mode and External Graphic Device.
+2. This firmware project has been also tested booting to Ubuntu 17.10 with AHCI mode and Integrated Graphic Device.
+
### **Package Builds**
In some cases, such as BoardModulePkg, a package may provide a set of functionality that is included in other diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index 86a9115021..5bc1dea43c 100644
--- a/Platform/Intel/build.cfg
+++ b/Platform/Intel/build.cfg
@@ -1,7 +1,7 @@
# @ build.cfg
# This is the main/default build configuration file # -# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent #
@@ -58,3 +58,4 @@ BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg
KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
WhiskeylakeURvp = WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
+CometlakeURvp = CometlakeOpenBoardPkg/CometlakeURvp/build_config.cfg
--
2.16.2.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg
2020-02-19 7:49 ` Chaganty, Rangasai V
@ 2020-02-19 12:11 ` Kathappan Esakkithevar
0 siblings, 0 replies; 6+ messages in thread
From: Kathappan Esakkithevar @ 2020-02-19 12:11 UTC (permalink / raw)
To: Chaganty, Rangasai V, devel@edk2.groups.io
Cc: Chiu, Chasel, Desimone, Nathaniel L, Kethi Reddy, Deepika,
Agyeman, Prince
Hi Sai,
I have updated the feedback comments and please help to review at [edk2-devel] [edk2-platforms] [PATCH V2 2/2] Enable build for CometlakeOpenBoardPkg
For comment : > [Sai]: typo - it should be "following"
I saw the Readme.md , below statement is correct as below at line 45.
"A UEFI firmware implementation using MinPlatformPkg is constructed using the following pieces."
Not sure why we are seeing below trimmed lines at patches.
"@@ -53,9 +53,10 @@ A UEFI firmware implementation using MinPlatformPkg is constructed using the fol"
"@@ -237,6 +239,11 @@ return back to the minimum platform caller."
> -----Original Message-----
> From: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Sent: Wednesday, February 19, 2020 1:20 PM
> To: Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com>;
> devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kethi Reddy, Deepika
> <deepika.kethi.reddy@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> Subject: RE: [edk2-platforms] [PATCH V1 2/2] Enable build for
> CometlakeOpenBoardPkg
>
> Minor comments - Please see inline
>
> Thanks,
> Sai
>
> -----Original Message-----
> From: Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com>
> Sent: Tuesday, February 18, 2020 6:54 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kethi Reddy, Deepika
> <deepika.kethi.reddy@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> Subject: [edk2-platforms] [PATCH V1 2/2] Enable build for
> CometlakeOpenBoardPkg
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
>
> This change adds the configuration to enable build for CometlakeURvp.
> Also it updates Cometlake U Rvp details to the Readme.md.
>
> Signed-off-by: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> ---
> Platform/Intel/Readme.md | 11 +++++++++++ Platform/Intel/build.cfg | 3 ++-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index
> 02d9517d19..b5ad8ed5fe 100644
> --- a/Platform/Intel/Readme.md
> +++ b/Platform/Intel/Readme.md
> @@ -56,6 +56,7 @@ A UEFI firmware implementation using MinPlatformPkg is
> constructed using the fol
> [Sai]: typo - it should be "following"
> * The `KabylakeOpenBoardPkg` contains board implementations for Kaby Lake
> systems.
> * The `SimicsOpenBoardPkg` contains board implementations for the Simics
> hardware simulator.
> * The `WhiskeylakeOpenBoardPkg` contains board implementations for
> Whiskey Lake systems.
> +* The `CometlakeOpenBoardPkg` contains board implementations for Comet
> Lake systems.
> [Sai]: The systems names should be one word - e.g. CometLake ###
> **Supported Hardware**
>
> @@ -67,6 +68,7 @@ A UEFI firmware implementation using MinPlatformPkg is
> constructed using the fol ----------------------------------------|-----------------------------
> ---------------|------------------------------|--------------------|
> | RVP 3 | Sky Lake, Kaby Lake, Kaby Lake Refresh |
> KabylakeOpenBoardPkg | KabylakeRvp3 |
> | WHL-U DDR4 RVP | Whiskey Lake |
> WhiskeylakeOpenBoardPkg | WhiskeylakeURvp |
> +| CML-U LPDDR3 RVP | COmet Lake V1 |
> CometlakeOpenBoardPkg | CometlakeURvp |
>
> *Note: RVP = Reference and Validation Platform*
>
> @@ -237,6 +239,11 @@ return back to the minimum platform caller.
> | | | |---build_config.cfg: WhiskeylakeURvp specific build
> | | | settings environment variables.
> | | |
> + | | |------CometlakeOpenBoardPkg
> + | | | |------CometlakeURvp
> + | | | |---build_config.cfg: CometlakeURvp specific build
> + | | | settings environment variables.
> + | | |
> |------FSP
> </pre>
>
> @@ -257,6 +264,10 @@ return back to the minimum platform caller.
> 1. This firmware project has only been tested booting to Microsoft Windows
> 10 x64 with AHCI mode and Integrated Graphic
> Device.
>
> +**CometlakeOpenBoardPkg**
> +1. This firmware project has been tested booting to Microsoft Windows 10
> x64 with AHCI mode and External Graphic Device.
> +2. This firmware project has been also tested booting to Ubuntu 17.10 with
> AHCI mode and Integrated Graphic Device.
> +
> ### **Package Builds**
>
> In some cases, such as BoardModulePkg, a package may provide a set of
> functionality that is included in other diff --git a/Platform/Intel/build.cfg
> b/Platform/Intel/build.cfg index 86a9115021..5bc1dea43c 100644
> --- a/Platform/Intel/build.cfg
> +++ b/Platform/Intel/build.cfg
> @@ -1,7 +1,7 @@
> # @ build.cfg
> # This is the main/default build configuration file # -# Copyright (c) 2019, Intel
> Corporation. All rights reserved.<BR>
> +# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent #
>
> @@ -58,3 +58,4 @@ BoardX58Ich10 =
> SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
> GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg
> KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> WhiskeylakeURvp =
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
> +CometlakeURvp = CometlakeOpenBoardPkg/CometlakeURvp/build_config.cfg
> --
> 2.16.2.windows.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-19 12:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-19 5:37 [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg Kathappan Esakkithevar
-- strict thread matches above, loose matches on Subject: below --
2020-02-18 14:53 [edk2-platforms] [PATCH V1 0/2] Add Cometlake U Silicon support and Enable build Kathappan Esakkithevar
2020-02-18 14:53 ` [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg Kathappan Esakkithevar
2020-02-19 4:06 ` Nate DeSimone
2020-02-19 6:43 ` Chiu, Chasel
2020-02-19 7:49 ` Chaganty, Rangasai V
2020-02-19 12:11 ` Kathappan Esakkithevar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox