Re: [PATCH 14/19] Silicon/NXP/LS1043A: Replce SocLib

["Leif Lindholm" <leif@nuviainc.com>]

On Thu, Feb 13, 2020 at 11:00:10 +0000, Pankaj Bansal wrote:
> > You're talking about the ... bits that remain the same on migrating the
> > processors from PPC to ARM?
> 
> I am not sure if the concept of Chassis was there in PPC or not?
> It's just the way the SOCs are designed. SOCs that are designed
> around same chassis, reuse most of the components.
> It cuts down on s/w development time, because most of the s/w can be
> reused.

Sure, I'm just trying to determine whether this is something I sort of
already understand (like QUICC -> PowerQUICC), or something more internal.

> > > We have kept the code also in such a way. Which is why we have made
> > > Soc Package part of Chassis Package.
> > >
> > > SocLib provides services to PlatformLib. ChassisLib provides services
> > > to SocLib.
> > > Which is why we have made SocGetMpCoreInfo as weak function and
> > > implemented it in ChassisLib (Patch 11/19) This ensures that code can
> > > be reused for all SOCs belonging to same chassis.
> > > If any future SOC implements this feature in different way, then this
> > > API can be overwritten in SocLib
> > >
> > > SOCs belonging to same Chassis share many same traits.
> > > e.g. the SOC memory map is usually common for all SOCs belonging to
> > > same Chassis.
> > 
> > OK, this sounds valid. But one follow-up question: why add the hierarchy at all?
> > From a (human) discoverability standpoint, if someone is looking for the code
> > for a specific SoC, they will be looking for that SoC, not some abstraction of it.
> > 
> > So I agree it makes sense that chassis are not kept under SoC, but I am asking if
> > it would not make more sense to keep them on the same level?
> > Any SoCs depending on Pcds defined by a specific chassis could access those by
> > importing the package fr that chassis.
> 
> Hmm. This can be done. We can make Silicon/NXP/Chassis2 and
> Silicon/NXP/LS1043A.

Sorry, I think I forgot to reply to this.
Yes, this would be most excellent.

Best Regards,

Leif