[edk2-staging/RISC-V-V2 PATCH v1 0/2] Fix MdeModulePkg and MdePkg

[edk2-staging/RISC-V-V2 PATCH v1 0/2] Fix MdeModulePkg and MdePkg

[Abner Chang]

Add RISCV64 arch for building MdeModulePkg and MdePkg packages alone.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Abner Chang (2):
  MdePkg/BaseSafeIntLib: Add RISCV64 arch for BaseSafeIntLib.
  MdeModulePkg: Add RISCV64 arch to MdeModulePkg.

 MdeModulePkg/MdeModulePkg.dsc                    | 7 ++++++-
 MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf | 4 ++--
 2 files changed, 8 insertions(+), 3 deletions(-)

-- 
2.25.0

[edk2-staging/RISC-V-V2 PATCH v1 1/2] MdePkg/BaseSafeIntLib: Add RISCV64 arch for BaseSafeIntLib.

[Abner Chang]

Add RISCV64 arch for BaseSafeIntLib library.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
Cc: Daniel Helmut Schaefer <daniel.schaefer@hpe.com>
Signed-off-by: Abner Chang <abner.chang@hpe.com>
---
 MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf b/MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
index 68ade962d6..a114d771e2 100644
--- a/MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
+++ b/MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
@@ -23,7 +23,7 @@
 #
 # The following information is for reference only and not required by the build tools.
 #
-#  VALID_ARCHITECTURES           = IA32 X64
+#  VALID_ARCHITECTURES           = IA32 X64 ARM AARCH64 RISCV64
 #
 
 [Sources]
@@ -32,7 +32,7 @@
 [Sources.Ia32, Sources.ARM]
   SafeIntLib32.c
 
-[Sources.X64, Sources.AARCH64]
+[Sources.X64, Sources.AARCH64, Sources.RISCV64]
   SafeIntLib64.c
 
 [Sources.EBC]
-- 
2.25.0

[edk2-staging/RISC-V-V2 PATCH v1 2/2] MdeModulePkg: Add RISCV64 arch to MdeModulePkg.

[Abner Chang]

Add RISCV64 arch to MdeModulePkg.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
Cc: Daniel Helmut Schaefer <daniel.schaefer@hpe.com>
Signed-off-by: Abner Chang <abner.chang@hpe.com>
---
 MdeModulePkg/MdeModulePkg.dsc | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
index f7dbb27ce2..a8ee0cc933 100644
--- a/MdeModulePkg/MdeModulePkg.dsc
+++ b/MdeModulePkg/MdeModulePkg.dsc
@@ -14,7 +14,7 @@
   PLATFORM_VERSION               = 0.98
   DSC_SPECIFICATION              = 0x00010005
   OUTPUT_DIRECTORY               = Build/MdeModule
-  SUPPORTED_ARCHITECTURES        = IA32|X64|EBC|ARM|AARCH64
+  SUPPORTED_ARCHITECTURES        = IA32|X64|EBC|ARM|AARCH64|RISCV64
   BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
   SKUID_IDENTIFIER               = DEFAULT
 
@@ -182,6 +182,11 @@
   #
   NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
 
+[LibraryClasses.RISCV64]
+  RiscVCpuLib|RiscVPkg/Library/RiscVCpuLib/RiscVCpuLib.inf
+  RiscVOpensbiLib|RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf
+  RiscVPlatformDxeIplLib|RiscVPkg/Library/RiscVDxeIplHandoffOpenSbiLib/RiscVDxeIplHandoffOpenSbiLib.inf
+
 [LibraryClasses.EBC]
   LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
 
-- 
2.25.0

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 0/2] Fix MdeModulePkg and MdePkg

[Leif Lindholm]

On Sat, Feb 22, 2020 at 22:37:03 +0800, Abner Chang wrote:
> Add RISCV64 arch for building MdeModulePkg and MdePkg packages alone.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>

Don't forget to cc maintainers (and for RISC-V, it makes sense to cc
me as well) :)

You're looking to get this into staging branch, right?
Go ahead:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>


> Abner Chang (2):
>   MdePkg/BaseSafeIntLib: Add RISCV64 arch for BaseSafeIntLib.
>   MdeModulePkg: Add RISCV64 arch to MdeModulePkg.
> 
>  MdeModulePkg/MdeModulePkg.dsc                    | 7 ++++++-
>  MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf | 4 ++--
>  2 files changed, 8 insertions(+), 3 deletions(-)
> 
> -- 
> 2.25.0
> 
> 
> 
> 

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 0/2] Fix MdeModulePkg and MdePkg

[Abner Chang]

> -----Original Message-----
> From: Leif Lindholm [mailto:leif@nuviainc.com]
> Sent: Wednesday, February 26, 2020 8:01 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 0/2] Fix
> MdeModulePkg and MdePkg
> 
> On Sat, Feb 22, 2020 at 22:37:03 +0800, Abner Chang wrote:
> > Add RISCV64 arch for building MdeModulePkg and MdePkg packages alone.
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> 
> Don't forget to cc maintainers (and for RISC-V, it makes sense to cc me as
> well) :)
> 
> You're looking to get this into staging branch, right?
Yes.
And will send the whole set to edk2 once we finish EDK2 CI for RISC-V (soon).

> Go ahead:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> 
> 
> > Abner Chang (2):
> >   MdePkg/BaseSafeIntLib: Add RISCV64 arch for BaseSafeIntLib.
> >   MdeModulePkg: Add RISCV64 arch to MdeModulePkg.
> >
> >  MdeModulePkg/MdeModulePkg.dsc                    | 7 ++++++-
> >  MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf | 4 ++--
> >  2 files changed, 8 insertions(+), 3 deletions(-)
> >
> > --
> > 2.25.0
> >
> >
> > 
> >