* [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
@ 2020-02-26 1:07 Siyuan, Fu
2020-02-26 1:09 ` [edk2-devel] " Liming Gao
2020-02-26 1:39 ` Chaganty, Rangasai V
0 siblings, 2 replies; 4+ messages in thread
From: Siyuan, Fu @ 2020-02-26 1:07 UTC (permalink / raw)
To: devel; +Cc: Ray Ni, Rangasai V Chaganty
This patch fixes a potential compiler error introduced by commit
b0099a39bd since not all compiler can support empty array member.
BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
---
.../Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
index d1a9d79a51..d887b39123 100644
--- a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
+++ b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
@@ -33,7 +33,7 @@ typedef struct {
// An array with MicrocodeCount elements that stores
// the shadowed microcode patch address in memory.
//
- UINT64 MicrocodeAddrInMemory[];
+ UINT64 MicrocodeAddrInMemory[0];
//
// A buffer which contains details about the storage information
// specific to StorageType.
--
2.19.1.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
2020-02-26 1:07 [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error Siyuan, Fu
@ 2020-02-26 1:09 ` Liming Gao
2020-02-26 1:39 ` Chaganty, Rangasai V
1 sibling, 0 replies; 4+ messages in thread
From: Liming Gao @ 2020-02-26 1:09 UTC (permalink / raw)
To: devel@edk2.groups.io, Fu, Siyuan; +Cc: Ni, Ray, Chaganty, Rangasai V
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Siyuan, Fu
> Sent: Wednesday, February 26, 2020 9:08 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Subject: [edk2-devel] [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
>
> This patch fixes a potential compiler error introduced by commit
> b0099a39bd since not all compiler can support empty array member.
>
> BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
> ---
> .../Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
> b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
> index d1a9d79a51..d887b39123 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
> @@ -33,7 +33,7 @@ typedef struct {
> // An array with MicrocodeCount elements that stores
> // the shadowed microcode patch address in memory.
> //
> - UINT64 MicrocodeAddrInMemory[];
> + UINT64 MicrocodeAddrInMemory[0];
> //
> // A buffer which contains details about the storage information
> // specific to StorageType.
> --
> 2.19.1.windows.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
2020-02-26 1:07 [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error Siyuan, Fu
2020-02-26 1:09 ` [edk2-devel] " Liming Gao
@ 2020-02-26 1:39 ` Chaganty, Rangasai V
2020-02-26 2:33 ` Ni, Ray
1 sibling, 1 reply; 4+ messages in thread
From: Chaganty, Rangasai V @ 2020-02-26 1:39 UTC (permalink / raw)
To: Fu, Siyuan, devel@edk2.groups.io; +Cc: Ni, Ray
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: Fu, Siyuan <siyuan.fu@intel.com>
Sent: Tuesday, February 25, 2020 5:08 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
This patch fixes a potential compiler error introduced by commit b0099a39bd since not all compiler can support empty array member.
BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
---
.../Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
index d1a9d79a51..d887b39123 100644
--- a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
+++ b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.
+++ h
@@ -33,7 +33,7 @@ typedef struct {
// An array with MicrocodeCount elements that stores
// the shadowed microcode patch address in memory.
//
- UINT64 MicrocodeAddrInMemory[];
+ UINT64 MicrocodeAddrInMemory[0];
//
// A buffer which contains details about the storage information
// specific to StorageType.
--
2.19.1.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
2020-02-26 1:39 ` Chaganty, Rangasai V
@ 2020-02-26 2:33 ` Ni, Ray
0 siblings, 0 replies; 4+ messages in thread
From: Ni, Ray @ 2020-02-26 2:33 UTC (permalink / raw)
To: Chaganty, Rangasai V, Fu, Siyuan, devel@edk2.groups.io
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Sent: Wednesday, February 26, 2020 9:39 AM
> To: Fu, Siyuan <siyuan.fu@intel.com>; devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: RE: [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
>
> Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
>
> -----Original Message-----
> From: Fu, Siyuan <siyuan.fu@intel.com>
> Sent: Tuesday, February 25, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Subject: [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
>
> This patch fixes a potential compiler error introduced by commit b0099a39bd since not all compiler can support empty
> array member.
>
> BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
> ---
> .../Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
> b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
> index d1a9d79a51..d887b39123 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.
> +++ h
> @@ -33,7 +33,7 @@ typedef struct {
> // An array with MicrocodeCount elements that stores
> // the shadowed microcode patch address in memory.
> //
> - UINT64 MicrocodeAddrInMemory[];
> + UINT64 MicrocodeAddrInMemory[0];
> //
> // A buffer which contains details about the storage information
> // specific to StorageType.
> --
> 2.19.1.windows.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-26 2:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-26 1:07 [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error Siyuan, Fu
2020-02-26 1:09 ` [edk2-devel] " Liming Gao
2020-02-26 1:39 ` Chaganty, Rangasai V
2020-02-26 2:33 ` Ni, Ray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox