From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: devel@edk2.groups.io
Cc: leif@nuviainc.com, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH 0/3] ArmPkg/ArmLib: ASSERT() on misuse of set/way ops
Date: Wed, 26 Feb 2020 14:13:59 +0100 [thread overview]
Message-ID: <20200226131402.30317-1-ard.biesheuvel@linaro.org> (raw)
Talking to Leif on IRC, we decided that deprecating cache maintenance
by set/way, as I proposed in the series I just sent out [0] may be too
strict, especially considering that some v7 based uniprocessor platforms
such as BeagleBoard may actually need it to clean any junk from the caches
before turning them on.
So instead, ensure that this use cache remains supported, but discourage/
prevent misuse by ASSERT()ing that they are only used with the MMU off.
[0] https://edk2.groups.io/g/devel/topic/patch_0_6_armpkg_eradicate/71562844
Ard Biesheuvel (3):
ArmPkg/ArmLib: clean up library includes
ArmPkg/ArmLib: remove bogus protocol declaration
ArmPkg/ArmLib: ASSERT on set/way cache ops being used with MMU on
ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 16 ++++++++++++----
ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c | 17 +++++++++++++----
ArmPkg/Library/ArmLib/ArmBaseLib.inf | 6 +++---
ArmPkg/Library/ArmLib/ArmLib.c | 2 --
4 files changed, 28 insertions(+), 13 deletions(-)
--
2.17.1
next reply other threads:[~2020-02-26 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 13:13 Ard Biesheuvel [this message]
2020-02-26 13:14 ` [PATCH 1/3] ArmPkg/ArmLib: clean up library includes Ard Biesheuvel
2020-02-26 13:14 ` [PATCH 2/3] ArmPkg/ArmLib: remove bogus protocol declaration Ard Biesheuvel
2020-02-26 13:14 ` [PATCH 3/3] ArmPkg/ArmLib: ASSERT on set/way cache ops being used with MMU on Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226131402.30317-1-ard.biesheuvel@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox