From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web11.12284.1582886354288766409 for ; Fri, 28 Feb 2020 02:39:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=di/7eBqX; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.65, mailfrom: pete@akeo.ie) Received: by mail-wm1-f65.google.com with SMTP id t23so2684720wmi.1 for ; Fri, 28 Feb 2020 02:39:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xksiy1TueCHyl9LOKVLU33YGQBgAucE4EbRFbXAjEkM=; b=di/7eBqXoYwIfBsNQTY3Xj7kNcIIJUXtLbat+KWyLR/KtkkOd590UdugCm3yx1pwWj WiuuXZSKugjZh7sN9lpsPjhQZxrdtoQN1cs2gxo5UIlht4ucg8ieGiQNRW+d5k/9zSmi AL9cd4IAlPqdgJIgsOMzpsB/4pI4AYiwyZPnPySIpdAXujxjF2+BTxbnFJteb9b17PxM 6mHeGBVeI0wlEcHufjv0/tWU9Wi2a2/daJA71j1RjES+fGyiOkULexxQzDwkgrHvXwGq NycTC7plvmv1IKY2W/BspxpWY4J4phZmfPB+Lbia1Aahb04zSrA0rVCq2QHlMqECQmTO hILQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xksiy1TueCHyl9LOKVLU33YGQBgAucE4EbRFbXAjEkM=; b=l/uXzT/ScZ6k0L8/7WA90PlCaYQ9qObTaDgEUmHessCw7VDBg9Dxhfswnbhp6PR+Mx oT9J/ZXSmd0r6L2C2ZuFOMxrqwbpx2eNqRzc8OknuhH5c7kPBQ5VoDB462MXx20DIW1z nRrFiHW7NFggV+Au6US3PzcXyFyiNxtcaz+lSqgI6/qIoxO8/NI1jfBZ3Bre+lC2h6zr RQDTzbtW2dxLjoMd39W7Dw5UEctS+aGZaLtLH4RuySW5wcMa2C2gxQGxqIxqpo1su62o pWMGBLYKfIRk6R+AKCqMSnMIQVi669hhWhiIgqGUZdpKRwjFUOgaPle/YQ5vXquGfSwi H5Ng== X-Gm-Message-State: APjAAAXBz6+xpHGXPcrpOL6n9PVdQjQXB8V4lvde9b8nFHsB8iMMcgml OFUBCXAj/OtE0jnj8DBNvPppQBtcJ3c= X-Google-Smtp-Source: APXvYqwgvRBplRGAri2e73jraweLK8ytohgdDFXjThN8Xrda0wldOJZMM1Y/Vqy6vfAWqt7phxsYGg== X-Received: by 2002:a7b:c249:: with SMTP id b9mr4058030wmj.61.1582886352549; Fri, 28 Feb 2020 02:39:12 -0800 (PST) Return-Path: Received: from localhost.localdomain ([84.203.56.244]) by smtp.gmail.com with ESMTPSA id s8sm12341061wrt.57.2020.02.28.02.39.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Feb 2020 02:39:12 -0800 (PST) From: "Pete Batard" To: devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif@nuviainc.com, philmd@redhat.com Subject: [edk2-platforms][PATCH 04/15] Silicon/BcmGenet: Add missing I/O mapping length and clean up Date: Fri, 28 Feb 2020 10:38:44 +0000 Message-Id: <20200228103855.11352-5-pete@akeo.ie> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200228103855.11352-1-pete@akeo.ie> References: <20200228103855.11352-1-pete@akeo.ie> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove unneeded extra parenthesis on PCD, which can cause problems when used with ACPI ASL macros and add an [Includes] section to the .inf, so that the Genet.h header can be referenced where required. Signed-off-by: Pete Batard --- Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h | 3 ++- Silicon/Broadcom/Drivers/Net/BcmNet.dec | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h b/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h index 4a3827c0e0d1..f56fb2977422 100644 --- a/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h +++ b/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h @@ -11,7 +11,8 @@ #include -#define GENET_BASE_ADDRESS (FixedPcdGet64 (PcdBcmGenetRegistersAddress)) +#define GENET_BASE_ADDRESS FixedPcdGet64 (PcdBcmGenetRegistersAddress) +#define GENET_LENGTH 0x00010000 #define GENET_SYS_RBUF_FLUSH_CTRL 0x0008 #define GENET_UMAC_MAC0 0x080c diff --git a/Silicon/Broadcom/Drivers/Net/BcmNet.dec b/Silicon/Broadcom/Drivers/Net/BcmNet.dec index 2a8688cb09a7..483b033af51c 100644 --- a/Silicon/Broadcom/Drivers/Net/BcmNet.dec +++ b/Silicon/Broadcom/Drivers/Net/BcmNet.dec @@ -12,6 +12,9 @@ [Defines] PACKAGE_GUID = 34E19823-D23A-41AB-9C09-ED1225B32DFF PACKAGE_VERSION = 1.0 +[Includes] + . + [Guids] gBcmNetTokenSpaceGuid = {0x12b97d70, 0x9149, 0x4c2f, {0x82, 0xd5, 0xad, 0xa9, 0x1e, 0x92, 0x75, 0xa1}} -- 2.21.0.windows.1