From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web11.12386.1583145228879747385 for ; Mon, 02 Mar 2020 02:33:49 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=033048287c=daniel.schaefer@hpe.com) Received: from pps.filterd (m0150245.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 022ANggE002564; Mon, 2 Mar 2020 10:33:48 GMT Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 2ygxxb0v1p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Mar 2020 10:33:48 +0000 Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 43AD2A9; Mon, 2 Mar 2020 10:33:47 +0000 (UTC) Received: from G4W9335.americas.hpqcorp.net (16.208.33.85) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Mar 2020 10:33:38 +0000 Received: from G2W6311.americas.hpqcorp.net (16.197.64.53) by G4W9335.americas.hpqcorp.net (16.208.33.85) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Mar 2020 10:33:17 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.241.52.10) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 2 Mar 2020 10:33:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I6fBLTr+I83xbr6/HYwvHko9IzzL8VWHXT2Eyw1g9qz7GHadfJWze/rnIm4Yek/9yW8XWOSrAAEDIZAkP+0yxlnZyyApPeF2OLCRUUuQgB4Uir3oR0xv0/5DlvWEniQ6ASbWvKJFIbg34TIXPIfyUI5xwY502cEr/rpfT4Zp3Raya74G8EMzg7ImO4dEefQFKCVXQ3xbvjkEajw+1075aijJe8Y48eLwN54cQ8OZfrz4AIoG+W2IPxsBYwLRnE6skXqEBNPamWbA69xa9UeY2SRG5R8nwB4Q8MhGeZnwZJ7wPs4vRSGtP1/+t3dbDz1PlNJvkrXeGliRaG+Yp30fDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=De8v6jDFytgkn+g/lThrPP3GXUtiYyel/tin9WD9Trg=; b=a5deneD/MBS9LAmnOtqAkdh2+Fra0OB+t3sTcPjhx2PxOwD6h2die5VuPB4iNeZ8vXXVgv4t0bEnsYVbh0jxsku56l+Fyb36FgMdZMJSLdYtnhXrvTM8n7f1sKM4ctyIXfxYkFxy48Fs83z+Yo7GBLu9xmgG34E5M42B3x0citchok+3+8xf+p1h6OTsCWw4rPkYJbh2++ljit8RAGfyq8H29rTq6OOA+LYp3fIftEfu4fYvUdNztIPWdBI2/78cxTUalOsz7WQNtKm8yujEnhOJmnXZGW0yY1qi8y31ZUSml/lKYlKIvfquHXpOnCGLlTZBi0IJoAeRvnHxFcKGgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7710::14) by TU4PR8401MB1248.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7715::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.18; Mon, 2 Mar 2020 10:32:56 +0000 Received: from TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a138:305f:61e2:16ae]) by TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a138:305f:61e2:16ae%5]) with mapi id 15.20.2772.019; Mon, 2 Mar 2020 10:32:56 +0000 From: "Daniel Schaefer" To: CC: Abner Chang , Gilbert Chen , Leif Lindholm , Eric Dong , Ray Ni , Hao A Wu , Dandan Bi , Liming Gao Subject: [PATCH v2 1/3] MdeModulePkg: Restrict libraries using SMM to x86 Date: Mon, 2 Mar 2020 11:32:36 +0100 Message-ID: <20200302103238.25726-2-daniel.schaefer@hpe.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200302103238.25726-1-daniel.schaefer@hpe.com> References: <20200302103238.25726-1-daniel.schaefer@hpe.com> X-ClientProxiedBy: FR2P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::23) To TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7710::14) X-MS-Exchange-MessageSentRepresentingType: 1 Received: from x360-nix.fritz.box (84.58.209.92) by FR2P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.15 via Frontend Transport; Mon, 2 Mar 2020 10:32:54 +0000 X-Mailer: git-send-email 2.25.0 X-Originating-IP: [84.58.209.92] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 54eb5d71-7ce5-4b71-110a-08d7be95128a X-MS-TrafficTypeDiagnostic: TU4PR8401MB1248: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1051; X-Forefront-PRVS: 033054F29A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(366004)(396003)(136003)(376002)(346002)(39860400002)(189003)(199004)(66946007)(66476007)(6666004)(6916009)(4326008)(66556008)(2906002)(36756003)(86362001)(478600001)(6512007)(5660300002)(8676002)(44832011)(19627235002)(54906003)(6486002)(8936002)(81166006)(81156014)(52116002)(6506007)(956004)(316002)(2616005)(26005)(16526019)(186003)(1076003);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR8401MB1248;H:TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ka9n8hZhbVXva4Gb+nRKqCnaOIPtvyg6QwMYp8zTE5E/wuaHXmD5BfYLUrj4YXjNT53EJ4KHRgYYm2dKIrEOfE0iboDc5HmhiTA/Pb9IE+svCbfMXxx2mU0z2dWufiBKhcIm1gTXOfpn7wojcW+R4ZLK4+JNenHBsIMJE+QYLYOOeendxJWT/shrdsWTr6Ei9QJ02yrTGumpijFx6WEyJMSSRYj7lokCkAGl3jKbaHnfI7s3Dl2KyirFCUfGsDlGnXtWEAlcr/CDDOi7e3xBdgdLoDPLBSNbTIfDMDpP5UBSGBAXvFsCBZlKQRLsi5DHLnecbGjOQKcKQozR0jBQMYPgNVvFCr8h/8kXg0cokyn0cJElLJ79fyODq4beC4wH2f6H1TYgOiRD+xP9rZa+gbyuNArhunAoMEtqxpa6jZ0MV15f3bNzQH2d918RQMxjFP/cgXp4Loll35bMRpfOpPWr4Nw3E7/WCOGve7HUAZgxraP8GkxZzjp7NeoG375rlJuIzI5WAA6dY6UDWIN8FA== X-MS-Exchange-AntiSpam-MessageData: f4rfHaLGDSLQh1s0D+H9BBEdSCqnC9v7l2xbjq5CYp59/UGtbfRonsEwasdiJ+7bBxNwkNK/8mzfWLnQU1DBmRacSKd2PFTWQBGhR2KIZ3Hn7iNm9SyMNe4kvnYEK2crWlzs764bQJAg7muLIcXprg== X-MS-Exchange-CrossTenant-Network-Message-Id: 54eb5d71-7ce5-4b71-110a-08d7be95128a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2020 10:32:56.8576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P8nnbp6v8Xunr2AplCByQCi1WMlsjsUxgAJteK5EOF2QaCv+ohPyQyDbSF8SLb28F1votMxppboBE0G5xBBglA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB1248 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-03-02_03:2020-02-28,2020-03-02 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 bulkscore=0 mlxlogscore=999 impostorscore=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 mlxscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003020081 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable The modules: MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerfo= rmanceDxe.inf seem like they are independent of SMM but they actually do requires SMM's LockBoxLib. Ideally they would be rewritten to not require SMM on non x86. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2549 Signed-off-by: Daniel Schaefer Cc: Abner Chang Cc: Gilbert Chen Cc: Leif Lindholm Cc: Eric Dong Cc: Ray Ni Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao --- Notes: v2: - Fix IA86 -> IA32 [Mike] MdeModulePkg/MdeModulePkg.dsc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc index f7dbb27ce25d..5a20722a4270 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ b/MdeModulePkg/MdeModulePkg.dsc @@ -109,6 +109,8 @@ [LibraryClasses.common.PEIM] HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf=0D MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAlloc= ationLib.inf=0D ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExt= ractGuidedSectionLib.inf=0D +=0D +[LibraryClasses.IA32.PEIM, LibraryClasses.X64.PEIM]=0D LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf=0D =0D [LibraryClasses.common.DXE_CORE]=0D @@ -228,7 +230,6 @@ [Components] MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf=0D MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/IncompatiblePciDevi= ceSupportDxe.inf=0D MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf=0D - MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf=0D MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf=0D MdeModulePkg/Bus/Pci/SdMmcPciHcPei/SdMmcPciHcPei.inf=0D MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcBlockIoPei.inf=0D @@ -251,7 +252,6 @@ [Components] MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf=0D MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf=0D MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf=0D - MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf=0D MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf=0D MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf=0D MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf=0D @@ -395,7 +395,6 @@ [Components] =0D LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf=0D }=0D - MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerf= ormanceDxe.inf=0D MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsRes= ourceTableDxe.inf=0D MdeModulePkg/Universal/SectionExtractionDxe/SectionExtractionDxe.inf {=0D =0D @@ -447,6 +446,8 @@ [Components.IA32, Components.X64, Components.ARM, Compo= nents.AARCH64] [Components.IA32, Components.X64]=0D MdeModulePkg/Universal/DebugSupportDxe/DebugSupportDxe.inf=0D MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.inf= =0D + MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf=0D + MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf=0D MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf=0D MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf=0D MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf {=0D @@ -478,6 +479,7 @@ [Components.IA32, Components.X64] MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf= =0D MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaArchCustomDecompressLib= .inf=0D MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutorDxe.= inf=0D + MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerf= ormanceDxe.inf=0D MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf=0D MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.inf=0D MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableSmm/FirmwarePerf= ormanceSmm.inf=0D @@ -487,6 +489,7 @@ [Components.IA32, Components.X64] MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBufferD= xe.inf=0D MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf=0D =0D +=0D [Components.X64]=0D MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf=0D =0D --=20 2.25.0