From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web11.12379.1583145200030689468 for ; Mon, 02 Mar 2020 02:33:20 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=033048287c=daniel.schaefer@hpe.com) Received: from pps.filterd (m0150242.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 022AWKjC007530; Mon, 2 Mar 2020 10:33:19 GMT Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0a-002e3701.pphosted.com with ESMTP id 2yg1ve05j5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Mar 2020 10:33:19 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id A9A5272; Mon, 2 Mar 2020 10:33:18 +0000 (UTC) Received: from G9W8672.americas.hpqcorp.net (16.220.49.31) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Mar 2020 10:33:18 +0000 Received: from G2W6311.americas.hpqcorp.net (16.197.64.53) by G9W8672.americas.hpqcorp.net (16.220.49.31) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Mar 2020 10:33:18 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.241.52.10) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 2 Mar 2020 10:33:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UijHh4kYkkybt0jmNtPjW7IgpSOUHW/PtMq0obF8cJyrfJP3WHH7KZyGnS2mv/nh/i7BRCYe7nDPy73UP8rGLcgCQioAmUhK7SNIPf6YYD241IqNGFpCZR8nH/V8xXfh+E5Co8twk95jdHChvE5HDvNPWumCYt2wf4En/l62PyrdYu2I4c4H4aDl6E8qAQSE+EcttV+/FbRcBAtBwrLfqHbsmjO+rlrduOD4FhUsVniA4h8Od9whQo8W3qV2ssCDdmtUQp5fqk2laMaAp498SejApewBO+G7biXU78yf+PiPASvQjXSNo+FrbM51jyD+glgB0/4Qw0Qg52clTO3M2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e2pdHMtQYCdkInKco+68LpyKYYKQVvQMWPj9rn5sdZM=; b=Dhee3FyLiyKkGgx1AkgKVMxjh51LFLVx8I1kem4gyQy/OlPFEMntTmDlVk+W8WgoA7btPm7vXtmMG0a72xvy83vEl/hIDXH8nHNMKOCxJlu+V+F+3iU1+oLgzkNhM5659utGRyT5Hw4XL3b+LlUuXjy3931MqcepX394rGcF7KjdVrx3/BS496LGGbnTugdDP9eqE5ebLFPSS396qIaXqn8g5yyEK9EsC4ZZ0fL2JfBgj/t7IlA7sr/3g4UuwMyU7CYpG7vVC5FN9HqKeWehc865O1twIqiHw6LmTlqNlW+0QxUYfKY8tZ3TsmhoLAgKGfHhdAGVX6ooe7lZzXJIiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7710::14) by TU4PR8401MB1248.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7715::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.18; Mon, 2 Mar 2020 10:33:01 +0000 Received: from TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a138:305f:61e2:16ae]) by TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a138:305f:61e2:16ae%5]) with mapi id 15.20.2772.019; Mon, 2 Mar 2020 10:33:00 +0000 From: "Daniel Schaefer" To: CC: Abner Chang , Gilbert Chen , Leif Lindholm , Dandan Bi , Eric Dong Subject: [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment Date: Mon, 2 Mar 2020 11:32:38 +0100 Message-ID: <20200302103238.25726-4-daniel.schaefer@hpe.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200302103238.25726-1-daniel.schaefer@hpe.com> References: <20200302103238.25726-1-daniel.schaefer@hpe.com> X-ClientProxiedBy: FR2P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::23) To TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7710::14) X-MS-Exchange-MessageSentRepresentingType: 1 Received: from x360-nix.fritz.box (84.58.209.92) by FR2P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.15 via Frontend Transport; Mon, 2 Mar 2020 10:32:59 +0000 X-Mailer: git-send-email 2.25.0 X-Originating-IP: [84.58.209.92] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 495a85e0-331e-4a30-3a81-08d7be9514d2 X-MS-TrafficTypeDiagnostic: TU4PR8401MB1248: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:393; X-Forefront-PRVS: 033054F29A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(366004)(396003)(136003)(376002)(346002)(39860400002)(189003)(199004)(66946007)(66476007)(6666004)(6916009)(4326008)(66556008)(2906002)(36756003)(86362001)(478600001)(6512007)(966005)(5660300002)(8676002)(44832011)(54906003)(6486002)(8936002)(81166006)(81156014)(52116002)(6506007)(956004)(316002)(2616005)(26005)(16526019)(186003)(1076003);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR8401MB1248;H:TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nTxo4BdPU/6pNv2u745ju7e3cQGhJPfH0iZrFyKoG2NMWw5IEHa2caWT8kARuoJi9p5CoCbluZ0MTUuUkUhSWR+rqkseXFvahPdJfx3SmGz0y523HV34snD4dNJ4R/RdPa+zGPvAW6wpxhsFM6eKZlD1lORRv6Iuzq77Y0OIG/ufU5mr2nCibvGfLUI7PYKYi8VbaVrjHewL1vOaZbtNhDsNx1mbntoLKEgRqO8HRIN15LBiusutAbNDF2KSNCqRHTQcyHos0HDxpmYKaKomJdifHUkTovWnHqmGqgCOHyHEvxTNVvY2EGNx9C8bOZR/6yvrFuasFHD7mH0dzqPRWKw+Zm18NftcyGbeWHn7qQpVMQbIj2i3oaeHk5GP0ZH/UmloBiOeWKgU76aw/P4xSemLsrnPaEtHYSHs7NHW1HY06I4LTk07xd0Fbtf/oHZ2uESL8FDjfJLVOm84nB8wM+GvyxVvthNQrRYnNKTypwVcW5fUCPITuI5B+QIMzNCUPQykIwaH+EWkTnC7PzWkOA== X-MS-Exchange-AntiSpam-MessageData: xZ7e9pkNcefooTqH4xfXCPfKiHLn9vbQZDGBW0pLFn6+l11X5SPijkjNaEult2ZvYJ1LofcN1/YJhBuPVDIygFZiVquMA5yoM4FPOjjF6xt1HS4X2NjRjocoXaOJ79lKuiN5uGYXVyzoO419tD1GPw== X-MS-Exchange-CrossTenant-Network-Message-Id: 495a85e0-331e-4a30-3a81-08d7be9514d2 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2020 10:33:00.8149 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UcpCY2LpVVR5FsfgjYOVXsOXPMnQrx0XLZ1wTgzJ+yCOKFLlNWkWv06pAUkCjI+9rdALpy7KjQ3wWqgec4UaSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB1248 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-03-02_03:2020-02-28,2020-03-02 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 mlxscore=0 priorityscore=1501 adultscore=0 clxscore=1015 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003020081 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable GCC translates a simple assignment to memcpy, which EDKII doesn't provide. See: https://www.mail-archive.com/edk2-devel@lists.01.org/msg11928.html REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2547 Signed-off-by: Daniel Schaefer Cc: Abner Chang Cc: Gilbert Chen Cc: Leif Lindholm Cc: Dandan Bi Cc: Eric Dong --- Notes: v2: - Use CopyMem instead of CopyGuid [Dandan] MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c b/MdeM= odulePkg/Library/DeviceManagerUiLib/DeviceManager.c index 5cc527679a78..0540e6fa8a44 100644 --- a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c +++ b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c @@ -619,7 +619,7 @@ CreateDeviceManagerForm( TokenHelp =3D HiiSetString (HiiHandle, 0, String, NULL);=0D FreePool (String);=0D =0D - FormSetGuid =3D ((EFI_IFR_FORM_SET *)Ptr)->Guid;=0D + CopyMem (&FormSetGuid, &((EFI_IFR_FORM_SET *) Ptr)->Guid, sizeof (= EFI_GUID));=0D =0D //=0D // Network device process=0D --=20 2.25.0