From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66])
 by mx.groups.io with SMTP id smtpd.web10.13797.1583154728782881784
 for <devel@edk2.groups.io>;
 Mon, 02 Mar 2020 05:12:09 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=ObwG/PHz;
 spf=pass (domain: nuviainc.com, ip: 209.85.128.66, mailfrom: leif@nuviainc.com)
Received: by mail-wm1-f66.google.com with SMTP id u9so4737810wml.3
        for <devel@edk2.groups.io>; Mon, 02 Mar 2020 05:12:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=TYXSKaAc8TNh8Lozj9ZtWtUGF0rtAQMFLPy/wJi0S5k=;
        b=ObwG/PHzTrQvW8Hlit+Lh/zMKrnC/DKTox3ZT3iUjYtEp/3PTHpoQ0sHQoiJrBssGb
         jOEFRxSGMk99BB3ksiGyDJgI2wRJGA5BSV/oFUTXi/Ok3A1Sx9psOLN80aK/F2AOtNap
         9wkvEHkCZezXsxYtnjQe9JmIWu0HAD+3IXV10N1b8MVsy0NRmHSouCQKHmEOgzKisJym
         +mpkbbh08Ngi5HZcjY3JOhMTm0QJuYLHg2yPefdrlzhWDj5BhSOiPvBohP9saBCV3oox
         7JczHbm2FfXjmcWOqY3awwZf+lBWqqkU/eKNQFV205DOhAA9ucs4XALdaXCpEGKFH2Nq
         jalQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=TYXSKaAc8TNh8Lozj9ZtWtUGF0rtAQMFLPy/wJi0S5k=;
        b=F7rQA4SzoT2uhzDv1JK1POOElf3rhgRND9R0kNKCtK4b1b2y/WghlUVdNTe+KigH93
         1yea0ccy41oMYdd/5Nykp8AsLJLXxD5x9aceHoHNZrWrb+yjvnqkxPth7XMJNyHt0Y3a
         ElqAXALzVGzfnqsWGGdA1NjzR6gh3Jxur9YT2XgD0tZCZwdOGQiQj4biJK6uBofxlmzK
         fAG3ilLqOm7fJBq6bG5AUGRl/eLiyosmT5lmsM5tSMfpcQhfu1JgwLprN2hGie2uIk+5
         ZwoXKllWdPM+6SVspaKq+iMVw0wXTfiBO4UQWRcSmJJBDDKMCHONX1CkkBUWE8IdAJIu
         irCQ==
X-Gm-Message-State: APjAAAX1s17xSUb77egvZP2lCYpSj7H7flracbT64rA7WwRmTRF5Tna1
	oNb5ddEp+6UZ7JyEKc4B9MqMCwik/Eo=
X-Google-Smtp-Source: APXvYqzfXQFmsB5UtY3NUGjuA3OU5OqN0YbtAVUaxgAwRwEcLTDndp4omTrQ67nIn2kiK7IbkZnx4A==
X-Received: by 2002:a05:600c:24d2:: with SMTP id 18mr19922603wmu.149.1583154727405;
        Mon, 02 Mar 2020 05:12:07 -0800 (PST)
Return-Path: <leif@nuviainc.com>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id z16sm27403717wrp.33.2020.03.02.05.12.06
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 02 Mar 2020 05:12:07 -0800 (PST)
Date: Mon, 2 Mar 2020 13:12:05 +0000
From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH 1/1] ArmPkg/MmCommunicationDxe: fix logic bug in DXE driver entrypoint
Message-ID: <20200302131205.GJ23627@bivouac.eciton.net>
References: <20200226124103.17125-1-ard.biesheuvel@linaro.org>
 <20200302125744.GG23627@bivouac.eciton.net>
 <CAKv+Gu_Y7cUzOBVJPk0Z0ekM3aLT0YgtrMOEF4HerV9epnu1aQ@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAKv+Gu_Y7cUzOBVJPk0Z0ekM3aLT0YgtrMOEF4HerV9epnu1aQ@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Mar 02, 2020 at 14:00:54 +0100, Ard Biesheuvel wrote:
> On Mon, 2 Mar 2020 at 13:57, Leif Lindholm <leif@nuviainc.com> wrote:
> >
> > On Wed, Feb 26, 2020 at 13:41:03 +0100, Ard Biesheuvel wrote:
> > > Commit 2fe25a74d6fee3c2 ("ArmPkg/MmCommunicationDxe: relay architected PI
> > > events to MM context") update the ARM specific standalone MM client
> > > driver to register for certain events in the entrypoint code, but did
> > > so in a way that makes the entrypoint always return with an error.
> > >
> > > Instead, return EFI_SUCCESS if registering for those events succeeds,
> > > and back out the registrations that did succeed if one fails, and
> > > return an error.
> > >
> > > Fixes: 2fe25a74d6fee3c2 ("ArmPkg/MmCommunicationDxe: relay architected PI events to MM context")
> > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >
> > Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> >
> 
> Thanks.
> 
> > Are you looking for this one to make the stable tag? You're not
> > explicitly asking for it, but you're cc:ing Liming.
> >
> 
> I don't think it is terribly useful to get this into the stable tag,
> given that the standalone MM support is not complete yet, and stalled
> on a PI spec update.
> But by the same reasoning, it could go in as well, since it is an
> obvious bugfix, and the risk is low.
> 
> I don't really care either way tbh, I just wanted to make Liming aware of it.

Thanks for explanation.
I'd say leave it then - if tag gets pushed Wednesday as I think the
current plan is, you can push it then.

/
    Leif