Re: [PATCH 6/6] ArmPkg/ArmLib: deprecate set/way cache maintenance routines

["Leif Lindholm" <leif@nuviainc.com>]

On Wed, Feb 26, 2020 at 11:03:53 +0100, Ard Biesheuvel wrote:
> Cache maintenance on ARMv7 systems and up should be done by virtual
> address if the purpose is to manage the cached state of contents of
> memory. Set/way operations are only intended to maintain the caches
> themselves, e.g., to ensure that the contents of dirty cachelines
> are brought to main memory before the core is powered off entirely.
> 
> UEFI on ARM is typically not involved in the latter at all, and any
> cache maintenance it does is to ensure that the memory it occupies
> and modifies remains in a consistent state with respect to the
> caches.
> 
> So let's deprecate the set/way routines now that we have removed all
> uses of it in the core code.

Does this patch simply get dropped in favour of the ASSERT variant?

/
    Leif

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  ArmPkg/Include/Library/ArmLib.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/ArmLib.h
> index 5a27b7c2fc27..8330339302ca 100644
> --- a/ArmPkg/Include/Library/ArmLib.h
> +++ b/ArmPkg/Include/Library/ArmLib.h
> @@ -156,6 +156,8 @@ ArmIsMpCore (
>    VOID
>    );
>  
> +#ifndef DISABLE_NEW_DEPRECATED_INTERFACES
> +
>  VOID
>  EFIAPI
>  ArmInvalidateDataCache (
> @@ -169,6 +171,8 @@ ArmCleanInvalidateDataCache (
>    VOID
>    );
>  
> +#endif
> +
>  VOID
>  EFIAPI
>  ArmCleanDataCache (
> -- 
> 2.17.1
>