From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web11.13725.1583154805201925593 for ; Mon, 02 Mar 2020 05:13:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=o78GwOcn; spf=pass (domain: nuviainc.com, ip: 209.85.221.65, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f65.google.com with SMTP id l5so12525440wrx.4 for ; Mon, 02 Mar 2020 05:13:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XVaem82OkcHlpZ+QpreeyWZt8RYEjE7AUOIRoCJb6XA=; b=o78GwOcn7YtKyjTq6PG0s1/OmZv9kZThlTOrt9psAKXcaVF/6rYYm4p1tXxhpGlPNz A6anSpx1GauktN1/Y1rYvbvZxYcn2dvJMnT10qgUcJ+3nkMtHrua6FDLnb63VbVapbwg gR/IcNMDXvqGKgSUwVTTKyS70pXbx9TS1Sj8xGUz3KrINwDrrJbVDIIyHDJ2l5MXcY+d QVwLFkazG7IttJhPfMzctcBuZhNdJx2nNfqkH654seotuj+Xi0Pkwd6KX3bnr+BaSKvz PHsh18tcs7dJWE+yhOkokOTFszwyOxkVMBKx0Cx/WOHGhjvuEIe9WKf+1jikoy1dYOLP oxoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XVaem82OkcHlpZ+QpreeyWZt8RYEjE7AUOIRoCJb6XA=; b=dn1q4HLAC/gwctDFNyG7uAmDQxqZZIQRS8nPiJ18lwUyV47dJXWZwYKAenYESaeLuM ZOPymxmrERt3eN92Jre4d0wFFsegx2KiUr16VA4DdeOKEc9UFmc2RLNED7XTzHzcjShj OLAYRiBxNZprYsHgkWcXZVMlhF/zmea+ExEPQ8S0AsScESZ8kPhBkke1SjaGCXbvnhMA wrSbeF0Spwv9EpTgjqZvaRFjipDUyI0vmOKLpiRrJvqVevnvuCLV2U1oQg22E+u6KRHp xEZuGM9DEXQYGtPnhCkpWNE/AfCTq+yaZPumiJx/TGy84y1AorV8NSbKWnZ2hZkOdn8y s4JQ== X-Gm-Message-State: APjAAAWn/sSDIuRAUWeXCvkLe5OYL8Ag9Bg6ITYzv7ZxYheYzvJ6cOBj EYD6GzSwNOiUuSIZQw6VFG6wag== X-Google-Smtp-Source: APXvYqwAcCqLQXvv7+iDg0KYKFs3SUaL9t0i+5MNW5sAsg+hCtGTFJdCrQV4AH7YM0EVI4bi0K143g== X-Received: by 2002:a05:6000:4b:: with SMTP id k11mr22161439wrx.362.1583154803815; Mon, 02 Mar 2020 05:13:23 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u20sm7116127wmj.14.2020.03.02.05.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2020 05:13:23 -0800 (PST) Date: Mon, 2 Mar 2020 13:13:21 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, lersek@redhat.com, sami.mujawar@arm.com Subject: Re: [PATCH 6/6] ArmPkg/ArmLib: deprecate set/way cache maintenance routines Message-ID: <20200302131321.GK23627@bivouac.eciton.net> References: <20200226100353.31962-1-ard.biesheuvel@linaro.org> <20200226100353.31962-7-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20200226100353.31962-7-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 26, 2020 at 11:03:53 +0100, Ard Biesheuvel wrote: > Cache maintenance on ARMv7 systems and up should be done by virtual > address if the purpose is to manage the cached state of contents of > memory. Set/way operations are only intended to maintain the caches > themselves, e.g., to ensure that the contents of dirty cachelines > are brought to main memory before the core is powered off entirely. > > UEFI on ARM is typically not involved in the latter at all, and any > cache maintenance it does is to ensure that the memory it occupies > and modifies remains in a consistent state with respect to the > caches. > > So let's deprecate the set/way routines now that we have removed all > uses of it in the core code. Does this patch simply get dropped in favour of the ASSERT variant? / Leif > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/Include/Library/ArmLib.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/ArmLib.h > index 5a27b7c2fc27..8330339302ca 100644 > --- a/ArmPkg/Include/Library/ArmLib.h > +++ b/ArmPkg/Include/Library/ArmLib.h > @@ -156,6 +156,8 @@ ArmIsMpCore ( > VOID > ); > > +#ifndef DISABLE_NEW_DEPRECATED_INTERFACES > + > VOID > EFIAPI > ArmInvalidateDataCache ( > @@ -169,6 +171,8 @@ ArmCleanInvalidateDataCache ( > VOID > ); > > +#endif > + > VOID > EFIAPI > ArmCleanDataCache ( > -- > 2.17.1 >