From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web12.10239.1583323880931676786 for ; Wed, 04 Mar 2020 04:11:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=ljnMXZ1t; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id i9so1790323wml.4 for ; Wed, 04 Mar 2020 04:11:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QqgxstMpi4LR6mc/5JYQRskmpHwZx+LWdMeThrJE/ts=; b=ljnMXZ1tm+yu6ebkc9sGNgC67OO9VyEewtta4iIVQP2CDK2YYX4ggD7nryoRyA04Me u8AFeuFV3qJlnDX/RTMTwsImxvW72euaa6gfi/V/kA5+cGuLPe/4U2rOhA4hJS8IrAIG JFLGYerXxNNr3YUINEsBUqXNmpZzHFR9QoD6RmfT4xrbzbkInN3Yx91oD5QkrUtBudfV oHASFa07l4P4XEcEnV8A0ndVUuSKUDIKYVONqfuncpwaEoUZ5FEX3/xtOtt9slr2hRCn ueFW7YDp9mvKTy2qGVhbNZRENF00UQdbEWgsXTDSnrJTJM/I5hyUiEc9qzvH9sVhLS4E rJ9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QqgxstMpi4LR6mc/5JYQRskmpHwZx+LWdMeThrJE/ts=; b=RL+CIwfyNuSTauVh0lFzk9JzfEbKdi0RjFJDVmrbLQP0NxAwzwxyne0OY+9yM5coHH haAleD0D0KC6mC5JyRPfJ3Pl1xbICP4GEJhkM+5Ih/ppdrx1iYXz7g2MI1DHYicYuc7j xSo5F8D0zpIuTCxWH2PnOmdhVkUItONTsz+Uns5f9AQF3p6H705uAPBvRd44O//9hmkk 7YvfURIQhIh3VNBML3ONVD6INeG1jxM6F8kl6jY8qFb0JKXvMA2jV+fbaOb80EibPwzE rjKCKHbEuM26Ggs8rgsj41enVGbcrQHslhH/4ovSQuU5BL99QNZkkTMSDgF295FZ5OFp hxfw== X-Gm-Message-State: ANhLgQ3EyOuikVWG+sbvw8+EToS+EOfWwbQyL2PEhmTpJBYrxx2IlCDn 9X6sPk6JGXu5X2XLYMfs3ZgkrA== X-Google-Smtp-Source: ADFU+vue0GslgckuS5sSZrWurxGdFJiYV/A9C24UlPadnxdFAW0ihojoy4iH5EtWJEw/UFEM/b0txw== X-Received: by 2002:a05:600c:1007:: with SMTP id c7mr3400510wmc.158.1583323879473; Wed, 04 Mar 2020 04:11:19 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h3sm41313454wrb.23.2020.03.04.04.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 04:11:19 -0800 (PST) Date: Wed, 4 Mar 2020 12:11:17 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH 1/1] ArmPlatformPkg/LcdGraphicsOutputDxe: add missing protocol dependency Message-ID: <20200304121117.GT23627@bivouac.eciton.net> References: <20200304115841.18243-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20200304115841.18243-1-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 04, 2020 at 12:58:41 +0100, Ard Biesheuvel wrote: > This driver depends on the gEfiCpuArchProtocolGuid protocol but does > not declare it, and so this dependency gets satisfies transitively > via ArmLib. However, ArmLib will drop this dependency as it does not > actually use it, so declare it for LcdGraphicsOutputDxe instead. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf > index 2176e5a5789f..27453b265611 100644 > --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf > +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf > @@ -38,6 +38,7 @@ [LibraryClasses] > UefiLib > > [Protocols] > + gEfiCpuArchProtocolGuid > gEfiDevicePathProtocolGuid > gEfiGraphicsOutputProtocolGuid > > -- > 2.17.1 >