* [PATCH 1/1] ArmPlatformPkg/LcdGraphicsOutputDxe: add missing protocol dependency
@ 2020-03-04 11:58 Ard Biesheuvel
2020-03-04 12:11 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2020-03-04 11:58 UTC (permalink / raw)
To: devel; +Cc: leif, Ard Biesheuvel
This driver depends on the gEfiCpuArchProtocolGuid protocol but does
not declare it, and so this dependency gets satisfies transitively
via ArmLib. However, ArmLib will drop this dependency as it does not
actually use it, so declare it for LcdGraphicsOutputDxe instead.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf | 1 +
1 file changed, 1 insertion(+)
diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
index 2176e5a5789f..27453b265611 100644
--- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
+++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
@@ -38,6 +38,7 @@ [LibraryClasses]
UefiLib
[Protocols]
+ gEfiCpuArchProtocolGuid
gEfiDevicePathProtocolGuid
gEfiGraphicsOutputProtocolGuid
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ArmPlatformPkg/LcdGraphicsOutputDxe: add missing protocol dependency
2020-03-04 11:58 [PATCH 1/1] ArmPlatformPkg/LcdGraphicsOutputDxe: add missing protocol dependency Ard Biesheuvel
@ 2020-03-04 12:11 ` Leif Lindholm
2020-03-04 17:46 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2020-03-04 12:11 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: devel
On Wed, Mar 04, 2020 at 12:58:41 +0100, Ard Biesheuvel wrote:
> This driver depends on the gEfiCpuArchProtocolGuid protocol but does
> not declare it, and so this dependency gets satisfies transitively
> via ArmLib. However, ArmLib will drop this dependency as it does not
> actually use it, so declare it for LcdGraphicsOutputDxe instead.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> ---
> ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
> index 2176e5a5789f..27453b265611 100644
> --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
> +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
> @@ -38,6 +38,7 @@ [LibraryClasses]
> UefiLib
>
> [Protocols]
> + gEfiCpuArchProtocolGuid
> gEfiDevicePathProtocolGuid
> gEfiGraphicsOutputProtocolGuid
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ArmPlatformPkg/LcdGraphicsOutputDxe: add missing protocol dependency
2020-03-04 12:11 ` Leif Lindholm
@ 2020-03-04 17:46 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2020-03-04 17:46 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel-groups-io
On Wed, 4 Mar 2020 at 13:11, Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Wed, Mar 04, 2020 at 12:58:41 +0100, Ard Biesheuvel wrote:
> > This driver depends on the gEfiCpuArchProtocolGuid protocol but does
> > not declare it, and so this dependency gets satisfies transitively
> > via ArmLib. However, ArmLib will drop this dependency as it does not
> > actually use it, so declare it for LcdGraphicsOutputDxe instead.
> >
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>
Pushed as ed1c70cf1a954e857eb122892f3e510966dc4a9f
Thanks
> > ---
> > ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
> > index 2176e5a5789f..27453b265611 100644
> > --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
> > +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
> > @@ -38,6 +38,7 @@ [LibraryClasses]
> > UefiLib
> >
> > [Protocols]
> > + gEfiCpuArchProtocolGuid
> > gEfiDevicePathProtocolGuid
> > gEfiGraphicsOutputProtocolGuid
> >
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-04 17:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-04 11:58 [PATCH 1/1] ArmPlatformPkg/LcdGraphicsOutputDxe: add missing protocol dependency Ard Biesheuvel
2020-03-04 12:11 ` Leif Lindholm
2020-03-04 17:46 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox