public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: devel@edk2.groups.io
Subject: Re: [PATCH edk2-platforms 1/1] Platform/DeveloperBox: drop dma-ranges property from DT root node
Date: Fri, 6 Mar 2020 12:58:17 +0000	[thread overview]
Message-ID: <20200306125817.GF23627@bivouac.eciton.net> (raw)
In-Reply-To: <20200221162904.24152-1-ard.biesheuvel@linaro.org>

On Fri, Feb 21, 2020 at 17:29:04 +0100, Ard Biesheuvel wrote:
> The dma-ranges DT property describes the DMA translation between a
> parent bus and its children, and so having a dma-ranges property in
> the root node makes little sense, but it doesn't harm either.
> 
> However, recent kernels (v5.5+) have started spewing warnings into
> the kernel log of the following nature:
> 
>   OF: translation of DMA address(0) to CPU address failed node(/uart@2a400000)
>   OF: translation of DMA address(0) to CPU address failed node(/pmu)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@70000000)
>   OF: translation of DMA address(0) to CPU address failed node(/uart@51040000)
>   OF: translation of DMA address(0) to CPU address failed node(/gpio@51000000)
>   OF: translation of DMA address(0) to CPU address failed node(/i2c@51210000)
>   OF: translation of DMA address(0) to CPU address failed node(/gpio-keys)
>   OF: translation of DMA address(0) to CPU address failed node(/tpm_tis@10000000)
>   OF: translation of DMA address(0) to CPU address failed node(/sdhci@52300000)
>   OF: translation of DMA address(0) to CPU address failed node(/ethernet@522d0000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
> 
> and so we should probably get rid of this bogus dma-ranges property.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>

> ---
>  Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
> index afb9e2c779df..2ee3821fca0b 100644
> --- a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
> +++ b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
> @@ -21,7 +21,6 @@
>      #address-cells = <2>;
>      #size-cells = <2>;
>      interrupt-parent = <&gic>;
> -    dma-ranges = <0x0 0x0 0x0 0x0 0x100 0x0>;
>  
>      aliases {
>          serial0 = &soc_uart0;
> -- 
> 2.17.1
> 

  parent reply	other threads:[~2020-03-06 12:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-21 16:29 [PATCH edk2-platforms 1/1] Platform/DeveloperBox: drop dma-ranges property from DT root node Ard Biesheuvel
2020-03-06 10:39 ` Ard Biesheuvel
2020-03-06 12:58 ` Leif Lindholm [this message]
2020-03-06 16:42   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200306125817.GF23627@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox