public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms 1/1] Platform/DeveloperBox: drop dma-ranges property from DT root node
@ 2020-02-21 16:29 Ard Biesheuvel
  2020-03-06 10:39 ` Ard Biesheuvel
  2020-03-06 12:58 ` Leif Lindholm
  0 siblings, 2 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2020-02-21 16:29 UTC (permalink / raw)
  To: devel; +Cc: leif, Ard Biesheuvel

The dma-ranges DT property describes the DMA translation between a
parent bus and its children, and so having a dma-ranges property in
the root node makes little sense, but it doesn't harm either.

However, recent kernels (v5.5+) have started spewing warnings into
the kernel log of the following nature:

  OF: translation of DMA address(0) to CPU address failed node(/uart@2a400000)
  OF: translation of DMA address(0) to CPU address failed node(/pmu)
  OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
  OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
  OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
  OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
  OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
  OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
  OF: translation of DMA address(0) to CPU address failed node(/pcie@70000000)
  OF: translation of DMA address(0) to CPU address failed node(/uart@51040000)
  OF: translation of DMA address(0) to CPU address failed node(/gpio@51000000)
  OF: translation of DMA address(0) to CPU address failed node(/i2c@51210000)
  OF: translation of DMA address(0) to CPU address failed node(/gpio-keys)
  OF: translation of DMA address(0) to CPU address failed node(/tpm_tis@10000000)
  OF: translation of DMA address(0) to CPU address failed node(/sdhci@52300000)
  OF: translation of DMA address(0) to CPU address failed node(/ethernet@522d0000)
  OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
  OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)

and so we should probably get rid of this bogus dma-ranges property.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
index afb9e2c779df..2ee3821fca0b 100644
--- a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
+++ b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
@@ -21,7 +21,6 @@
     #address-cells = <2>;
     #size-cells = <2>;
     interrupt-parent = <&gic>;
-    dma-ranges = <0x0 0x0 0x0 0x0 0x100 0x0>;
 
     aliases {
         serial0 = &soc_uart0;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH edk2-platforms 1/1] Platform/DeveloperBox: drop dma-ranges property from DT root node
  2020-02-21 16:29 [PATCH edk2-platforms 1/1] Platform/DeveloperBox: drop dma-ranges property from DT root node Ard Biesheuvel
@ 2020-03-06 10:39 ` Ard Biesheuvel
  2020-03-06 12:58 ` Leif Lindholm
  1 sibling, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2020-03-06 10:39 UTC (permalink / raw)
  To: edk2-devel-groups-io; +Cc: Leif Lindholm

On Fri, 21 Feb 2020 at 17:29, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> The dma-ranges DT property describes the DMA translation between a
> parent bus and its children, and so having a dma-ranges property in
> the root node makes little sense, but it doesn't harm either.
>
> However, recent kernels (v5.5+) have started spewing warnings into
> the kernel log of the following nature:
>
>   OF: translation of DMA address(0) to CPU address failed node(/uart@2a400000)
>   OF: translation of DMA address(0) to CPU address failed node(/pmu)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@70000000)
>   OF: translation of DMA address(0) to CPU address failed node(/uart@51040000)
>   OF: translation of DMA address(0) to CPU address failed node(/gpio@51000000)
>   OF: translation of DMA address(0) to CPU address failed node(/i2c@51210000)
>   OF: translation of DMA address(0) to CPU address failed node(/gpio-keys)
>   OF: translation of DMA address(0) to CPU address failed node(/tpm_tis@10000000)
>   OF: translation of DMA address(0) to CPU address failed node(/sdhci@52300000)
>   OF: translation of DMA address(0) to CPU address failed node(/ethernet@522d0000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>
> and so we should probably get rid of this bogus dma-ranges property.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
> index afb9e2c779df..2ee3821fca0b 100644
> --- a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
> +++ b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
> @@ -21,7 +21,6 @@
>      #address-cells = <2>;
>      #size-cells = <2>;
>      interrupt-parent = <&gic>;
> -    dma-ranges = <0x0 0x0 0x0 0x0 0x100 0x0>;
>
>      aliases {
>          serial0 = &soc_uart0;
> --
> 2.17.1
>

Ping?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH edk2-platforms 1/1] Platform/DeveloperBox: drop dma-ranges property from DT root node
  2020-02-21 16:29 [PATCH edk2-platforms 1/1] Platform/DeveloperBox: drop dma-ranges property from DT root node Ard Biesheuvel
  2020-03-06 10:39 ` Ard Biesheuvel
@ 2020-03-06 12:58 ` Leif Lindholm
  2020-03-06 16:42   ` Ard Biesheuvel
  1 sibling, 1 reply; 4+ messages in thread
From: Leif Lindholm @ 2020-03-06 12:58 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: devel

On Fri, Feb 21, 2020 at 17:29:04 +0100, Ard Biesheuvel wrote:
> The dma-ranges DT property describes the DMA translation between a
> parent bus and its children, and so having a dma-ranges property in
> the root node makes little sense, but it doesn't harm either.
> 
> However, recent kernels (v5.5+) have started spewing warnings into
> the kernel log of the following nature:
> 
>   OF: translation of DMA address(0) to CPU address failed node(/uart@2a400000)
>   OF: translation of DMA address(0) to CPU address failed node(/pmu)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@70000000)
>   OF: translation of DMA address(0) to CPU address failed node(/uart@51040000)
>   OF: translation of DMA address(0) to CPU address failed node(/gpio@51000000)
>   OF: translation of DMA address(0) to CPU address failed node(/i2c@51210000)
>   OF: translation of DMA address(0) to CPU address failed node(/gpio-keys)
>   OF: translation of DMA address(0) to CPU address failed node(/tpm_tis@10000000)
>   OF: translation of DMA address(0) to CPU address failed node(/sdhci@52300000)
>   OF: translation of DMA address(0) to CPU address failed node(/ethernet@522d0000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
>   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
> 
> and so we should probably get rid of this bogus dma-ranges property.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>

> ---
>  Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
> index afb9e2c779df..2ee3821fca0b 100644
> --- a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
> +++ b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
> @@ -21,7 +21,6 @@
>      #address-cells = <2>;
>      #size-cells = <2>;
>      interrupt-parent = <&gic>;
> -    dma-ranges = <0x0 0x0 0x0 0x0 0x100 0x0>;
>  
>      aliases {
>          serial0 = &soc_uart0;
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH edk2-platforms 1/1] Platform/DeveloperBox: drop dma-ranges property from DT root node
  2020-03-06 12:58 ` Leif Lindholm
@ 2020-03-06 16:42   ` Ard Biesheuvel
  0 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2020-03-06 16:42 UTC (permalink / raw)
  To: Leif Lindholm; +Cc: edk2-devel-groups-io

On Fri, 6 Mar 2020 at 13:58, Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Fri, Feb 21, 2020 at 17:29:04 +0100, Ard Biesheuvel wrote:
> > The dma-ranges DT property describes the DMA translation between a
> > parent bus and its children, and so having a dma-ranges property in
> > the root node makes little sense, but it doesn't harm either.
> >
> > However, recent kernels (v5.5+) have started spewing warnings into
> > the kernel log of the following nature:
> >
> >   OF: translation of DMA address(0) to CPU address failed node(/uart@2a400000)
> >   OF: translation of DMA address(0) to CPU address failed node(/pmu)
> >   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
> >   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
> >   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
> >   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
> >   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
> >   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
> >   OF: translation of DMA address(0) to CPU address failed node(/pcie@70000000)
> >   OF: translation of DMA address(0) to CPU address failed node(/uart@51040000)
> >   OF: translation of DMA address(0) to CPU address failed node(/gpio@51000000)
> >   OF: translation of DMA address(0) to CPU address failed node(/i2c@51210000)
> >   OF: translation of DMA address(0) to CPU address failed node(/gpio-keys)
> >   OF: translation of DMA address(0) to CPU address failed node(/tpm_tis@10000000)
> >   OF: translation of DMA address(0) to CPU address failed node(/sdhci@52300000)
> >   OF: translation of DMA address(0) to CPU address failed node(/ethernet@522d0000)
> >   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
> >   OF: translation of DMA address(0) to CPU address failed node(/pcie@60000000)
> >
> > and so we should probably get rid of this bogus dma-ranges property.
> >
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>

Pushed as 28d2f4ecd87d..f9d42079600c

Thanks

> > ---
> >  Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
> > index afb9e2c779df..2ee3821fca0b 100644
> > --- a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
> > +++ b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi
> > @@ -21,7 +21,6 @@
> >      #address-cells = <2>;
> >      #size-cells = <2>;
> >      interrupt-parent = <&gic>;
> > -    dma-ranges = <0x0 0x0 0x0 0x0 0x100 0x0>;
> >
> >      aliases {
> >          serial0 = &soc_uart0;
> > --
> > 2.17.1
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-06 16:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-21 16:29 [PATCH edk2-platforms 1/1] Platform/DeveloperBox: drop dma-ranges property from DT root node Ard Biesheuvel
2020-03-06 10:39 ` Ard Biesheuvel
2020-03-06 12:58 ` Leif Lindholm
2020-03-06 16:42   ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox