From: "Pete Batard" <pete@akeo.ie>
To: devel@edk2.groups.io
Cc: ard.biesheuvel@linaro.org, leif@nuviainc.com, philmd@redhat.com,
awarkentin@vmware.com
Subject: [edk2-devel][PATCH 1/2] Platform/RPi/AcpiTables: Fix ASL compilation warnings
Date: Mon, 9 Mar 2020 14:21:18 +0000 [thread overview]
Message-ID: <20200309142119.7260-2-pete@akeo.ie> (raw)
In-Reply-To: <20200309142119.7260-1-pete@akeo.ie>
Silence 2 warnings from pep.asl:
* "Warning 3133 - Unknown reserved name (_GPI/_GCI/_GDI)"
* "Warning 3150 - Empty Resource Template", which is caused by
section "Name (_CRS, ResourceTemplate () {})"
Remove "Offset(0)" in Xhci.asl, which produces the warning:
"Unnecessary/redundant use of Offset operator".
Signed-off-by: Pete Batard <pete@akeo.ie>
---
Platform/RaspberryPi/AcpiTables/AcpiTables.inf | 3 +++
Platform/RaspberryPi/AcpiTables/Xhci.asl | 1 -
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/AcpiTables/AcpiTables.inf b/Platform/RaspberryPi/AcpiTables/AcpiTables.inf
index c95d75ed01bb..9ad5246d6bb6 100644
--- a/Platform/RaspberryPi/AcpiTables/AcpiTables.inf
+++ b/Platform/RaspberryPi/AcpiTables/AcpiTables.inf
@@ -56,3 +56,6 @@ [FixedPcd]
gBcmNetTokenSpaceGuid.PcdBcmGenetRegistersAddress
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate
gEmbeddedTokenSpaceGuid.PcdInterruptBaseAddress
+
+[BuildOptions]
+ GCC:*_*_*_ASL_FLAGS = -vw3133 -vw3150
diff --git a/Platform/RaspberryPi/AcpiTables/Xhci.asl b/Platform/RaspberryPi/AcpiTables/Xhci.asl
index 0083d1992936..bc3fea60f925 100644
--- a/Platform/RaspberryPi/AcpiTables/Xhci.asl
+++ b/Platform/RaspberryPi/AcpiTables/Xhci.asl
@@ -118,7 +118,6 @@ Device (SCB0) {
Method (_INI, 0, Serialized) {
OperationRegion (PCFG, SystemMemory, SANITIZED_PCIE_REG_BASE + PCIE_EXT_CFG_DATA, 0x1000)
Field (PCFG, AnyAcc, NoLock, Preserve) {
- Offset (0),
VNID, 16, // Vendor ID
DVID, 16, // Device ID
CMND, 16, // Command register
--
2.21.0.windows.1
next prev parent reply other threads:[~2020-03-09 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 14:21 [edk2-devel][PATCH 0/2] Platform/RPi: Fix compilation warnings Pete Batard
2020-03-09 14:21 ` Pete Batard [this message]
2020-03-09 14:21 ` [edk2-devel][PATCH 2/2] Platform/RPi/ConfigDxe: Fix a compilation warning Pete Batard
2020-03-25 9:37 ` [edk2-devel][PATCH 0/2] Platform/RPi: Fix compilation warnings Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309142119.7260-2-pete@akeo.ie \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox