From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web10.10637.1583941493531858126 for ; Wed, 11 Mar 2020 08:44:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=J9+ulASG; spf=pass (domain: nuviainc.com, ip: 209.85.128.65, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f65.google.com with SMTP id g62so2691408wme.1 for ; Wed, 11 Mar 2020 08:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UFwYD9XXp2506q4Px/ARk/8phyFS9idBu3RyJkbeNV4=; b=J9+ulASGrHfqcS2YUgxVYSMQDnYXatMMAHJgaban+CZfXB2tvnk0vjoY+533ydUjvY RqlSRVS0amm5jQIxMjD8pqslo/CWSaILR2shX97i8hHxEMPD9MzI38cbg8dvxmQa3CDh nwZxR/m6boMtdcDYecbZpoPfjgv0QI7MLPDidHlKsVPVioAIEKluLvoK6oZVYXAbcITq wGTBKTfzXSK1MvabMtNH07pMX4aEygsD1fl9CmoxYtK2vAsbzLRPiz19Ef5vC6j90h6u F6U/wREq07LQY4urOIWBQBymrDlZRM2CrzMwkN1evoCLkXPn37BzuWtrku/xlGXpqRjJ woVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UFwYD9XXp2506q4Px/ARk/8phyFS9idBu3RyJkbeNV4=; b=GAP1SsSIuHnr993P1dxBE2FdU6Q6vUcEM6ZWIKOT8mBSZ4OFhvs2dJTAYmASD78ZBT e44ndStIJnvJc76ejxKOT9EqJCaR9rscpVPBsuAheL6RDosb8FEM+xJKJ77Q4CI4LpOo +97lipFu0ByBiM+/5cTUtFyWUk/SPx+glV8bTp/6MtLpl1hQIeXt9yG3d0c31DnvRcep tIswTkZwlMNti/NFfTjRScd36ZQpKte/WLAaV9IYeZ2xMFAOwt2pllSbwqm4ty32wbUt iw+3gYtmQJyGdIciNrLUoLah66pBRBp5tmuzUyobzU3A42dihW3+eJLOPsKLfNFYoCCT LnOw== X-Gm-Message-State: ANhLgQ1r62wh/FTIpDoyY4msut9z8HweYVvWR7dG2C4IdOT2qTlEPv3E qYORf0TId9ZOgkluJXguBa5JQDimJ/HGE29TXvtVnnNE4WOfk7Y4vNTXgNojQCdI8GtBJJnKWF4 t5xK4N9MROJ6uZo6eT5l9alHLxOMATgvIBgYqggiDMRXq9046bID45lI9qiiH8Yw= X-Google-Smtp-Source: ADFU+vvDUvfQlCnRBV24rBdhi+SHUMBYy5qV+TYsfsPEgDyqFs+zSxmb12L5tG1eN82zyY1iOKT64g== X-Received: by 2002:a05:600c:14d5:: with SMTP id i21mr4373016wmh.82.1583941491732; Wed, 11 Mar 2020 08:44:51 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z6sm15313123wru.15.2020.03.11.08.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 08:44:51 -0700 (PDT) Date: Wed, 11 Mar 2020 15:44:49 +0000 From: "Leif Lindholm" To: devel@edk2.groups.io, lersek@redhat.com Cc: Ard Biesheuvel , Jordan Justen , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [edk2-devel] [PATCH 3/5] OvmfPkg: set fixed FlashNvStorage base addresses with -D SMM_REQUIRE Message-ID: <20200311154449.GR23627@bivouac.eciton.net> References: <20200310222739.26717-1-lersek@redhat.com> <20200310222739.26717-4-lersek@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200310222739.26717-4-lersek@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline One comment, not on this patch but prompted by it: On Tue, Mar 10, 2020 at 23:27:37 +0100, Laszlo Ersek wrote: > diff --git a/OvmfPkg/OvmfPkg.fdf.inc b/OvmfPkg/OvmfPkg.fdf.inc > index 66e0e4d270f5..35fd454b97ab 100644 > --- a/OvmfPkg/OvmfPkg.fdf.inc > +++ b/OvmfPkg/OvmfPkg.fdf.inc > @@ -82,4 +82,10 @@ I was surprised at not seeing the section header here, so had a look at the file, noticed it doesn't have any. And that all files that include it do it by: [Defines] !include OvmfPkg.fdf.inc That looks a bit error-prone and inflexible - could we move/copy the header into this file? / Leif > SET gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageFtwSpareBase = gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageFtwWorkingBase + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize > SET gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize = $(VARS_SPARE_SIZE) > > +!if $(SMM_REQUIRE) == TRUE > +SET gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64 = gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageVariableBase > +SET gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase = gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageFtwWorkingBase > +SET gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase = gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageFtwSpareBase > +!endif > + > DEFINE MEMFD_BASE_ADDRESS = 0x800000 > -- > 2.19.1.3.g30247aa5d201 > > > > >