From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web11.8453.1584047997455991244 for ; Thu, 12 Mar 2020 14:19:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=uS0ws8rx; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id 11so7728170wmo.2 for ; Thu, 12 Mar 2020 14:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eY7TbPmXXT8+xfgHY4bTKnlnYMKhuTXAit1WbGYXqn0=; b=uS0ws8rx/sx6+ggxeuAQ9UdKlcpvuxrAc4LuXB+QAKphH4XbNFYS5De+spHdgh3gVO 0YTUDviEyfnNp2wLj01EAXW5M+2KNrZBSSA1+ZyGD9R33CVaNop8SmkQbgT/eXyapWiN x6e/HqCi/jvgmB+euQYc9dZBxyPWqkhYsQJwgL5FNTDks30ldIwUwAjZ5iqABf97wbad VfJYtl1RBSf+Ib6rYH86I7tTXGhAaGUipwPAo1yI9Mt8jzhMhUzUryKWK4JG/Bi8lLrx dbQyRblI1MzJk6pQ03ZMgcOEsD5sZFP5+qLdXrK0VKUkHcpjUttq+Xv3UaVitamh/PZr XEng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eY7TbPmXXT8+xfgHY4bTKnlnYMKhuTXAit1WbGYXqn0=; b=mYncS/CqE/scWn9DY6WNWy73NxoCZm6TmpX4oD8fWuzbwoR4OSFDnrQiorQAO6GGgV ksdfIEysm8LWWrvv9qOV7/XTakB7IBVSUGDdJFFqmtyqXgv5yWPN0WrMTLWGBSBx3qKA toR+c4P9o7si3a6s53cckDnBLKqy6boPSRJzquqme40xLCb/d847NQqflybyYRHZlZph 0P0UONhTFtBhDBz41gu9apG+VG0dw3PqoiVm7xfzqRMCwQW0wQyXa6YZ+IzJ8aDe1hi3 Lsx/yad1IOiPu+3zXZRRqTSf7kYwgY8SWsolxN1HYSIpfBMg7bO78jROG2BpHklZ+UBv bNTA== X-Gm-Message-State: ANhLgQ2dXPHd8Lf2hk2BSfXfe0WMfZnIMbUyvl3K+dh0RntWr7e5qkH7 YcxVlon1iBBJMENmOpABBI11XwkKt+KY3U6a92EXIhu+oaAgB2fr08zdIw0WGZI2ygaJvwgvDa6 t6FT5HAe2f96YSpwk0WWmIHp2gpS3JUrZScNdGQwXzZUKWL4KBBY6q80WleAYuB8= X-Google-Smtp-Source: ADFU+vuN17vR7WUdzXlw0wFEIM36EP/HDrIFu48pyMPZwz1cbvj9gqbc9wcUvJENFtg1rLuYCHbTwg== X-Received: by 2002:a1c:6583:: with SMTP id z125mr6914995wmb.51.1584047995533; Thu, 12 Mar 2020 14:19:55 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y7sm11237867wmd.1.2020.03.12.14.19.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2020 14:19:55 -0700 (PDT) Date: Thu, 12 Mar 2020 21:19:53 +0000 From: "Leif Lindholm" To: devel@edk2.groups.io, lersek@redhat.com Cc: "Chang, Abner (HPS SW/FW Technologist)" , "Schaefer, Daniel (DualStudy)" , "Chen, Gilbert" , "afish@apple.com" , "michael.d.kinney@intel.com" , "pete@akeo.ie" , Ard Biesheuvel Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment Message-ID: <20200312211953.GL23627@bivouac.eciton.net> References: <20200302103238.25726-1-daniel.schaefer@hpe.com> <20200302103238.25726-4-daniel.schaefer@hpe.com> <20200312105528.GC23627@bivouac.eciton.net> <539c8673-786c-9c58-98cc-ab470b345740@hpe.com> <20200312140304.GF23627@bivouac.eciton.net> <20200312144452.GI23627@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 12, 2020 at 20:42:52 +0100, Laszlo Ersek wrote: > On 03/12/20 15:44, Leif Lindholm wrote: > > And what would you propose we do the next time the RISC-V toolchain > > generates a memcpy call based on some other completely valid change to > > core code? > > We could choose to enable the intrinsics library for RISC-V at that point. We could. And have no time left for resolving any issues that may be triggered by that without slipping the next stable tag. I would prefer de-risking it. > IIUC, the CreateDeviceManagerForm() code in question did break an edk2 > rule ("don't use structure assignment") *prior* to commit 64a228f5f893. > The rule violation was in commit 32465d9ae7ee; RISC-V only exposed it. > This doesn't seem uncharted territory. I don't understand, I've already said I'm not pushing to revert that patch, I have suggested that we don't put RISC-V on less stable ground than ARM/AARCH64. But continuing on the unrelated topic: If the rule is "no structure assignments", then fine, that's part of the C dialect you need to learn in order to contribute to TianoCore. I can separately start arguing for changing that rule. However, I can't easily find that in the coding style - could you give me a pointer? / Leif