From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: devel@edk2.groups.io
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>,
Puja Pandya <puja.pandya@intel.com>,
Erik Bjorge <erik.c.bjorge@intel.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Uninstaller does not uninstall packages with '_' in their name.
Date: Mon, 16 Mar 2020 10:32:47 -0700 [thread overview]
Message-ID: <20200316173248.1678-2-nathaniel.l.desimone@intel.com> (raw)
In-Reply-To: <20200316173248.1678-1-nathaniel.l.desimone@intel.com>
pip does not support '_' in package names and converts them to
'-' after installing the wheel. In order to uninstall affected
packages the '_' needs to be converted to a '-' when calculating
the package name.
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
edkrepo_installer/EdkRepoInstaller/InstallWorker.cs | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs b/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs
index 5a358f9..f9738fd 100644
--- a/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs
+++ b/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs
@@ -550,10 +550,16 @@ namespace TianoCore.EdkRepoInstaller
{
if (VendorCustomizer.Instance.GetPythonWheelsToUninstall != null)
{
- return VendorCustomizer.Instance.GetPythonWheelsToUninstall();
+ //
+ // pip doesn't understand the difference between '_' and '-'
+ //
+ return VendorCustomizer.Instance.GetPythonWheelsToUninstall().Select(p => p.Replace('_', '-'));
}
}
- return new string[] { InstallerStrings.EdkrepoPackageName };
+ //
+ // pip doesn't understand the difference between '_' and '-'
+ //
+ return (new string[] { InstallerStrings.EdkrepoPackageName }).Select(p => p.Replace('_', '-'));
}
public void PerformInstall(Action<bool, bool> ReportComplete, Action<int> ReportProgress, Action<bool> AllowCancel, Func<bool> CancelPending)
--
2.24.0.windows.2
next prev parent reply other threads:[~2020-03-16 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 17:32 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Installer would lists every Python version as obsolete Nate DeSimone
2020-03-16 17:32 ` Nate DeSimone [this message]
2020-03-17 21:43 ` [edk2-staging/EdkRepo] [PATCH] EdkRepo: Uninstaller does not uninstall packages with '_' in their name Desimone, Ashley E
2020-03-16 17:32 ` [edk2-staging/EdkRepo] [PATCH] EdkRepo: Use /S switch to pass command args in installer Nate DeSimone
2020-03-17 21:44 ` Desimone, Ashley E
2020-03-17 21:42 ` [edk2-staging/EdkRepo] [PATCH] EdkRepo: Installer would lists every Python version as obsolete Desimone, Ashley E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316173248.1678-2-nathaniel.l.desimone@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox