From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com []) by mx.groups.io with SMTP id smtpd.web11.74233.1584379978542701702 for ; Mon, 16 Mar 2020 10:33:06 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: L/r9QyZa4u0rI5pscM53PdnegdirX9jxNP3FyfcA9ACO27AkXWKAmgLWwMGx8R0lGmIQO+CpEN GNcVUrEHJ83Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 10:33:06 -0700 IronPort-SDR: 84h3x2QfO8J1gfA6ru00wdIiOL9ODeiBpOs1z5POdlRWtqVokdv+b6e/50pL33qCXuxcRQt0MY +UKvgGlSnPeA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,561,1574150400"; d="scan'208";a="417229418" Received: from nldesimo-desk1.amr.corp.intel.com ([10.7.159.63]) by orsmga005.jf.intel.com with ESMTP; 16 Mar 2020 10:33:06 -0700 From: "Nate DeSimone" To: devel@edk2.groups.io Cc: Ashley DeSimone , Puja Pandya , Erik Bjorge , Bret Barkelew Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Use /S switch to pass command args in installer Date: Mon, 16 Mar 2020 10:32:48 -0700 Message-Id: <20200316173248.1678-3-nathaniel.l.desimone@intel.com> X-Mailer: git-send-email 2.24.0.windows.2 In-Reply-To: <20200316173248.1678-1-nathaniel.l.desimone@intel.com> References: <20200316173248.1678-1-nathaniel.l.desimone@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Ashley DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Signed-off-by: Nate DeSimone --- edkrepo_installer/EdkRepoInstaller/App.xaml.cs | 4 ++-- edkrepo_installer/EdkRepoInstaller/InstallWorker.cs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/edkrepo_installer/EdkRepoInstaller/App.xaml.cs b/edkrepo_installer/EdkRepoInstaller/App.xaml.cs index 58186c9..5d23624 100644 --- a/edkrepo_installer/EdkRepoInstaller/App.xaml.cs +++ b/edkrepo_installer/EdkRepoInstaller/App.xaml.cs @@ -185,7 +185,7 @@ namespace TianoCore.EdkRepoInstaller { InstallLogger.Log(string.Format("{0} is a third party version of {1}. {0} is already installed.", DisplayName, ProductName)); InstallLogger.Log(string.Format("To install this version of {1}, {0} must be uninstalled first.", DisplayName, ProductName)); - SilentProcess p = SilentProcess.StartConsoleProcessSilently("cmd.exe", string.Format("/c \"{0}\"", UninstallString)); + SilentProcess p = SilentProcess.StartConsoleProcessSilently("cmd.exe", string.Format("/S /C \"{0}\"", UninstallString)); p.WaitForExit(); Thread.Sleep(4000); } @@ -200,7 +200,7 @@ namespace TianoCore.EdkRepoInstaller ); if (Uninstall == MessageBoxResult.Yes) { - SilentProcess p = SilentProcess.StartConsoleProcessSilently("cmd.exe", string.Format("/c \"{0}\"", UninstallString)); + SilentProcess p = SilentProcess.StartConsoleProcessSilently("cmd.exe", string.Format("/S /C \"{0}\"", UninstallString)); p.WaitForExit(); Thread.Sleep(1000); } diff --git a/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs b/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs index 5a358f9..c37189b 100644 --- a/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs +++ b/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs @@ -672,7 +672,7 @@ namespace TianoCore.EdkRepoInstaller { InstallLogger.Log(string.Format("Uninstalling {0}...", UninstallerPath)); string UninstallString = string.Format("\"{0}\" /Uninstall /Passive", UninstallerPath); - SilentProcess p = SilentProcess.StartConsoleProcessSilently("cmd.exe", string.Format("/c \"{0}\"", UninstallString)); + SilentProcess p = SilentProcess.StartConsoleProcessSilently("cmd.exe", string.Format("/S /C \"{0}\"", UninstallString)); p.WaitForExit(); Thread.Sleep(4000); } -- 2.24.0.windows.2