From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.9877.1584514141809764468 for ; Tue, 17 Mar 2020 23:49:02 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: guomin.jiang@intel.com) IronPort-SDR: clwECLm0f9yrZC51xMAWFEfISgQA/9R56Vsy/S2IfuB3AeVAGg0SizBDxv9QtWj7wyV2KWEgiS vyR0XbAVzRVw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2020 23:49:01 -0700 IronPort-SDR: bZaKt3SUGdIYMsEKaOiIe1yUKLwihMYVp5LOsOfj8ANPVdBh953OFztmPpC0m/SPZ1VezkmzXf nDO/B1eu3tTg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,566,1574150400"; d="scan'208";a="444063600" Received: from guominji-mobl.ccr.corp.intel.com ([10.238.5.173]) by fmsmga005.fm.intel.com with ESMTP; 17 Mar 2020 23:48:59 -0700 From: guomin.jiang@intel.com To: devel@edk2.groups.io Cc: Guomin Jiang , Ray Ni , Rangasai V Chaganty Subject: [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Date: Wed, 18 Mar 2020 14:47:42 +0800 Message-Id: <20200318064742.910-1-guomin.jiang@intel.com> X-Mailer: git-send-email 2.25.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2589 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDev= iceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/= Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index 29b6916f61..aa2bf14fa8 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c @@ -69,7 +69,7 @@ RecordPciDeviceInList( ASSERT_EFI_ERROR(Status);=0D =0D NewPciDevice =3D AllocateZeroPool(sizeof(*NewPciDevice));=0D - ASSERT_EFI_ERROR(NewPciDevice !=3D NULL);=0D + ASSERT(NewPciDevice !=3D NULL);=0D =0D NewPciDevice->Signature =3D PCI_DEVICE_INSTANCE_SIGNATURE;=0D NewPciDevice->PciSegment =3D PciSegment;=0D --=20 2.25.1.windows.1