From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.56]) by mx.groups.io with SMTP id smtpd.web12.2625.1584440701715834530 for ; Tue, 17 Mar 2020 03:25:03 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nxp.com header.s=selector2 header.b=nWVH0JNO; spf=pass (domain: nxp.com, ip: 40.107.21.56, mailfrom: gaurav.jain@nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IYUHLTK0s+azdms5N/laWldyt7ZoTJ4KdasWAHPsPCkEItZyDy0Jz63ivAy6YEFK1DJzsWoZ7w/ZxF4Ea47l8uOHcy46fGBxjCUY+jDDhIOLjHuooCnK41eTZ6tJn7KSQtGa3q3OpfeXXcbgXnN7M50/IVNuqWlijJCABcB5OLc2EAZBiYuyl/XnNmrRt2Iq9+XZeVrOq1bixVrtD1z/B8aamEvM17STSf/RklbISy1qrKNssgrM8C72UiWnk5qje0bcLkxUuj0TQHO+c+RM+wFxwo4ohOrPZnfjR+/GnS1Svwp/D+qk3hPbtY2apDHR7JiVnpzHk5e6gCniaG+kdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lqMn6cf3RPCz1CR8rPLrIzoZ0ubL9mpDq9kEBIwg9qQ=; b=PVEnMzukZuDzRRsH9n2/WIpJzgVdhs4hKyd1KHOyABEh2T0TIFy71PnSTlTYAh2pyjikjOB4xQC0hYZCt9lTsaj5Ffeprg0fhSihaPDgns5sGZ1zPTC9z2z60dmE1yg6SXDlkj3Nkb0EO9aIrl2h2NoW9QNu5VoYuV9BBICHp/jJkAwcL3xa5+X4ffqjOjESBB7VMUjtBTE9qFfJaXvqg2L4Uqz/pZlNLOY3k2L4laresqifwUeXhSB8oJpwmi0PWkt3H2DaUwstKdWKGHG9bgWheUaVeOonffLuTpH5iCoCJsNhixJBzu0dI8bB1FOBVIe2DrqGkD7e/ZJQXBhFPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lqMn6cf3RPCz1CR8rPLrIzoZ0ubL9mpDq9kEBIwg9qQ=; b=nWVH0JNOZX8cZGXvb9hbp5HdlG+AkVqbV1oZNijAKQHOzdRutzYstDMIKMQtCbKMTQjOuRnzNxejrbhx8EchA9eYmzyd84Fdqw5FTBOKwcYqhsrVQgwysp9SVgv83y+/qfmq5EHl5OCbD8BjGlDYEy8aYCrisztZp6sjCLLoNYI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=gaurav.jain@nxp.com; Received: from DB7PR04MB4091.eurprd04.prod.outlook.com (52.134.110.144) by DB7PR04MB5563.eurprd04.prod.outlook.com (20.178.106.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.19; Tue, 17 Mar 2020 10:24:59 +0000 Received: from DB7PR04MB4091.eurprd04.prod.outlook.com ([fe80::183:969:2508:3c92]) by DB7PR04MB4091.eurprd04.prod.outlook.com ([fe80::183:969:2508:3c92%6]) with mapi id 15.20.2814.021; Tue, 17 Mar 2020 10:24:59 +0000 From: "Gaurav Jain" To: devel@edk2.groups.io CC: Leif Lindholm , Ard Biesheuvel , Pankaj Bansal , Gaurav Jain Subject: [PATCH v3 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test. Date: Wed, 18 Mar 2020 15:54:19 +0530 Message-ID: <20200318102419.20007-1-gaurav.jain@nxp.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: SG2PR01CA0100.apcprd01.prod.exchangelabs.com (2603:1096:3:15::26) To DB7PR04MB4091.eurprd04.prod.outlook.com (2603:10a6:5:1e::16) Return-Path: gaurav.jain@nxp.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from uefi-workstation.ap.freescale.net (92.120.1.69) by SG2PR01CA0100.apcprd01.prod.exchangelabs.com (2603:1096:3:15::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.18 via Frontend Transport; Tue, 17 Mar 2020 10:24:56 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [92.120.1.69] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: a1acabef-d446-4d4a-8786-08d7ca5d71e7 X-MS-TrafficTypeDiagnostic: DB7PR04MB5563:|DB7PR04MB5563: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2512; X-Forefront-PRVS: 0345CFD558 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(346002)(376002)(396003)(136003)(39860400002)(366004)(199004)(6512007)(478600001)(186003)(16526019)(6666004)(4326008)(6916009)(6506007)(81156014)(81166006)(8676002)(52116002)(8936002)(54906003)(36756003)(316002)(6486002)(1076003)(26005)(66476007)(66556008)(5660300002)(956004)(66946007)(2906002)(86362001)(2616005)(44832011);DIR:OUT;SFP:1101;SCL:1;SRVR:DB7PR04MB5563;H:DB7PR04MB4091.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VEyGk4O3kR0+qNWSWvfB/bdUBkhffCZsTdQQzmzwsSRdwxkrN4LcIi4qPZwM2u1mBDrCku3hHtwRqbrH0TwfX4I+BOqWxI9fvfchHr1HTEjX8JYyTQF5gICrPzpLrnEpwOe0Ixu0k6T9PBbfo0gJNEjUHz3UPdiGEWx0NG4WcrsdeRT3VDkGYfbPU2PFRkJ/f9ksut9Of4+aKDvpab3t03yHRP/d5FApX5W4Cxbbei2Bv92Ci0MazaRyNbVp5KfY0YfJvH5OVoO4n0mkettd6aocvcPJeQQpnhuDeQucUWcIGgeO/Z8UeGlJPNKuOOyu4GAkoQqnJHhN1ucQooZe7cqrXnNomBepDPF4m2GD+jL4y3P5+xXl+IjUgFdETg7yRl5YPbCo7dycRneZpcn82xSolHwMlEycFv1PT8VOxcpGfftwQ49xLeBiJBrqoCnA X-MS-Exchange-AntiSpam-MessageData: jM1Yf4joEtoE/8NIwNiEbmprVlXqQ66C8TBgf4lARt4s1STgdlggrunfE5ISc9uSdZpb3pyB99LGFEaDC5eqYssw6nbZx4KVwLkuueFKxZXQI7LXe27Y9QNq7pkBUsux1PcKJQ/MD9dNAwLqlpOzuw== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1acabef-d446-4d4a-8786-08d7ca5d71e7 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2020 10:24:59.1380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 75FSTJyDW9sAfpIY05Fa/Mx1NEnWGaz1OcWkpX4BuKMrA3pBNkoGq2p5fW8jpEng/8K9hQW94XgK0+gjWoYbpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5563 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain ASSERT in SetTime_Conf Consistency Test. SCT Test expect return as Invalid Parameter. So removed ASSERT(). Signed-off-by: Gaurav Jain --- Notes: v3 Removed Time Validity Checks in function SetWakeupTime. =20 v2 reverted changes related to valid range of years. EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c b/Embedded= Pkg/RealTimeClockRuntimeDxe/RealTimeClock.c index 08fb9b0100b6..20f1fa640ecc 100644 --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c @@ -85,10 +85,6 @@ IsDayValid ( IN EFI_TIME *Time ) { - ASSERT (Time->Day >=3D 1); - ASSERT (Time->Day <=3D mDayOfMonth[Time->Month - 1]); - ASSERT (Time->Month !=3D 2 || IsLeapYear (Time) || Time->Day <=3D 28); - if (Time->Day < 1 || Time->Day > mDayOfMonth[Time->Month - 1] || (Time->Month =3D=3D 2 && !IsLeapYear (Time) && Time->Day > 28)) { @@ -113,6 +109,7 @@ IsTimeValid( Time->Hour > 23 || Time->Minute > 59 || Time->Second > 59 || + Time->Nanosecond > 999999999 || !IsValidTimeZone (Time->TimeZone) || !IsValidDaylight (Time->Daylight)) { return FALSE; --=20 2.17.1