* [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures
@ 2020-03-18 19:29 Nate DeSimone
2020-03-18 19:43 ` Desimone, Ashley E
0 siblings, 1 reply; 3+ messages in thread
From: Nate DeSimone @ 2020-03-18 19:29 UTC (permalink / raw)
To: devel; +Cc: Ashley DeSimone, Puja Pandya, Erik Bjorge, Bret Barkelew
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
edkrepo/common/common_repo_functions.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/edkrepo/common/common_repo_functions.py b/edkrepo/common/common_repo_functions.py
index 4b580c0..288dd27 100644
--- a/edkrepo/common/common_repo_functions.py
+++ b/edkrepo/common/common_repo_functions.py
@@ -14,6 +14,7 @@ import sys
import unicodedata
import urllib.request
import subprocess
+import traceback
import git
from git import Repo
@@ -600,7 +601,9 @@ def checkout(combination_or_sha, verbose=False, override=False, log=None):
if combination_is_in_manifest(combo_or_sha, manifest):
manifest.write_current_combo(combo_or_sha)
except:
- print (CHECKOUT_COMBO_UNSUCCESFULL.format(combo_or_sha))
+ if verbose:
+ traceback.print_exc()
+ print (CHECKOUT_COMBO_UNSUCCESSFULL.format(combo_or_sha))
# Return to the initial combo, since there was an issue with cheking out the selected combo
checkout_repos(verbose, override, initial_repo_sources, workspace_path, manifest)
finally:
--
2.24.0.windows.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures
2020-03-18 19:29 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures Nate DeSimone
@ 2020-03-18 19:43 ` Desimone, Ashley E
2020-03-18 22:43 ` Bjorge, Erik C
0 siblings, 1 reply; 3+ messages in thread
From: Desimone, Ashley E @ 2020-03-18 19:43 UTC (permalink / raw)
To: Desimone, Nathaniel L, devel@edk2.groups.io
Cc: Pandya, Puja, Bjorge, Erik C, Bret Barkelew
Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com>
-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Sent: Wednesday, March 18, 2020 12:29 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
edkrepo/common/common_repo_functions.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/edkrepo/common/common_repo_functions.py b/edkrepo/common/common_repo_functions.py
index 4b580c0..288dd27 100644
--- a/edkrepo/common/common_repo_functions.py
+++ b/edkrepo/common/common_repo_functions.py
@@ -14,6 +14,7 @@ import sys
import unicodedata
import urllib.request
import subprocess
+import traceback
import git
from git import Repo
@@ -600,7 +601,9 @@ def checkout(combination_or_sha, verbose=False, override=False, log=None):
if combination_is_in_manifest(combo_or_sha, manifest):
manifest.write_current_combo(combo_or_sha)
except:
- print (CHECKOUT_COMBO_UNSUCCESFULL.format(combo_or_sha))
+ if verbose:
+ traceback.print_exc()
+ print (CHECKOUT_COMBO_UNSUCCESSFULL.format(combo_or_sha))
# Return to the initial combo, since there was an issue with cheking out the selected combo
checkout_repos(verbose, override, initial_repo_sources, workspace_path, manifest)
finally:
--
2.24.0.windows.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures
2020-03-18 19:43 ` Desimone, Ashley E
@ 2020-03-18 22:43 ` Bjorge, Erik C
0 siblings, 0 replies; 3+ messages in thread
From: Bjorge, Erik C @ 2020-03-18 22:43 UTC (permalink / raw)
To: Desimone, Ashley E, Desimone, Nathaniel L, devel@edk2.groups.io
Cc: Pandya, Puja, Bret Barkelew
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com>
Sent: Wednesday, March 18, 2020 12:43 PM
To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; devel@edk2.groups.io
Cc: Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: RE: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures
Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com>
-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Sent: Wednesday, March 18, 2020 12:29 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
edkrepo/common/common_repo_functions.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/edkrepo/common/common_repo_functions.py b/edkrepo/common/common_repo_functions.py
index 4b580c0..288dd27 100644
--- a/edkrepo/common/common_repo_functions.py
+++ b/edkrepo/common/common_repo_functions.py
@@ -14,6 +14,7 @@ import sys
import unicodedata
import urllib.request
import subprocess
+import traceback
import git
from git import Repo
@@ -600,7 +601,9 @@ def checkout(combination_or_sha, verbose=False, override=False, log=None):
if combination_is_in_manifest(combo_or_sha, manifest):
manifest.write_current_combo(combo_or_sha)
except:
- print (CHECKOUT_COMBO_UNSUCCESFULL.format(combo_or_sha))
+ if verbose:
+ traceback.print_exc()
+ print (CHECKOUT_COMBO_UNSUCCESSFULL.format(combo_or_sha))
# Return to the initial combo, since there was an issue with cheking out the selected combo
checkout_repos(verbose, override, initial_repo_sources, workspace_path, manifest)
finally:
--
2.24.0.windows.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-18 22:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-18 19:29 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures Nate DeSimone
2020-03-18 19:43 ` Desimone, Ashley E
2020-03-18 22:43 ` Bjorge, Erik C
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox