From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.5451.1584676680554796841 for ; Thu, 19 Mar 2020 20:58:00 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: zhijux.fan@intel.com) IronPort-SDR: gybMFtwRDcfEdoqF0VqAIl3wDogesDyL2LRidWYdnrM/ljEXzo9ldEgS2U7KCp06QtwD32mIM0 Vocl8oN0luUg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2020 20:58:00 -0700 IronPort-SDR: w1t/c7j1c3faYyPF+i/vzlTOzRF9EFGoMX1BLk+eE1fKAThtvwgLdRcUFsx2gK4AnyBlYlfYbk F1RUsDPfgQaA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,283,1580803200"; d="scan'208";a="239120341" Received: from zhijufax-mobl.ccr.corp.intel.com ([10.238.4.120]) by orsmga008.jf.intel.com with ESMTP; 19 Mar 2020 20:57:57 -0700 From: "Fan, ZhijuX" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , "Zhiju . Fan" Subject: [PATCH 1/1] BaseTools:Fix build tools print traceback info issue Date: Fri, 20 Mar 2020 11:57:55 +0800 Message-Id: <20200320035755.13080-1-zhijux.fan@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2610 We meet a case that the DEC file declaring the PCD isn't included in the INF.it cause build tools report Traceback error. Remove raise statements that generate Tracebacks that were only intended for development/debug. With the raise statements removed proper error messages are shown. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py index 40b448f5b2db..563d91b421ce 100755 --- a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py +++ b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py @@ -256,7 +256,6 @@ class AutoGenWorkerInProcess(mp.Process): CacheResult = Ma.CanSkipbyPreMakeCache() except: CacheResult = False - traceback.print_exc(file=sys.stdout) self.feedback_q.put(taskname) if CacheResult: @@ -273,7 +272,6 @@ class AutoGenWorkerInProcess(mp.Process): CacheResult = Ma.CanSkipbyMakeCache() except: CacheResult = False - traceback.print_exc(file=sys.stdout) self.feedback_q.put(taskname) if CacheResult: @@ -285,7 +283,6 @@ class AutoGenWorkerInProcess(mp.Process): except Empty: pass except: - traceback.print_exc(file=sys.stdout) self.feedback_q.put(taskname) finally: self.feedback_q.put("Done") -- 2.14.1.windows.1