[Patch 1/1] BaseTools: Add .map file as a target in makefile

[Patch 1/1] BaseTools: Add .map file as a target in makefile

[Bob Feng]

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2624

The .map file may not exist, adding .map as a target
with empty dependency and command will avoid build failure.

Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 BaseTools/Source/Python/AutoGen/GenMake.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py
index bbb3c29446f5..f09a0b88297e 100755
--- a/BaseTools/Source/Python/AutoGen/GenMake.py
+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
@@ -731,10 +731,11 @@ cleanlib:
                     if Dst not in self.ResultFileList:
                         self.ResultFileList.append(Dst)
                     if '%s :' %(Dst) not in self.BuildTargetList:
                         self.BuildTargetList.append("%s : %s" %(Dst,Src))
                         self.BuildTargetList.append('\t' + self._CP_TEMPLATE_[self._Platform] %{'Src': Src, 'Dst': Dst})
+                        self.BuildTargetList.append("%s :" %(Src,))
 
             FfsCmdList = Cmd[0]
             for index, Str in enumerate(FfsCmdList):
                 if '-o' == Str:
                     OutputFile = FfsCmdList[index + 1]
-- 
2.20.1.windows.1

Re: [EXTERNAL] [Patch 1/1] BaseTools: Add .map file as a target in makefile

[Bret Barkelew]

[-- Attachment #1: Type: text/plain, Size: 2200 bytes --]

Updated the Bugzilla with feedback on this. I don’t think this is a good final solution.
It creates two new empty dependencies: one for the binary blob, but one for the parent driver. The parent driver dependency causes a warning in compiling.

- Bret

From: Bob Feng<mailto:bob.c.feng@intel.com>
Sent: Monday, March 23, 2020 8:12 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Liming Gao<mailto:liming.gao@intel.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [Patch 1/1] BaseTools: Add .map file as a target in makefile

Ref: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2624&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7C9c94983c098f4f1d604708d7cfa13bb2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637206163707852733&amp;sdata=wqLUJ4Chlj%2FPHGbKr8Kfpscf6ZBFn26GGCewpz0RbYo%3D&amp;reserved=0

The .map file may not exist, adding .map as a target
with empty dependency and command will avoid build failure.

Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 BaseTools/Source/Python/AutoGen/GenMake.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py
index bbb3c29446f5..f09a0b88297e 100755
--- a/BaseTools/Source/Python/AutoGen/GenMake.py
+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
@@ -731,10 +731,11 @@ cleanlib:
                     if Dst not in self.ResultFileList:
                         self.ResultFileList.append(Dst)
                     if '%s :' %(Dst) not in self.BuildTargetList:
                         self.BuildTargetList.append("%s : %s" %(Dst,Src))
                         self.BuildTargetList.append('\t' + self._CP_TEMPLATE_[self._Platform] %{'Src': Src, 'Dst': Dst})
+                        self.BuildTargetList.append("%s :" %(Src,))

             FfsCmdList = Cmd[0]
             for index, Str in enumerate(FfsCmdList):
                 if '-o' == Str:
                     OutputFile = FfsCmdList[index + 1]
--
2.20.1.windows.1


[-- Attachment #2: Type: text/html, Size: 5591 bytes --]