* [PATCH v5 0/3] Add RpmcLib and VariableKeyLib
@ 2020-03-26 7:49 Wang, Jian J
2020-03-26 7:49 ` [PATCH v5 1/3] SecurityPkg: add RpmcLib and VariableKeyLib public headers Wang, Jian J
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Wang, Jian J @ 2020-03-26 7:49 UTC (permalink / raw)
To: devel; +Cc: Jiewen Yao, Chao Zhang, Nishant C Mistry
> v5: change VariableRootKey to VariableKey
> v4: remove CounterId which should not be exposed
> v3: update retval description in RpmcLib.h and RpmcLibNull.c
> v2: change CounterIndex to CounterId in RpmcLib prototype.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Patch branch: https://github.com/jwang36/edk2/tree/bz2594-part1-common-interfaces-between-platform-and-edk2-v5
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
Jian J Wang (3):
SecurityPkg: add RpmcLib and VariableKeyLib public headers
SecurityPkg: add null version of RpmcLib
SecurityPkg: add null version of VariableKeyLib
SecurityPkg/Include/Library/RpmcLib.h | 42 ++++++++++++
SecurityPkg/Include/Library/VariableKeyLib.h | 59 ++++++++++++++++
SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 47 +++++++++++++
.../Library/RpmcLibNull/RpmcLibNull.inf | 33 +++++++++
.../VariableKeyLibNull/VariableKeyLibNull.c | 67 +++++++++++++++++++
.../VariableKeyLibNull/VariableKeyLibNull.inf | 33 +++++++++
SecurityPkg/SecurityPkg.dec | 8 +++
SecurityPkg/SecurityPkg.dsc | 8 +++
8 files changed, 297 insertions(+)
create mode 100644 SecurityPkg/Include/Library/RpmcLib.h
create mode 100644 SecurityPkg/Include/Library/VariableKeyLib.h
create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
create mode 100644 SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
create mode 100644 SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf
--
2.24.0.windows.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v5 1/3] SecurityPkg: add RpmcLib and VariableKeyLib public headers
2020-03-26 7:49 [PATCH v5 0/3] Add RpmcLib and VariableKeyLib Wang, Jian J
@ 2020-03-26 7:49 ` Wang, Jian J
2020-03-26 7:49 ` [PATCH v5 2/3] SecurityPkg: add null version of RpmcLib Wang, Jian J
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Wang, Jian J @ 2020-03-26 7:49 UTC (permalink / raw)
To: devel; +Cc: Jiewen Yao, Chao Zhang, Nishant C Mistry
> v5: change VariableRootKey to VariableKey
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
RpmcLib.h and VariableKeyLib.h are header files required to access RPMC
device and Key generator from platform. They will be used to ensure the
integrity and confidentiality of NV variables.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
SecurityPkg/Include/Library/RpmcLib.h | 42 ++++++++++++++
SecurityPkg/Include/Library/VariableKeyLib.h | 59 ++++++++++++++++++++
SecurityPkg/SecurityPkg.dec | 8 +++
3 files changed, 109 insertions(+)
create mode 100644 SecurityPkg/Include/Library/RpmcLib.h
create mode 100644 SecurityPkg/Include/Library/VariableKeyLib.h
diff --git a/SecurityPkg/Include/Library/RpmcLib.h b/SecurityPkg/Include/Library/RpmcLib.h
new file mode 100644
index 0000000000..8e3868516c
--- /dev/null
+++ b/SecurityPkg/Include/Library/RpmcLib.h
@@ -0,0 +1,42 @@
+/** @file
+ Public definitions for the Replay Protected Monotonic Counter (RPMC) Library.
+
+Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#ifndef _RPMC_LIB_H_
+#define _RPMC_LIB_H_
+
+#include <Uefi/UefiBaseType.h>
+
+/**
+ Requests the monotonic counter from the designated RPMC counter.
+
+ @param[out] CounterValue A pointer to a buffer to store the RPMC value.
+
+ @retval EFI_SUCCESS The operation completed successfully.
+ @retval EFI_DEVICE_ERROR A device error occurred while attempting to update the counter.
+ @retval EFI_UNSUPPORTED The operation is un-supported.
+**/
+EFI_STATUS
+EFIAPI
+RequestMonotonicCounter (
+ OUT UINT32 *CounterValue
+ );
+
+/**
+ Increments the monotonic counter in the SPI flash device by 1.
+
+ @retval EFI_SUCCESS The operation completed successfully.
+ @retval EFI_DEVICE_ERROR A device error occurred while attempting to update the counter.
+ @retval EFI_UNSUPPORTED The operation is un-supported.
+**/
+EFI_STATUS
+EFIAPI
+IncrementMonotonicCounter (
+ VOID
+ );
+
+#endif
\ No newline at end of file
diff --git a/SecurityPkg/Include/Library/VariableKeyLib.h b/SecurityPkg/Include/Library/VariableKeyLib.h
new file mode 100644
index 0000000000..596c8a2319
--- /dev/null
+++ b/SecurityPkg/Include/Library/VariableKeyLib.h
@@ -0,0 +1,59 @@
+/** @file
+ Public definitions for Variable Key Library.
+
+Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#ifndef _VARIABLE_KEY_LIB_H_
+#define _VARIABLE_KEY_LIB_H_
+
+#include <Uefi/UefiBaseType.h>
+
+/**
+ Retrieves the key for integrity and/or confidentiality of variables.
+
+ @param[out] VariableKey A pointer to pointer for the variable key buffer.
+ @param[in,out] VariableKeySize The size in bytes of the variable key.
+
+ @retval EFI_SUCCESS The variable key was returned.
+ @retval EFI_DEVICE_ERROR An error occurred while attempting to get the variable key.
+ @retval EFI_ACCESS_DENIED The function was invoked after locking the key interface.
+ @retval EFI_UNSUPPORTED The variable key is not supported in the current boot configuration.
+**/
+EFI_STATUS
+EFIAPI
+GetVariableKey (
+ OUT VOID **VariableKey,
+ IN OUT UINTN *VariableKeySize
+ );
+
+/**
+ Regenerates the variable key.
+
+ @retval EFI_SUCCESS The variable key was regenerated successfully.
+ @retval EFI_DEVICE_ERROR An error occurred while attempting to regenerate the key.
+ @retval EFI_ACCESS_DENIED The function was invoked after locking the key interface.
+ @retval EFI_UNSUPPORTED Key regeneration is not supported in the current boot configuration.
+**/
+EFI_STATUS
+EFIAPI
+RegenerateVariableKey (
+ VOID
+ );
+
+/**
+ Locks the regenerate key interface.
+
+ @retval EFI_SUCCESS The key interface was locked successfully.
+ @retval EFI_UNSUPPORTED Locking the key interface is not supported in the current boot configuration.
+ @retval Others An error occurred while attempting to lock the key interface.
+**/
+EFI_STATUS
+EFIAPI
+LockVariableKeyInterface (
+ VOID
+ );
+
+#endif
\ No newline at end of file
diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
index 5335cc5397..2cdfb02cc5 100644
--- a/SecurityPkg/SecurityPkg.dec
+++ b/SecurityPkg/SecurityPkg.dec
@@ -76,6 +76,14 @@
#
TcgStorageOpalLib|Include/Library/TcgStorageOpalLib.h
+ ## @libraryclass Provides interfaces to access RPMC device.
+ #
+ RpmcLib|Include/Library/RpmcLib.h
+
+ ## @libraryclass Provides interfaces to access variable root key.
+ #
+ VariableKeyLib|Include/Library/VariableKeyLib.h
+
[Guids]
## Security package token space guid.
# Include/Guid/SecurityPkgTokenSpace.h
--
2.24.0.windows.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v5 2/3] SecurityPkg: add null version of RpmcLib
2020-03-26 7:49 [PATCH v5 0/3] Add RpmcLib and VariableKeyLib Wang, Jian J
2020-03-26 7:49 ` [PATCH v5 1/3] SecurityPkg: add RpmcLib and VariableKeyLib public headers Wang, Jian J
@ 2020-03-26 7:49 ` Wang, Jian J
2020-03-26 7:49 ` [PATCH v5 3/3] SecurityPkg: add null version of VariableKeyLib Wang, Jian J
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Wang, Jian J @ 2020-03-26 7:49 UTC (permalink / raw)
To: devel; +Cc: Jiewen Yao, Chao Zhang, Nishant C Mistry
> v4: remove CounterId which should not be exposed
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add null version of RpmcLib instance. The full version should be provided
by platform which supports RPMC device.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 47 +++++++++++++++++++
.../Library/RpmcLibNull/RpmcLibNull.inf | 33 +++++++++++++
SecurityPkg/SecurityPkg.dsc | 6 +++
3 files changed, 86 insertions(+)
create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
diff --git a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
new file mode 100644
index 0000000000..e1dd09eb10
--- /dev/null
+++ b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
@@ -0,0 +1,47 @@
+/** @file
+ NULL RpmcLib instance for build purpose.
+
+Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#include <Library/DebugLib.h>
+#include <Library/RpmcLib.h>
+
+/**
+ Requests the monotonic counter from the designated RPMC counter.
+
+ @param[out] CounterValue A pointer to a buffer to store the RPMC value.
+
+ @retval EFI_SUCCESS The operation completed successfully.
+ @retval EFI_DEVICE_ERROR A device error occurred while attempting to update the counter.
+ @retval EFI_UNSUPPORTED The operation is un-supported.
+**/
+EFI_STATUS
+EFIAPI
+RequestMonotonicCounter (
+ OUT UINT32 *CounterValue
+ )
+{
+ ASSERT (FALSE);
+ return EFI_UNSUPPORTED;
+}
+
+/**
+ Increments the monotonic counter in the SPI flash device by 1.
+
+ @retval EFI_SUCCESS The operation completed successfully.
+ @retval EFI_DEVICE_ERROR A device error occurred while attempting to update the counter.
+ @retval EFI_UNSUPPORTED The operation is un-supported.
+**/
+EFI_STATUS
+EFIAPI
+IncrementMonotonicCounter (
+ VOID
+ )
+{
+ ASSERT (FALSE);
+ return EFI_UNSUPPORTED;
+}
+
diff --git a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
new file mode 100644
index 0000000000..500edfa87d
--- /dev/null
+++ b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
@@ -0,0 +1,33 @@
+## @file
+# Provides Null version of RpmcLib for build purpose.
+#
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+ INF_VERSION = 0x00010029
+ BASE_NAME = RpmcLibNull
+ FILE_GUID = FAE0BA22-92E2-4334-8F0F-96AFF9BAE360
+ MODULE_TYPE = BASE
+ VERSION_STRING = 1.0
+ LIBRARY_CLASS = RpmcLib
+
+#
+# The following information is for reference only and not required by the build tools.
+#
+# VALID_ARCHITECTURES = IA32 X64 Arm AArch64
+#
+
+[Sources]
+ RpmcLibNull.c
+
+[Packages]
+ MdePkg/MdePkg.dec
+ SecurityPkg/SecurityPkg.dec
+
+[LibraryClasses]
+ BaseLib
+ DebugLib
+
diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
index a2eeadda7a..97e0e7ed6e 100644
--- a/SecurityPkg/SecurityPkg.dsc
+++ b/SecurityPkg/SecurityPkg.dsc
@@ -64,6 +64,7 @@
TcgStorageCoreLib|SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCoreLib.inf
TcgStorageOpalLib|SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalLib.inf
ResetSystemLib|MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.inf
+ RpmcLib|SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
[LibraryClasses.ARM]
#
@@ -217,6 +218,11 @@
SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCoreLib.inf
SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalLib.inf
+ #
+ # Variable Confidentiality & Integrity
+ #
+ SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
+
#
# Other
#
--
2.24.0.windows.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v5 3/3] SecurityPkg: add null version of VariableKeyLib
2020-03-26 7:49 [PATCH v5 0/3] Add RpmcLib and VariableKeyLib Wang, Jian J
2020-03-26 7:49 ` [PATCH v5 1/3] SecurityPkg: add RpmcLib and VariableKeyLib public headers Wang, Jian J
2020-03-26 7:49 ` [PATCH v5 2/3] SecurityPkg: add null version of RpmcLib Wang, Jian J
@ 2020-03-26 7:49 ` Wang, Jian J
2020-03-26 17:24 ` [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib Michael Kubacki
2020-03-27 1:48 ` Yao, Jiewen
4 siblings, 0 replies; 7+ messages in thread
From: Wang, Jian J @ 2020-03-26 7:49 UTC (permalink / raw)
To: devel; +Cc: Jiewen Yao, Chao Zhang, Nishant C Mistry
> v5: change VariableRootKey to VariableKey
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add null version of VariableKeyLib instance. The full version should be
provided by platforms which supports key generator.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
.../VariableKeyLibNull/VariableKeyLibNull.c | 67 +++++++++++++++++++
.../VariableKeyLibNull/VariableKeyLibNull.inf | 33 +++++++++
SecurityPkg/SecurityPkg.dsc | 2 +
3 files changed, 102 insertions(+)
create mode 100644 SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
create mode 100644 SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf
diff --git a/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c b/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
new file mode 100644
index 0000000000..3ddb37cabc
--- /dev/null
+++ b/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
@@ -0,0 +1,67 @@
+/** @file
+ Null version of VariableKeyLib for build purpose. Don't use it in real product.
+
+Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+#include <Library/DebugLib.h>
+#include <Library/VariableKeyLib.h>
+
+/**
+ Retrieves the key for integrity and/or confidentiality of variables.
+
+ @param[out] VariableKey A pointer to pointer for the variable key buffer.
+ @param[in,out] VariableKeySize The size in bytes of the variable key.
+
+ @retval EFI_SUCCESS The variable key was returned.
+ @retval EFI_DEVICE_ERROR An error occurred while attempting to get the variable key.
+ @retval EFI_ACCESS_DENIED The function was invoked after locking the key interface.
+ @retval EFI_UNSUPPORTED The variable key is not supported in the current boot configuration.
+**/
+EFI_STATUS
+EFIAPI
+GetVariableKey (
+ OUT VOID **VariableKey,
+ IN OUT UINTN *VariableKeySize
+ )
+{
+ ASSERT (FALSE);
+ return EFI_UNSUPPORTED;
+}
+
+/**
+ Regenerates the variable key.
+
+ @retval EFI_SUCCESS The variable key was regenerated successfully.
+ @retval EFI_DEVICE_ERROR An error occurred while attempting to regenerate the key.
+ @retval EFI_ACCESS_DENIED The function was invoked after locking the key interface.
+ @retval EFI_UNSUPPORTED Key regeneration is not supported in the current boot configuration.
+**/
+EFI_STATUS
+EFIAPI
+RegenerateVariableKey (
+ VOID
+ )
+{
+ ASSERT (FALSE);
+ return EFI_UNSUPPORTED;
+}
+
+/**
+ Locks the regenerate key interface.
+
+ @retval EFI_SUCCESS The key interface was locked successfully.
+ @retval EFI_UNSUPPORTED Locking the key interface is not supported in the current boot configuration.
+ @retval Others An error occurred while attempting to lock the key interface.
+**/
+EFI_STATUS
+EFIAPI
+LockVariableKeyInterface (
+ VOID
+ )
+{
+ ASSERT (FALSE);
+ return EFI_UNSUPPORTED;
+}
+
diff --git a/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf b/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf
new file mode 100644
index 0000000000..ea74e38cf9
--- /dev/null
+++ b/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf
@@ -0,0 +1,33 @@
+## @file
+# Provides Null version of VariableKeyLib for build only.
+#
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+ INF_VERSION = 0x00010029
+ BASE_NAME = VariableKeyLibNull
+ FILE_GUID = 2B640ED8-1E6A-4516-9F1D-25910E59BC4A
+ MODULE_TYPE = BASE
+ VERSION_STRING = 1.0
+ LIBRARY_CLASS = VariableKeyLib
+
+#
+# The following information is for reference only and not required by the build tools.
+#
+# VALID_ARCHITECTURES = IA32 X64 Arm AArch64
+#
+
+[Sources]
+ VariableKeyLibNull.c
+
+[Packages]
+ MdePkg/MdePkg.dec
+ SecurityPkg/SecurityPkg.dec
+
+[LibraryClasses]
+ BaseLib
+ DebugLib
+
diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
index 97e0e7ed6e..4b85f77b02 100644
--- a/SecurityPkg/SecurityPkg.dsc
+++ b/SecurityPkg/SecurityPkg.dsc
@@ -64,6 +64,7 @@
TcgStorageCoreLib|SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCoreLib.inf
TcgStorageOpalLib|SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalLib.inf
ResetSystemLib|MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.inf
+ VariableKeyLib|SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf
RpmcLib|SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
[LibraryClasses.ARM]
@@ -221,6 +222,7 @@
#
# Variable Confidentiality & Integrity
#
+ SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf
SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
#
--
2.24.0.windows.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib
2020-03-26 7:49 [PATCH v5 0/3] Add RpmcLib and VariableKeyLib Wang, Jian J
` (2 preceding siblings ...)
2020-03-26 7:49 ` [PATCH v5 3/3] SecurityPkg: add null version of VariableKeyLib Wang, Jian J
@ 2020-03-26 17:24 ` Michael Kubacki
2020-03-27 1:45 ` Wang, Jian J
2020-03-27 1:48 ` Yao, Jiewen
4 siblings, 1 reply; 7+ messages in thread
From: Michael Kubacki @ 2020-03-26 17:24 UTC (permalink / raw)
To: devel, jian.j.wang; +Cc: Jiewen Yao, Chao Zhang, Nishant C Mistry
For the series:
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
On 3/26/2020 12:49 AM, Wang, Jian J wrote:
>> v5: change VariableRootKey to VariableKey
>
>> v4: remove CounterId which should not be exposed
>
>> v3: update retval description in RpmcLib.h and RpmcLibNull.c
>
>> v2: change CounterIndex to CounterId in RpmcLib prototype.
>
>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
>
> Patch branch: https://github.com/jwang36/edk2/tree/bz2594-part1-common-interfaces-between-platform-and-edk2-v5
>
>
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
>
> Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
>
> Jian J Wang (3):
> SecurityPkg: add RpmcLib and VariableKeyLib public headers
> SecurityPkg: add null version of RpmcLib
> SecurityPkg: add null version of VariableKeyLib
>
> SecurityPkg/Include/Library/RpmcLib.h | 42 ++++++++++++
> SecurityPkg/Include/Library/VariableKeyLib.h | 59 ++++++++++++++++
> SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 47 +++++++++++++
> .../Library/RpmcLibNull/RpmcLibNull.inf | 33 +++++++++
> .../VariableKeyLibNull/VariableKeyLibNull.c | 67 +++++++++++++++++++
> .../VariableKeyLibNull/VariableKeyLibNull.inf | 33 +++++++++
> SecurityPkg/SecurityPkg.dec | 8 +++
> SecurityPkg/SecurityPkg.dsc | 8 +++
> 8 files changed, 297 insertions(+)
> create mode 100644 SecurityPkg/Include/Library/RpmcLib.h
> create mode 100644 SecurityPkg/Include/Library/VariableKeyLib.h
> create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
> create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
> create mode 100644 SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
> create mode 100644 SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib
2020-03-26 17:24 ` [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib Michael Kubacki
@ 2020-03-27 1:45 ` Wang, Jian J
0 siblings, 0 replies; 7+ messages in thread
From: Wang, Jian J @ 2020-03-27 1:45 UTC (permalink / raw)
To: Michael Kubacki, devel@edk2.groups.io
Cc: Yao, Jiewen, Zhang, Chao B, Mistry, Nishant C
Michael,
Good to see you "back"😊 and thanks for the review.
Regards,
Jian
> -----Original Message-----
> From: Michael Kubacki <michael.kubacki@outlook.com>
> Sent: Friday, March 27, 2020 1:25 AM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Mistry, Nishant C <nishant.c.mistry@intel.com>
> Subject: Re: [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib
>
> For the series:
>
> Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> On 3/26/2020 12:49 AM, Wang, Jian J wrote:
> >> v5: change VariableRootKey to VariableKey
> >
> >> v4: remove CounterId which should not be exposed
> >
> >> v3: update retval description in RpmcLib.h and RpmcLibNull.c
> >
> >> v2: change CounterIndex to CounterId in RpmcLib prototype.
> >
> >
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
> >
> > Patch branch: https://github.com/jwang36/edk2/tree/bz2594-part1-common-
> interfaces-between-platform-and-edk2-v5
> >
> >
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> >
> > Cc: Chao Zhang <chao.b.zhang@intel.com>
> >
> > Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
> >
> > Jian J Wang (3):
> > SecurityPkg: add RpmcLib and VariableKeyLib public headers
> > SecurityPkg: add null version of RpmcLib
> > SecurityPkg: add null version of VariableKeyLib
> >
> > SecurityPkg/Include/Library/RpmcLib.h | 42 ++++++++++++
> > SecurityPkg/Include/Library/VariableKeyLib.h | 59 ++++++++++++++++
> > SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 47 +++++++++++++
> > .../Library/RpmcLibNull/RpmcLibNull.inf | 33 +++++++++
> > .../VariableKeyLibNull/VariableKeyLibNull.c | 67 +++++++++++++++++++
> > .../VariableKeyLibNull/VariableKeyLibNull.inf | 33 +++++++++
> > SecurityPkg/SecurityPkg.dec | 8 +++
> > SecurityPkg/SecurityPkg.dsc | 8 +++
> > 8 files changed, 297 insertions(+)
> > create mode 100644 SecurityPkg/Include/Library/RpmcLib.h
> > create mode 100644 SecurityPkg/Include/Library/VariableKeyLib.h
> > create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
> > create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
> > create mode 100644
> SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
> > create mode 100644
> SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v5 0/3] Add RpmcLib and VariableKeyLib
2020-03-26 7:49 [PATCH v5 0/3] Add RpmcLib and VariableKeyLib Wang, Jian J
` (3 preceding siblings ...)
2020-03-26 17:24 ` [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib Michael Kubacki
@ 2020-03-27 1:48 ` Yao, Jiewen
4 siblings, 0 replies; 7+ messages in thread
From: Yao, Jiewen @ 2020-03-27 1:48 UTC (permalink / raw)
To: Wang, Jian J, devel@edk2.groups.io; +Cc: Zhang, Chao B, Mistry, Nishant C
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Wang, Jian J <jian.j.wang@intel.com>
> Sent: Thursday, March 26, 2020 3:50 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Mistry, Nishant C <nishant.c.mistry@intel.com>
> Subject: [PATCH v5 0/3] Add RpmcLib and VariableKeyLib
>
> > v5: change VariableRootKey to VariableKey
>
> > v4: remove CounterId which should not be exposed
>
> > v3: update retval description in RpmcLib.h and RpmcLibNull.c
>
> > v2: change CounterIndex to CounterId in RpmcLib prototype.
>
>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
>
> Patch branch: https://github.com/jwang36/edk2/tree/bz2594-part1-common-
> interfaces-between-platform-and-edk2-v5
>
>
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
>
> Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
>
> Jian J Wang (3):
> SecurityPkg: add RpmcLib and VariableKeyLib public headers
> SecurityPkg: add null version of RpmcLib
> SecurityPkg: add null version of VariableKeyLib
>
> SecurityPkg/Include/Library/RpmcLib.h | 42 ++++++++++++
> SecurityPkg/Include/Library/VariableKeyLib.h | 59 ++++++++++++++++
> SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 47 +++++++++++++
> .../Library/RpmcLibNull/RpmcLibNull.inf | 33 +++++++++
> .../VariableKeyLibNull/VariableKeyLibNull.c | 67 +++++++++++++++++++
> .../VariableKeyLibNull/VariableKeyLibNull.inf | 33 +++++++++
> SecurityPkg/SecurityPkg.dec | 8 +++
> SecurityPkg/SecurityPkg.dsc | 8 +++
> 8 files changed, 297 insertions(+)
> create mode 100644 SecurityPkg/Include/Library/RpmcLib.h
> create mode 100644 SecurityPkg/Include/Library/VariableKeyLib.h
> create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
> create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
> create mode 100644
> SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
> create mode 100644
> SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf
>
> --
> 2.24.0.windows.2
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-27 1:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-26 7:49 [PATCH v5 0/3] Add RpmcLib and VariableKeyLib Wang, Jian J
2020-03-26 7:49 ` [PATCH v5 1/3] SecurityPkg: add RpmcLib and VariableKeyLib public headers Wang, Jian J
2020-03-26 7:49 ` [PATCH v5 2/3] SecurityPkg: add null version of RpmcLib Wang, Jian J
2020-03-26 7:49 ` [PATCH v5 3/3] SecurityPkg: add null version of VariableKeyLib Wang, Jian J
2020-03-26 17:24 ` [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib Michael Kubacki
2020-03-27 1:45 ` Wang, Jian J
2020-03-27 1:48 ` Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox