From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.groups.io with SMTP id smtpd.web11.34021.1585218290124241579 for ; Thu, 26 Mar 2020 03:24:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=lyAKnW93; spf=pass (domain: linaro.org, ip: 209.85.221.44, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f44.google.com with SMTP id t7so6980570wrw.12 for ; Thu, 26 Mar 2020 03:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pb4QzP5GS4+vR03R7lzDc7dHpLKMQUSKk8nibshTVLE=; b=lyAKnW93JGi5qNZfHN82i0yL2NffKgxCqjHrKf0b90AkszGgNmE7dEesrJ38FqzSwr antW1cgSVw8mie3e5r0SpHyLj1H5QGExAUiewD4gLS5kXDx2/qhFZqzN4WOYFEWq6h7b nm6vpIxe/4LNFCCXpocsErrB+JpanW7V5qW3cXdK3x9A++udgcIFgym9KWhwZn+EaiSH UkbkoDpxUy1gu1/XOWi6l1LzBeWhy2tFd5VMjlvpZ0plQ6gKO9UW8nEh+hd2UhQkzkDd f+ZpqpvzAhqAGLYGx2dj6opeY7OPCSyuPSWTpIwIQpw0qtvKX5m5WMUaqS8B28wHpWgm pOAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pb4QzP5GS4+vR03R7lzDc7dHpLKMQUSKk8nibshTVLE=; b=qra7BwO5iq2drCQf+pKu9d/SYSGPDvTMtmYfQhrBwDWdBKBsLYm5iP2YmcZNKk0wei pgoabIw/FwFLmDLmYvMW64Sk7gpHIxqtjR1tfPMAOlDAG3JMsBHELdNjp9TuLUjRK4JN WjP3nMexE8PG7vLw8wzTvEE9jhJbzmg1FvW4g6JFlCjm5vf/lp6GXaso1UKrGpyNoa14 CEwtzVFuMY1YtNuINU0a6owHDJ5HitK/eDt6KoCQppfQddQLdaltgIqyDOe2oOYm0A5/ do8D3Ak+CIZJmyKRiL3LEDC8GCT8c0z/jiGha4IyfOCbuLNHmk9YTxPgJo+5Wv/lLzCO t17g== X-Gm-Message-State: ANhLgQ1DWsyFdrvvhhpkQBDG9BZxd8gY4w/fkbLwejRXH2jSv1ZDLSyH oZkHukrsYFUoe6uymKuKVbT3OAGdRs7Fhw== X-Google-Smtp-Source: ADFU+vu23Ou/4v7kqx5fEeHnnXpUgFP87N/uDQT2EMqS7TBoXnBhiaKGZSQd9eCNxmQYe6ZJcD5hPA== X-Received: by 2002:adf:eed1:: with SMTP id a17mr8269708wrp.287.1585218288359; Thu, 26 Mar 2020 03:24:48 -0700 (PDT) Return-Path: Received: from e123331-lin.home (amontpellier-657-1-18-247.w109-210.abo.wanadoo.fr. [109.210.65.247]) by smtp.gmail.com with ESMTPSA id d5sm3124511wrh.40.2020.03.26.03.24.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2020 03:24:47 -0700 (PDT) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Laszlo Ersek , Leif Lindholm , Michael D Kinney , Ray Ni , Jiewen Yao , Bret Barkelew Subject: [PATCH 1/4] OvmfPkg: remove handling of properties table Date: Thu, 26 Mar 2020 11:24:40 +0100 Message-Id: <20200326102443.748-2-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200326102443.748-1-ard.biesheuvel@linaro.org> References: <20200326102443.748-1-ard.biesheuvel@linaro.org> The UEFI properties table and the associated memory protection feature was severely broken from the start, and has been deprecated for a while. Let's drop all references to it from OVMF so we can safely remove it from the DXE core as well. Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2633 Signed-off-by: Ard Biesheuvel --- OvmfPkg/OvmfPkgIa32.dsc | 1 - OvmfPkg/OvmfPkgIa32X64.dsc | 1 - OvmfPkg/OvmfPkgX64.dsc | 1 - OvmfPkg/OvmfXen.dsc | 1 - OvmfPkg/PlatformPei/Platform.c | 1 - OvmfPkg/PlatformPei/PlatformPei.inf | 1 - 6 files changed, 6 deletions(-) diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index 02ca17db8b2a..47926ac9e235 100644 --- a/OvmfPkg/OvmfPkgIa32.dsc +++ b/OvmfPkg/OvmfPkgIa32.dsc @@ -570,7 +570,6 @@ [PcdsDynamicDefault] # Noexec settings for DXE. gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|FALSE - gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable|FALSE # UefiCpuPkg PCDs related to initial AP bringup and general AP management. gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber|64 diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc index d08cf558c6aa..37943624dc72 100644 --- a/OvmfPkg/OvmfPkgIa32X64.dsc +++ b/OvmfPkg/OvmfPkgIa32X64.dsc @@ -581,7 +581,6 @@ [PcdsDynamicDefault] # Noexec settings for DXE. gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|FALSE - gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable|FALSE # UefiCpuPkg PCDs related to initial AP bringup and general AP management. gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber|64 diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index b2dccc40a865..f41ebb95d717 100644 --- a/OvmfPkg/OvmfPkgX64.dsc +++ b/OvmfPkg/OvmfPkgX64.dsc @@ -580,7 +580,6 @@ [PcdsDynamicDefault] # Noexec settings for DXE. gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|FALSE - gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable|FALSE # UefiCpuPkg PCDs related to initial AP bringup and general AP management. gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber|64 diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc index 85fe39f7896c..67b95d7b788c 100644 --- a/OvmfPkg/OvmfXen.dsc +++ b/OvmfPkg/OvmfXen.dsc @@ -483,7 +483,6 @@ [PcdsDynamicDefault] # Noexec settings for DXE. gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|FALSE - gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable|FALSE # Set memory encryption mask gEfiMdeModulePkgTokenSpaceGuid.PcdPteMemoryEncryptionAddressOrMask|0x0 diff --git a/OvmfPkg/PlatformPei/Platform.c b/OvmfPkg/PlatformPei/Platform.c index 587ca68fc210..088e616a980c 100644 --- a/OvmfPkg/PlatformPei/Platform.c +++ b/OvmfPkg/PlatformPei/Platform.c @@ -315,7 +315,6 @@ NoexecDxeInitialization ( VOID ) { - UPDATE_BOOLEAN_PCD_FROM_FW_CFG (PcdPropertiesTableEnable); UPDATE_BOOLEAN_PCD_FROM_FW_CFG (PcdSetNxForStack); } diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf b/OvmfPkg/PlatformPei/PlatformPei.inf index 8531c63995c1..19f2424981bc 100644 --- a/OvmfPkg/PlatformPei/PlatformPei.inf +++ b/OvmfPkg/PlatformPei/PlatformPei.inf @@ -94,7 +94,6 @@ [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack - gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable gEfiMdeModulePkgTokenSpaceGuid.PcdPteMemoryEncryptionAddressOrMask gEfiSecurityPkgTokenSpaceGuid.PcdOptionRomImageVerificationPolicy -- 2.17.1