public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pete Batard" <pete@akeo.ie>
To: devel@edk2.groups.io
Cc: ard.biesheuvel@linaro.org, leif@nuviainc.com, philmd@redhat.com,
	awarkentin@vmware.com
Subject: [edk2-platforms][PATCH 1/1] Platform/RPi4/ConfigDxe: Replace SD Host with eMMC2 SDHCI option
Date: Thu, 26 Mar 2020 17:09:13 +0000	[thread overview]
Message-ID: <20200326170913.10264-1-pete@akeo.ie> (raw)

From: Andrei Warkentin <andrey.warkentin@gmail.com>

SD Host is not usable on Pi 4 so replace it with an eMMC2 option.

Note that is a menu only change at this stage, since we don't have
eMMC support finalized.

Signed-off-by: Pete Batard <pete@akeo.ie>
---
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni | 1 +
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 7 ++++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni
index 046c75f9bfab..26d803f7b68d 100644
--- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni
+++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni
@@ -55,6 +55,7 @@
 
 #string STR_MMC_SD_PROMPT        #language en-US "uSD Routing"
 #string STR_MMC_SD_HELP          #language en-US "Choose host controller to drive uSD slot"
+#string STR_MMC_SD_EMMC2         #language en-US "eMMC2 SDHCI"
 #string STR_MMC_SD_SDHOST        #language en-US "Broadcom SDHOST"
 #string STR_MMC_SD_ARASAN        #language en-US "Arasan SDHCI"
 
diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
index a440775d5d70..0a650a947b66 100644
--- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
+++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
@@ -87,7 +87,7 @@ typedef struct {
 
 typedef struct {
   /*
-   * 0 - uSD slot routed to Broadcom SDHOST.
+   * 0 - uSD slot routed to Broadcom SDHOST on Pi 3 or eMMC2 on Pi 4.
    * 1 - uSD slot routed to Arasan SDHCI.
    */
   UINT32 Routing;
@@ -302,8 +302,13 @@ formset
             prompt      = STRING_TOKEN(STR_MMC_SD_PROMPT),
             help        = STRING_TOKEN(STR_MMC_SD_HELP),
             flags       = NUMERIC_SIZE_4 | INTERACTIVE | RESET_REQUIRED,
+#if (RPI_MODEL == 4)
+            option text = STRING_TOKEN(STR_MMC_SD_ARASAN), value = 1, flags = DEFAULT;
+            option text = STRING_TOKEN(STR_MMC_SD_EMMC2), value = 0, flags = 0;
+#else
             option text = STRING_TOKEN(STR_MMC_SD_ARASAN), value = 1, flags = 0;
             option text = STRING_TOKEN(STR_MMC_SD_SDHOST), value = 0, flags = DEFAULT;
+#endif
         endoneof;
 
         oneof varid = MmcDisableMulti.DisableMulti,
-- 
2.21.0.windows.1


             reply	other threads:[~2020-03-26 17:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 17:09 Pete Batard [this message]
2020-03-30 14:53 ` [edk2-platforms][PATCH 1/1] Platform/RPi4/ConfigDxe: Replace SD Host with eMMC2 SDHCI option Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200326170913.10264-1-pete@akeo.ie \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox