* Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing import definition
2020-03-26 21:25 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing import definition Desimone, Ashley E
@ 2020-03-26 21:32 ` Bjorge, Erik C
2020-03-26 21:55 ` Agyeman, Prince
2020-03-27 20:33 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Bjorge, Erik C @ 2020-03-26 21:32 UTC (permalink / raw)
To: Desimone, Ashley E, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Pandya, Puja, Bret Barkelew,
Agyeman, Prince
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com>
Sent: Thursday, March 26, 2020 2:26 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing import definition
Add the definition of PIN_FILE_HELP to
checkout_pin_args.py to fix import error.
Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
edkrepo/commands/arguments/checkout_pin_args.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/edkrepo/commands/arguments/checkout_pin_args.py b/edkrepo/commands/arguments/checkout_pin_args.py
index abd01b3..6020145 100644
--- a/edkrepo/commands/arguments/checkout_pin_args.py
+++ b/edkrepo/commands/arguments/checkout_pin_args.py
@@ -9,3 +9,4 @@
COMMAND_DESCRIPTION = ('Checks out the revisions described in a PIN file in '
'an existing workpace of the same project')
+PIN_FILE_HELP = ('The name of the pin file to checkout.')
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing import definition
2020-03-26 21:25 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing import definition Desimone, Ashley E
2020-03-26 21:32 ` Bjorge, Erik C
@ 2020-03-26 21:55 ` Agyeman, Prince
2020-03-27 20:33 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Agyeman, Prince @ 2020-03-26 21:55 UTC (permalink / raw)
To: Desimone, Ashley E, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Pandya, Puja, Bjorge, Erik C,
Bret Barkelew
Reviewed-by: Prince Agyeman <prince.agyeman@intel.com>
-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com>
Sent: Thursday, March 26, 2020 2:26 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing import definition
Add the definition of PIN_FILE_HELP to
checkout_pin_args.py to fix import error.
Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
edkrepo/commands/arguments/checkout_pin_args.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/edkrepo/commands/arguments/checkout_pin_args.py b/edkrepo/commands/arguments/checkout_pin_args.py
index abd01b3..6020145 100644
--- a/edkrepo/commands/arguments/checkout_pin_args.py
+++ b/edkrepo/commands/arguments/checkout_pin_args.py
@@ -9,3 +9,4 @@
COMMAND_DESCRIPTION = ('Checks out the revisions described in a PIN file in '
'an existing workpace of the same project')
+PIN_FILE_HELP = ('The name of the pin file to checkout.')
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing import definition
2020-03-26 21:25 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing import definition Desimone, Ashley E
2020-03-26 21:32 ` Bjorge, Erik C
2020-03-26 21:55 ` Agyeman, Prince
@ 2020-03-27 20:33 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2020-03-27 20:33 UTC (permalink / raw)
To: Desimone, Ashley E, devel@edk2.groups.io
Cc: Pandya, Puja, Bjorge, Erik C, Bret Barkelew, Agyeman, Prince
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
On 3/26/20, 2:26 PM, "Desimone, Ashley E" <ashley.e.desimone@intel.com> wrote:
Add the definition of PIN_FILE_HELP to
checkout_pin_args.py to fix import error.
Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
edkrepo/commands/arguments/checkout_pin_args.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/edkrepo/commands/arguments/checkout_pin_args.py b/edkrepo/commands/arguments/checkout_pin_args.py
index abd01b3..6020145 100644
--- a/edkrepo/commands/arguments/checkout_pin_args.py
+++ b/edkrepo/commands/arguments/checkout_pin_args.py
@@ -9,3 +9,4 @@
COMMAND_DESCRIPTION = ('Checks out the revisions described in a PIN file in '
'an existing workpace of the same project')
+PIN_FILE_HELP = ('The name of the pin file to checkout.')
--
2.16.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread