* [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically
@ 2020-03-27 20:31 Nate DeSimone
2020-03-27 22:28 ` Desimone, Ashley E
2020-03-31 22:59 ` Bjorge, Erik C
0 siblings, 2 replies; 3+ messages in thread
From: Nate DeSimone @ 2020-03-27 20:31 UTC (permalink / raw)
To: devel
Cc: Ashley DeSimone, Puja Pandya, Erik Bjorge, Bret Barkelew,
Philippe Mathieu-Daudé
Currently edkrepo --help shows a listing of commands
that is not in alphabetical order. This is confusing.
This change makes the list shown in alphabetical order.
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
edkrepo/commands/composite_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/commands/composite_command.py b/edkrepo/commands/composite_command.py
index b476445..ff53d3b 100644
--- a/edkrepo/commands/composite_command.py
+++ b/edkrepo/commands/composite_command.py
@@ -36,4 +36,4 @@ class CompositeCommand(object):
command_names = []
for command in self._commands:
command_names.append(command.get_metadata()['name'])
- return command_names
+ return sorted(command_names)
--
2.25.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically
2020-03-27 20:31 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically Nate DeSimone
@ 2020-03-27 22:28 ` Desimone, Ashley E
2020-03-31 22:59 ` Bjorge, Erik C
1 sibling, 0 replies; 3+ messages in thread
From: Desimone, Ashley E @ 2020-03-27 22:28 UTC (permalink / raw)
To: Desimone, Nathaniel L, devel@edk2.groups.io
Cc: Pandya, Puja, Bjorge, Erik C, Bret Barkelew,
Philippe Mathieu-Daudé
Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com>
-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Sent: Friday, March 27, 2020 1:31 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Philippe Mathieu-Daudé <philmd@redhat.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically
Currently edkrepo --help shows a listing of commands that is not in alphabetical order. This is confusing.
This change makes the list shown in alphabetical order.
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
edkrepo/commands/composite_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/commands/composite_command.py b/edkrepo/commands/composite_command.py
index b476445..ff53d3b 100644
--- a/edkrepo/commands/composite_command.py
+++ b/edkrepo/commands/composite_command.py
@@ -36,4 +36,4 @@ class CompositeCommand(object):
command_names = []
for command in self._commands:
command_names.append(command.get_metadata()['name'])
- return command_names
+ return sorted(command_names)
--
2.25.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically
2020-03-27 20:31 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically Nate DeSimone
2020-03-27 22:28 ` Desimone, Ashley E
@ 2020-03-31 22:59 ` Bjorge, Erik C
1 sibling, 0 replies; 3+ messages in thread
From: Bjorge, Erik C @ 2020-03-31 22:59 UTC (permalink / raw)
To: Desimone, Nathaniel L, devel@edk2.groups.io
Cc: Desimone, Ashley E, Pandya, Puja, Bret Barkelew,
Philippe Mathieu-Daudé
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Sent: Friday, March 27, 2020 1:31 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Philippe Mathieu-Daudé <philmd@redhat.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically
Currently edkrepo --help shows a listing of commands that is not in alphabetical order. This is confusing.
This change makes the list shown in alphabetical order.
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
edkrepo/commands/composite_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/commands/composite_command.py b/edkrepo/commands/composite_command.py
index b476445..ff53d3b 100644
--- a/edkrepo/commands/composite_command.py
+++ b/edkrepo/commands/composite_command.py
@@ -36,4 +36,4 @@ class CompositeCommand(object):
command_names = []
for command in self._commands:
command_names.append(command.get_metadata()['name'])
- return command_names
+ return sorted(command_names)
--
2.25.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-31 22:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-27 20:31 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically Nate DeSimone
2020-03-27 22:28 ` Desimone, Ashley E
2020-03-31 22:59 ` Bjorge, Erik C
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox