* [PATCH] OvmfPkg/GenericQemuLoadImageLib: Fix VS2019 UINT32 conversion error
@ 2020-03-29 13:51 Ard Biesheuvel
2020-03-30 11:39 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2020-03-29 13:51 UTC (permalink / raw)
To: devel; +Cc: lersek, Ard Biesheuvel
Building OVMF for X64 with secure boot enabled on VS2019 results in
the following error:
d:\a\1\s\OvmfPkg\Library\GenericQemuLoadImageLib\GenericQemuLoadImageLib.c(154):
error C2220: the following warning is treated as an error
d:\a\1\s\OvmfPkg\Library\GenericQemuLoadImageLib\GenericQemuLoadImageLib.c(154):
warning C4244: '=': conversion from 'UINTN' to 'UINT32', possible loss of data
Suppress the error by making the cast explicit.
Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2636
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
index f7f9a205f99d..14c8417d43e7 100644
--- a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
+++ b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
@@ -151,7 +151,7 @@ QemuLoadKernelImage (
//
// Drop the terminating NUL, convert to UTF-16.
//
- KernelLoadedImage->LoadOptionsSize = (CommandLineSize - 1) * 2;
+ KernelLoadedImage->LoadOptionsSize = (UINT32)((CommandLineSize - 1) * 2);
}
QemuFwCfgSelectItem (QemuFwCfgItemInitrdSize);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] OvmfPkg/GenericQemuLoadImageLib: Fix VS2019 UINT32 conversion error
2020-03-29 13:51 [PATCH] OvmfPkg/GenericQemuLoadImageLib: Fix VS2019 UINT32 conversion error Ard Biesheuvel
@ 2020-03-30 11:39 ` Laszlo Ersek
2020-03-30 12:06 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2020-03-30 11:39 UTC (permalink / raw)
To: Ard Biesheuvel, devel
On 03/29/20 15:51, Ard Biesheuvel wrote:
> Building OVMF for X64 with secure boot enabled on VS2019 results in
> the following error:
>
> d:\a\1\s\OvmfPkg\Library\GenericQemuLoadImageLib\GenericQemuLoadImageLib.c(154):
> error C2220: the following warning is treated as an error
> d:\a\1\s\OvmfPkg\Library\GenericQemuLoadImageLib\GenericQemuLoadImageLib.c(154):
> warning C4244: '=': conversion from 'UINTN' to 'UINT32', possible loss of data
>
> Suppress the error by making the cast explicit.
>
> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2636
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
> index f7f9a205f99d..14c8417d43e7 100644
> --- a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
> +++ b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
> @@ -151,7 +151,7 @@ QemuLoadKernelImage (
> //
> // Drop the terminating NUL, convert to UTF-16.
> //
> - KernelLoadedImage->LoadOptionsSize = (CommandLineSize - 1) * 2;
> + KernelLoadedImage->LoadOptionsSize = (UINT32)((CommandLineSize - 1) * 2);
> }
>
> QemuFwCfgSelectItem (QemuFwCfgItemInitrdSize);
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thank you very much!
Laszlo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] OvmfPkg/GenericQemuLoadImageLib: Fix VS2019 UINT32 conversion error
2020-03-30 11:39 ` Laszlo Ersek
@ 2020-03-30 12:06 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2020-03-30 12:06 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: edk2-devel-groups-io
On Mon, 30 Mar 2020 at 13:39, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 03/29/20 15:51, Ard Biesheuvel wrote:
> > Building OVMF for X64 with secure boot enabled on VS2019 results in
> > the following error:
> >
> > d:\a\1\s\OvmfPkg\Library\GenericQemuLoadImageLib\GenericQemuLoadImageLib.c(154):
> > error C2220: the following warning is treated as an error
> > d:\a\1\s\OvmfPkg\Library\GenericQemuLoadImageLib\GenericQemuLoadImageLib.c(154):
> > warning C4244: '=': conversion from 'UINTN' to 'UINT32', possible loss of data
> >
> > Suppress the error by making the cast explicit.
> >
> > Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2636
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> > OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
> > index f7f9a205f99d..14c8417d43e7 100644
> > --- a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
> > +++ b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
> > @@ -151,7 +151,7 @@ QemuLoadKernelImage (
> > //
> > // Drop the terminating NUL, convert to UTF-16.
> > //
> > - KernelLoadedImage->LoadOptionsSize = (CommandLineSize - 1) * 2;
> > + KernelLoadedImage->LoadOptionsSize = (UINT32)((CommandLineSize - 1) * 2);
> > }
> >
> > QemuFwCfgSelectItem (QemuFwCfgItemInitrdSize);
> >
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
Thanks. Pushed as 3000c2963db319d055f474c394b062af910bbb2f
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-30 12:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-29 13:51 [PATCH] OvmfPkg/GenericQemuLoadImageLib: Fix VS2019 UINT32 conversion error Ard Biesheuvel
2020-03-30 11:39 ` Laszlo Ersek
2020-03-30 12:06 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox