From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.51]) by mx.groups.io with SMTP id smtpd.web10.29261.1585494853770829133 for ; Sun, 29 Mar 2020 08:14:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=NGnCoNcC; spf=pass (domain: arm.com, ip: 40.107.15.51, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3FIRZm5cQG3qDmSD7YXUyY7QBkuqls6qfL6Bti50F1I=; b=NGnCoNcC9Jq19r/eQBBCg3eIzbI9EcKGHjclqWixoPpAl7SyJuzgbkP/8ckfL9u+6JUlLBKMBfltC8y2KcmPx+Pj1wJTID2mWe7a/pZFpnR+vPRSgcgh2Kosf/67rktyIrii8EamuUBsAZf/UCmwWPYr6vnd+jikodgYouO7F5w= Received: from AM0PR0202CA0004.eurprd02.prod.outlook.com (2603:10a6:208:1::17) by DB6PR0801MB1733.eurprd08.prod.outlook.com (2603:10a6:4:37::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:10 +0000 Received: from AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:1:cafe::f1) by AM0PR0202CA0004.outlook.office365.com (2603:10a6:208:1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19 via Frontend Transport; Sun, 29 Mar 2020 15:14:10 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT007.mail.protection.outlook.com (10.152.16.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:10 +0000 Received: ("Tessian outbound 19f8d550f75c:v48"); Sun, 29 Mar 2020 15:14:09 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 51f915a989c1b3ac X-CR-MTA-TID: 64aa7808 Received: from d980b44d2900.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8543C43A-CDF4-45DA-B67B-A00ACA027E43.1; Sun, 29 Mar 2020 15:14:04 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d980b44d2900.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e5ntAOid5OcZc9xZNy/vVxtkhrFeGYtFFtlEADmatrTj6Udx0Ictmn5rA/7rd8dcrixwLH/dXInu+XbxjDlq5Jc//4Uf5wtA7qxFV1AL4lO142qtSpXYPTBGNuH/rixVPd41Gfwy6daXPunhwTU73bDTDOsfik+j5rpdkA08/mdV/DPcoQo++Dpd7ulxPxrhaaxF0wF3e31KSyI5NYXuF/tOMveAdJ5un0GlerCCRo/3z7huBp97A687Deezhbx2SlF61HYMid2u6SEw5UF+0dh1+/lNs4NOu0fiaeK+9hiI7LFAwDsFRkaJ5MFVry/8+6xqfyP8DiKINeeXQWAkdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3FIRZm5cQG3qDmSD7YXUyY7QBkuqls6qfL6Bti50F1I=; b=cAR/xH0XQTqVp4WNAKmkFkGXWex6poFd80y+6s5T/GeKXCT1JCtbBWo1aD2mXJAV1ypYrm0AteDOu8dbLCE5vIUMDHhUau+tDLOoE1VDSaJrLKbsuUtT8kwCo7ZF9chipK4WpOgbwLc/zYOGrAuQ8cHg7pyjhpIlMN6hQ2rM+t+LOyu9yamKwWdcU1R/RgDbNBE/KZz/nx6LVYxLRJQGqD7wofQRpMKTcmgueirWBKx1lnRkme9yk7Gvir00fq2e8sKaLsnhfJQdROA2XAHMj5bmRxSOyELSjSbj+7/9igM+8g/msxGq70ZVO0VFAyzqappxz4Gw/JQWAcBC1XFaGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3FIRZm5cQG3qDmSD7YXUyY7QBkuqls6qfL6Bti50F1I=; b=NGnCoNcC9Jq19r/eQBBCg3eIzbI9EcKGHjclqWixoPpAl7SyJuzgbkP/8ckfL9u+6JUlLBKMBfltC8y2KcmPx+Pj1wJTID2mWe7a/pZFpnR+vPRSgcgh2Kosf/67rktyIrii8EamuUBsAZf/UCmwWPYr6vnd+jikodgYouO7F5w= Received: from DB7PR03CA0087.eurprd03.prod.outlook.com (2603:10a6:10:72::28) by VI1PR0802MB2461.eurprd08.prod.outlook.com (2603:10a6:800:af::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:02 +0000 Received: from DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::3f) by DB7PR03CA0087.outlook.office365.com (2603:10a6:10:72::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:02 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT031.mail.protection.outlook.com (10.152.20.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:02 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:14:01 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Sun, 29 Mar 2020 15:14:00 +0000 Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:14:00 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [PATCH v2 08/16] DynamicTablesPkg: Fix ACPI table rev field width Date: Sun, 29 Mar 2020 16:13:45 +0100 Message-ID: <20200329151353.14096-9-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(346002)(376002)(396003)(39850400004)(136003)(46966005)(5660300002)(316002)(54906003)(478600001)(966005)(86362001)(82740400003)(6916009)(47076004)(2616005)(44832011)(336012)(186003)(70586007)(426003)(26005)(70206006)(1076003)(2906002)(8676002)(36756003)(356004)(6666004)(81166006)(81156014)(8936002)(4326008)(7696005);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 00248ca2-3361-40d1-6828-08d7d3f3d522 X-MS-TrafficTypeDiagnostic: VI1PR0802MB2461:|DB6PR0801MB1733: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6108;OLM:6108; X-Forefront-PRVS: 035748864E X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WyuXU3BJcZIopO0qLjmfKplblUp2ZJmH7I64FY+eedtruTC9MKX7LdNt5d2k+TB7eHqEtUaRuS748LlieFrqd6a88yAPj6FPFYUuIOQOVT+N1/oSVCSbejcBCainmiQNv2y14DxiIb3QyIAsNwKzoSYfl2COlf4atnRtngO0W+fPUSEmL1jddiLUVEwgwojK2dkE8FEyZ6diOblKY4HuYqeoKgcXUGOI8LXnSCxggouQ3JbKq8r+cmVs0xrGKcxXOK/WOPCAJ6tgDkDMxaHR4mkJF8pEUkY80+AV8kciizzDpVSFKvYSfGZjL9yhlQyUBR2vPkamGl/zKx5p94nO2DBPB2b0gaJ6qkr7VXbFwIe9BObL+cAdnf9COeZf/HnCE2qmhuBzKMLFj+pZnrrQfjMDlFqenn17+UCZKXBo2OFLISnZsfep0rufdOjMGpH1RLQ4+/IIi96P2GpVfKZlaOaqsrALLuRV+0e80kxRvv/n1fX7/p4u6JSmqWSfRmjhz4+cqnRXBTjTpoGLDwtch7eEIisjRBKehtBIjRhvtTOlWRpWkEoO9qSkgFkw4Bwqh2eSnDjdMh6OoEq3uzhG2l6jXtPFjmPRIMoQvvpjI24= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2461 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(396003)(136003)(39850400004)(346002)(376002)(46966005)(26005)(336012)(36906005)(26826003)(70586007)(70206006)(316002)(2616005)(1076003)(966005)(4326008)(478600001)(5660300002)(44832011)(186003)(82740400003)(7696005)(81166006)(47076004)(54906003)(8676002)(81156014)(2906002)(8936002)(6916009)(426003)(6666004)(36756003)(86362001);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: a9f999f2-91e4-4780-13df-08d7d3f3d065 X-Forefront-PRVS: 035748864E X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xJtpQTJGuxxcSAWA/ATILnKSi+PpZ5VFGEUXoMoYDgbSWA7vDwW7kyRrKdfYO4nMBolLL7Z3ZmzHdtqqqQJx7E8QWpbrY+FqqLPhyBEn/MZ1nZxZ/nW7GzURdy6/F3KHeETmjVuGULIRN+MEfbHRjKPEwqPZzLPqZlOuOf+5L+TdL4aE0nVeUfOUZrDoegGU//t7IWYSiQiar9vCefKPPlYdvIBhWwL1vmoIm46O2lQayAaFJArCLDgGkXLPcy39Lax0xJbORUhFVgpR+YG7Lk0oXqgwkNMDfwslNYrCV6tq/cWYI/81tvZMBP6soBUJrgU8kHU0s6uCByIcof5cgQm3JygK7hJLSl0EWbAet5r89WydMkllgQt5BJccwnEqF/iMYj9TgzyIxdO3FP6f8XonymOfzim6xEvxPZXFPpcgLYYPF+d46+GNF84krX2OZ3nZIC2djHtMoHdp5Df0SJg1gDmxK13Zhgb1vI7e5hURVpkSTKK775kvhadZSSLhOJBd4PqvEPSViB5dZWckLYx5M/oauH7h/4WODekIVQ4i+nFhNjoTmfW85IJIT1v1s9QM3ey6IzivERbsqt5ZoncVcGPjCIOXMPiWrp0jBl8= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:10.1929 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 00248ca2-3361-40d1-6828-08d7d3f3d522 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1733 Content-Type: text/plain The VS2017 compiler reports 'warning C4244: '=': conversion from 'const UINT32' to 'UINT8', possible loss of data' when the ACPI table revision field is being updated. The width of the revision field in the EFI_ACPI_DESCRIPTION_HEADER struct is 8-bit wide. Therefore, to fix the above warning make the ACPI Table revision field usage 8-bit wide across Dynamic Tables Framework. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Include/AcpiTableGenerator.h | 4 ++-- DynamicTablesPkg/Include/StandardNameSpaceObjects.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/DynamicTablesPkg/Include/AcpiTableGenerator.h b/DynamicTablesPkg/Include/AcpiTableGenerator.h index e46717e6e8442ec516ef79ea979bd29e070f6d0a..b55feb4e7507f0e4e1e0a64c3c4b8068f17dad47 100644 --- a/DynamicTablesPkg/Include/AcpiTableGenerator.h +++ b/DynamicTablesPkg/Include/AcpiTableGenerator.h @@ -287,10 +287,10 @@ typedef struct AcpiTableGenerator { UINT32 AcpiTableSignature; /// The ACPI table revision. - UINT32 AcpiTableRevision; + UINT8 AcpiTableRevision; /// The minimum supported ACPI table revision. - UINT32 MinAcpiTableRevision; + UINT8 MinAcpiTableRevision; /// The ACPI table creator ID. UINT32 CreatorId; diff --git a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h b/DynamicTablesPkg/Include/StandardNameSpaceObjects.h index 21bb7de4044ffd6f97156f761e30fc1790f11c0c..0ba6b163691ea127ae7a7d57fb5f9fdf84789338 100644 --- a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h +++ b/DynamicTablesPkg/Include/StandardNameSpaceObjects.h @@ -79,7 +79,7 @@ typedef struct CmAStdObjAcpiTableInfo { UINT32 AcpiTableSignature; /// The ACPI table revision - UINT32 AcpiTableRevision; + UINT8 AcpiTableRevision; /// The ACPI Table Generator ID ACPI_TABLE_GENERATOR_ID TableGeneratorId; -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'