From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web10.45395.1585553722836319362 for ; Mon, 30 Mar 2020 00:35:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=I/CME1wm; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id e9so8763295wme.4 for ; Mon, 30 Mar 2020 00:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pOH+AGhJB021Tl8C5CBAxI2Xwrt3YAB73lFs0CZtw3U=; b=I/CME1wmot+38p5R6wVz/8+JhSPgMSkASPWTfNrXNGkR0SYYwIQLA1xYl4QZkJ9CtL khXH0yQFYVLFfBHA8cHHvnEP3AaZw4Zxo8+PPbBc7BJEyb0gyojKj0USK32AKPtkF6NG /Mq0LNpWt+QQHVWqTtXPa2A6bfOVsUJ60grRdz+2YDkK91cAJcRceAIq5f4KK8+Ns3Z8 A4JqmgQo6jRgXdjmaRITCvwJ+g0vLWz5CRhf4D+/acNUPyXLRKM+erbt8U3rjvuCZkrZ 9y1dqhoMfKIN8g9+oCyRD6uS93BoTjKxN0WG6vBTixVJ7wao7SsNz14bm9C5M/0RplVY EnQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pOH+AGhJB021Tl8C5CBAxI2Xwrt3YAB73lFs0CZtw3U=; b=f8o/g/o0o7VZ/jKhr+7rkpq2aCPrQldIhYvSt+j43gNfPDIeSK11DLX+CizRnNUUXK 81rcMW4zotT5sAvBHmrM58ioHfJLsEdBhtRWP7BLE0ZOtmgYoRVlzXzFrSJuPBUVQFJG pzaIPeYXeVoMrauYvm/ySIBX2+igolCRvpQT0xLQyOX26hk0PMlPv2HgNezWO8FeAKhx P8yArwpPMzixW3DzsGKok8S4BJ7LAgRrYBdT+VqycSC/zRH8I+aiL2uHPCfgxkAsBcsy On+lbZ/rQYMsUKXJphkYvw6/b8S76vkUCO0OnwMciO8eh4WZfrpf/GJOHyA+y2DHaaFI oYcA== X-Gm-Message-State: ANhLgQ31TYUZATnxI4N0D3xHcoL/NMim7yzPdfmMSQUAx4QsH+amQdV0 XnZzMc0E90tqCJAYQG8IDUnZ5g== X-Google-Smtp-Source: ADFU+vv6HQlQ6Nqwydf8TQ9/zP2DVhaXPdCzsGfZcP5MAGEyD2TIEMDfnwgD6o7kXkA2L47vuTWa3g== X-Received: by 2002:a05:600c:cc:: with SMTP id u12mr11901567wmm.60.1585553721190; Mon, 30 Mar 2020 00:35:21 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id s2sm20374589wru.68.2020.03.30.00.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 00:35:20 -0700 (PDT) Date: Mon, 30 Mar 2020 08:35:18 +0100 From: "Leif Lindholm" To: "Jiang, Guomin" Cc: "devel@edk2.groups.io" , "pankaj.bansal@nxp.com" , "Ni, Ray" , Ard Biesheuvel , "Wang, Jian J" , "Wu, Hao A" , "Ma, Maurice" , "Dong, Guo" , "You, Benjamin" , Meenakshi Aggarwal , Varun Sethi , Samer El-Haj-Mahmoud Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support Message-ID: <20200330073518.GU22097@bivouac.eciton.net> References: <20200219133135.10407-1-pankaj.bansal@oss.nxp.com> <20200219133135.10407-2-pankaj.bansal@oss.nxp.com> <734D49CCEBEEF84792F5B80ED585239D5C4A0C2C@SHSMSX104.ccr.corp.intel.com> <20200319153057.GV23627@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Jiang, It is not a question of effort of copying a driver, it is a question that copying drivers is something that should be avoided wherever practically possible. I did not think this topic was still under debate. If the existing 16550 SerialPortLib is overspecialised to the point where it only works on a subset of 16550 implementations, then it should change. There are going to be more non-PC systems turning up with 16550 UARTs - should they each copy/modify their drivers? If there are better ways of solving that problem, please suggest. But more duplicated drivers is not the answer. / Leif On Mon, Mar 30, 2020 at 01:20:03 +0000, Jiang, Guomin wrote: > Hi Pankaj, > > I know your consideration. > > My consideration is that we provide an interface, it should be > better for user, it not, the user won't use it and if no nobody use > it, why provide it? > In other word, the effort for copying the SerialPortLib and the > effort for implementing SerialUartClockLib are same, why consumer > should learn the new interface? > > Thanks. > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Pankaj Bansal > > Sent: Saturday, March 28, 2020 8:37 PM > > To: Jiang, Guomin ; devel@edk2.groups.io; Pankaj > > Bansal ; Leif Lindholm ; Ni, > > Ray ; Ard Biesheuvel > > Cc: Wang, Jian J ; Wu, Hao A > > ; Ma, Maurice ; Dong, Guo > > ; You, Benjamin ; > > Meenakshi Aggarwal ; Varun Sethi > > ; Samer El-Haj-Mahmoud > Mahmoud@arm.com> > > Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock > > freq Support > > > > Hello Jiang, > > > > > -----Original Message----- > > > From: Jiang, Guomin > > > Sent: Thursday, March 26, 2020 7:44 PM > > > To: devel@edk2.groups.io; Pankaj Bansal ; Leif > > > Lindholm ; Ni, Ray > > > Cc: Pankaj Bansal (OSS) ; Wang, Jian J > > > ; Wu, Hao A ; Ma, Maurice > > > ; Dong, Guo ; You, > > Benjamin > > > ; Meenakshi Aggarwal > > > ; Varun Sethi > > > Subject: RE: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic > > clock > > > freq Support > > > > > > It is a good idea, > > > > > > I have a question: > > > 1. When can detect the jumper signal or register? > > -> This depends on platform. Ideally as early as possible in boot > > process (in SEC phase), because PEI Core and onwards, all modules start > > making call to DebugLib constructor. > > > 2. If the jumper use GPIO, SerialUartClockLib will depend on GpioLib? > > -> Yes, SerialUartClockLib can depend on other libraries as well. E.g. in > > https://edk2.groups.io/g/devel/message/56009, SerialUartClockLib depends > > on ArmPlatformLib > > > 3. If the register is inside SIO, how to dispose the dependence? > > -> I did not understand term SIO. Quick google search throws up Intel > > Serial IO host controller driver. Intel Serial IO driver is required if you plan to > > use the I2C, UART, or GPIO host controllers. > > Is that what you are referring to ? I assume you mean that what > > happens if the SerialUartClockLib, tries to read registers that require > > SerialPortLib ? i.e. circular dependency i.e deadlock ? > > In that case, some kind of intervention is required on Platform > > owner part. May be implement a version of SerialUartClockLib for SEC phase > > that doesn't depend on SerialPortLib, which lets > > the serial port to initialize. For all other module types, implement > > another version of SerialUartClockLib. > > > > > > If it is too complex to implement the SerialUartClockLib, the project > > > owner will choose use BaseSerialUartClockLib rather implement it. and > > > in this case, it make no sense after import complexity. > > > > Complexity is platform specific. We have implemented > > BaseSerialUartClockLib in https://edk2.groups.io/g/devel/message/56009. > > > > > > > > I have also reviewed the ArmPlatformPkg/Library/PL011UartClockLib > > > code, it still use the fixed data rather than dynamically detect clock. > > > > Right. As I said, making PcdSerialClockRate as Dynamic PCD, we cannot use > > this in modules for which PcdLib is BasePcdLibNull. > > It results in ASSERT. > > > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of > > > > Pankaj Bansal > > > > Sent: Monday, March 23, 2020 1:31 PM > > > > To: Leif Lindholm ; Ni, Ray > > > > Cc: Pankaj Bansal (OSS) ; Wang, Jian J > > > > ; Wu, Hao A ; Ma, > > Maurice > > > > ; Dong, Guo ; You, > > > > Benjamin ; Meenakshi Aggarwal > > > > ; Varun Sethi ; > > > > devel@edk2.groups.io > > > > Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic > > > > clock freq Support > > > > > > > > Hi Ray, > > > > > > > > I had thought of making PcdSerialClockRate as Dynamic PCD I had made > > > > changes for it too. > > > > But it doesn't work. > > > > SerialPortInitalize, which uses PcdSerialClockRate, gets called from > > > > DebugLib constructor. > > > > DebugLib is used by every module to print any info onto console. > > > > For DxeCore and PcdDxe, for which PcdLib instance is NULL, this > > > > results in Assert : > > > > > > > > > > https://github.com/tianocore/edk2/blob/master/MdePkg/Library/BasePcd > > > > Li > > > > bNull/PcdLib.c#L123 > > > > > > > > The other approach that I thought of was, to copy > > > > BaseSerialPortLib16550 for our platform and simply return EFI_SUCCESS > > from SerialPortInitalize. > > > > But as Leif pointed out, this results in code duplication. > > > > > > > > Regards, > > > > Pankaj Bansal > > > > > > > > > -----Original Message----- > > > > > From: Leif Lindholm > > > > > Sent: Thursday, March 19, 2020 9:01 PM > > > > > To: Ni, Ray > > > > > Cc: Pankaj Bansal (OSS) ; Wang, Jian J > > > > > ; Wu, Hao A ; Ma, > > > > > Maurice ; Dong, Guo ; > > > > > You, > > > > Benjamin > > > > > ; Meenakshi Aggarwal > > > > > ; Varun Sethi ; > > > > > devel@edk2.groups.io; Pankaj Bansal > > > > > Subject: Re: [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq > > > > Support > > > > > > > > > > Hi Ray, > > > > > > > > > > I agree it would be nice, but if not - this lets us get rid of > > > > > otherwise needless driver duplication. To me, that makes it worth > > > > > a little trivial churn. > > > > > > > > > > / > > > > > Leif > > > > > > > > > > On Thu, Mar 19, 2020 at 15:09:19 +0000, Ni, Ray wrote: > > > > > > It seems this change requires all platforms DSC to include the > > > > > > new library > > > > > class/instance. > > > > > > > > > > > > Is there a way that can avoid the platform impact? > > > > > > > > > > > > Thanks, > > > > > > Ray > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Pankaj Bansal > > > > > > > Sent: Wednesday, February 19, 2020 9:32 PM > > > > > > > To: Wang, Jian J ; Wu, Hao A > > > > > ; Ni, Ray ; Ma, Maurice > > > > > > > ; Dong, Guo ; You, > > > > > Benjamin ; Leif Lindholm > > > > > > > ; Meenakshi Aggarwal > > > > > ; Varun Sethi > > > > > > > Cc: devel@edk2.groups.io; Pankaj Bansal > > > > > > > > > > > > > > Subject: [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq > > > > Support > > > > > > > > > > > > > > From: Pankaj Bansal > > > > > > > > > > > > > > Some platform support dynamic clocking, which is controlled by > > > > > > > some jumper setting or hardware registers. Result of that is > > > > > > > that PCD PcdSerialClockRate would need to be updated for > > > > > > > frequency > > > > change. > > > > > > > > > > > > > > This patch implements support for dynamic frequency for Uart. > > > > > > > > > > > > > > This patch implements default lib, which is using Pcd. > > > > > > > Platform which needs dynamic clocking needs implement > > > > > > > SerialUartClockLib > > > > > > > > > > > > > > This patch is based on > > > > > > > ArmPlatformPkg/Library/PL011UartClockLib > > > > > > > > > > > > > > Signed-off-by: Pankaj Bansal > > > > > > > --- > > > > > > > .../Include/Library/SerialUartClockLib.h | 21 +++++++++++++++ > > > > > > > .../BaseSerialPortLib16550.c | 9 ++++--- > > > > > > > .../BaseSerialPortLib16550.inf | 2 +- > > > > > > > .../BaseSerialUartClockLib.c | 24 +++++++++++++++++ > > > > > > > .../BaseSerialUartClockLib.inf | 27 +++++++++++++++++++ > > > > > > > MdeModulePkg/MdeModulePkg.dsc | 2 ++ > > > > > > > SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 1 + > > > > > > > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 1 + > > > > > > > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 + > > > > > > > 9 files changed, 83 insertions(+), 5 deletions(-) create > > > > > > > mode > > > > > > > 100644 MdeModulePkg/Include/Library/SerialUartClockLib.h > > > > > > > create mode 100644 > > > > > MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib > > > > > .c > > > > > > > create mode 100644 > > > > > MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib > > > > > .inf > > > > > > > > > > > > > > diff --git a/MdeModulePkg/Include/Library/SerialUartClockLib.h > > > > > b/MdeModulePkg/Include/Library/SerialUartClockLib.h > > > > > > > new file mode 100644 > > > > > > > index 000000000000..b6b16f71d4cf > > > > > > > --- /dev/null > > > > > > > +++ b/MdeModulePkg/Include/Library/SerialUartClockLib.h > > > > > > > @@ -0,0 +1,21 @@ > > > > > > > +/** @file > > > > > > > +* > > > > > > > +* Copyright 2020 NXP > > > > > > > +* > > > > > > > +* SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > > +* > > > > > > > +**/ > > > > > > > + > > > > > > > +#ifndef SERIAL_UART_CLOCK_LIB_H__ #define > > > > > > > +SERIAL_UART_CLOCK_LIB_H__ > > > > > > > + > > > > > > > +/** > > > > > > > + Return clock in for Uart IP **/ > > > > > > > +UINT32 > > > > > > > +EFIAPI > > > > > > > +BaseSerialPortGetClock ( > > > > > > > + VOID > > > > > > > + ); > > > > > > > + > > > > > > > +#endif > > > > > > > diff --git > > > > > > > > > > > a/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550 > > > > .c > > > > > > > > > > > b/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib165 > > > > > > > 50.c index 9cb50dd80d56..2e0c05d5789e 100644 > > > > > > > --- > > > > > > > > > > > a/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550 > > > > .c > > > > > > > +++ > > > > > > > > > > > b/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550 > > > > .c > > > > > > > @@ -16,6 +16,7 @@ > > > > > > > #include > > > > > > > #include > > > > > > > #include > > > > > > > +#include > > > > > > > #include > > > > > > > > > > > > > > // > > > > > > > @@ -501,8 +502,8 @@ SerialPortInitialize ( > > > > > > > // Calculate divisor for baud generator > > > > > > > // Ref_Clk_Rate / Baud_Rate / 16 > > > > > > > // > > > > > > > - Divisor = PcdGet32 (PcdSerialClockRate) / (PcdGet32 > > > > > > > (PcdSerialBaudRate) * > > > > > 16); > > > > > > > - if ((PcdGet32 (PcdSerialClockRate) % (PcdGet32 > > > > > > > (PcdSerialBaudRate) * > > > > > 16)) >= PcdGet32 (PcdSerialBaudRate) * 8) { > > > > > > > + Divisor = BaseSerialPortGetClock () / (PcdGet32 > > > > > > > + (PcdSerialBaudRate) * 16); if ((BaseSerialPortGetClock () % > > > > > > > + (PcdGet32 (PcdSerialBaudRate) * 16)) >= > > > > > PcdGet32 (PcdSerialBaudRate) * 8) { > > > > > > > Divisor++; > > > > > > > } > > > > > > > > > > > > > > @@ -1080,8 +1081,8 @@ SerialPortSetAttributes ( > > > > > > > // Calculate divisor for baud generator > > > > > > > // Ref_Clk_Rate / Baud_Rate / 16 > > > > > > > // > > > > > > > - Divisor = PcdGet32 (PcdSerialClockRate) / (SerialBaudRate * > > > > > > > 16); > > > > > > > - if ((PcdGet32 (PcdSerialClockRate) % (SerialBaudRate * 16)) > > > > > > > >= > > > > > SerialBaudRate * 8) { > > > > > > > + Divisor = BaseSerialPortGetClock () / (SerialBaudRate * > > > > > > > + 16); if ((BaseSerialPortGetClock () % (SerialBaudRate * 16)) > > > > > > > + >= SerialBaudRate * > > > > > 8) { > > > > > > > Divisor++; > > > > > > > } > > > > > > > > > > > > > > diff --git > > > > > a/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib165 > > > > > 50.i > > > > > nf > > > > > > > > > > > > > > b/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib165 > > > > > 50.i > > > > > nf > > > > > > > index 8b4ae3f1d4ee..b4c16504f211 100644 > > > > > > > --- > > > > > a/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib165 > > > > > 50.i > > > > > nf > > > > > > > +++ > > > > > > > b/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib165 > > > > > 50.i > > > > > nf > > > > > > > @@ -24,6 +24,7 @@ [LibraryClasses] > > > > > > > IoLib > > > > > > > PlatformHookLib > > > > > > > PciLib > > > > > > > + SerialUartClockLib > > > > > > > > > > > > > > [Sources] > > > > > > > BaseSerialPortLib16550.c > > > > > > > @@ -37,7 +38,6 @@ [Pcd] > > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate ## > > > > > CONSUMES > > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialLineControl > > ## > > > > > CONSUMES > > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialFifoControl ## > > > > > CONSUMES > > > > > > > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialClockRate ## > > > > > CONSUMES > > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialPciDeviceInfo > > ## > > > > > CONSUMES > > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialExtendedTxFifoSize > > > > ## > > > > > CONSUMES > > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride > > ## > > > > > CONSUMES > > > > > > > diff --git > > > > > a/MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockL > > > > > ib.c > > > > > > > b/MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartCl > > > > > > > ockL > > > > > > > ib.c > > > > > > > new file mode 100644 > > > > > > > index 000000000000..7a0d0427cc4e > > > > > > > --- /dev/null > > > > > > > +++ > > > > > b/MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockL > > > > > ib.c > > > > > > > @@ -0,0 +1,24 @@ > > > > > > > +/** @file > > > > > > > +* > > > > > > > +* Copyright 2020 NXP > > > > > > > +* > > > > > > > +* SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > > +* > > > > > > > +**/ > > > > > > > + > > > > > > > +#include > > > > > > > +#include > > > > > > > + > > > > > > > +/** > > > > > > > + Return clock in for Uart IP > > > > > > > + > > > > > > > + @return Pcd PcdSerialClockRate **/ > > > > > > > +UINT32 > > > > > > > +EFIAPI > > > > > > > +BaseSerialPortGetClock ( > > > > > > > + VOID > > > > > > > + ) > > > > > > > +{ > > > > > > > + return PcdGet32 (PcdSerialClockRate); } > > > > > > > diff --git > > > > > a/MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockL > > > > > ib.i > > > > > nf > > > > > > > > > > > > b/MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockL > > > > > ib.i > > > > > nf > > > > > > > new file mode 100644 > > > > > > > index 000000000000..91ba69436ed6 > > > > > > > --- /dev/null > > > > > > > +++ > > > > > b/MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockL > > > > > ib.i > > > > > nf > > > > > > > @@ -0,0 +1,27 @@ > > > > > > > +#/* @file > > > > > > > +# Copyright 2020 NXP > > > > > > > +# > > > > > > > +# SPDX-License-Identifier: BSD-2-Clause-Patent # #*/ > > > > > > > + > > > > > > > +[Defines] > > > > > > > + INF_VERSION = 0x0001001A > > > > > > > + BASE_NAME = BaseSerialUartClockLib > > > > > > > + FILE_GUID = fa65495e-d3c8-4ea3-9737-994e9ccbaf11 > > > > > > > + MODULE_TYPE = BASE > > > > > > > + VERSION_STRING = 1.0 > > > > > > > + LIBRARY_CLASS = SerialUartClockLib > > > > > > > + > > > > > > > +[Packages] > > > > > > > + MdePkg/MdePkg.dec > > > > > > > + MdeModulePkg/MdeModulePkg.dec > > > > > > > + > > > > > > > +[Sources.common] > > > > > > > + BaseSerialUartClockLib.c > > > > > > > + > > > > > > > +[LibraryClasses] > > > > > > > + PcdLib > > > > > > > + > > > > > > > +[Pcd] > > > > > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialClockRate > > ## > > > > > CONSUMES > > > > > > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > > > > > b/MdeModulePkg/MdeModulePkg.dsc > > > > > > > index f7dbb27ce25d..d581ca797b3b 100644 > > > > > > > --- a/MdeModulePkg/MdeModulePkg.dsc > > > > > > > +++ b/MdeModulePkg/MdeModulePkg.dsc > > > > > > > @@ -65,6 +65,7 @@ [LibraryClasses] > > > > > > > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > > > > > > > > > > > > > > > > > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementL > > > > ib/D > > > > > xeSecurityManagementLib.inf > > > > > > > > > > > > > > > > > > TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTem > > > > pl > > > > > TimerLib|at > > > > > e.inf > > > > > > > + > > > > > > > > > SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseS > > > > SerialUartClockLib|er > > > > > SerialUartClockLib|ialU > > > > > artClockLib.inf > > > > > > > > > > > > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortL > > > > > SerialPortLib|ibNu > > > > > SerialPortLib|ll.inf > > > > > > > > > > > > > > > > > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull. > > > > CapsuleLib|i > > > > n > > > > > CapsuleLib|f > > > > > > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > > > > > > @@ -292,6 +293,7 @@ [Components] > > > > > > > > > > > > > > > > > > MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib. > > > > inf > > > > > > > > > > > > > > > > > > MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeRep > > > > ortSt > > > > > atusCodeLib.inf > > > > > > > > > > > > > > > > > > MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.i > > > > nf > > > > > > > + > > > > > MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib > > > > > .inf > > > > > > > > > > > > > > MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550 > > > > > .inf > > > > > > > > > > > > > > > > > > MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull > > > > .i > > > > > nf > > > > > > > > > > > > > > > > > > MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLe > > > > ve > > > > > lLi > > > > > b.inf > > > > > > > diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc > > > > > b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc > > > > > > > index a1a1b81d03cb..c0ad88f26341 100644 > > > > > > > --- a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc > > > > > > > +++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc > > > > > > > @@ -33,6 +33,7 @@ [LibraryClasses.common] > > > > > > > > > > > > > > > > > > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchro > > > > SynchronizationLib|ni > > > > > SynchronizationLib|zati > > > > > onLib.inf > > > > > > > > > > > > > > LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf > > > > > > > > > > > > > > > > > > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Bas > > > > PeCoffGetEntryPointLib|e > > > > P > > > > > PeCoffGetEntryPointLib|eC > > > > > offGetEntryPointLib.inf > > > > > > > + > > > > > > > > > SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseS > > > > SerialUartClockLib|er > > > > > SerialUartClockLib|ialU > > > > > artClockLib.inf > > > > > > > > > > > > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSeri > > > > > SerialPortLib|alPo > > > > > SerialPortLib|rtLib > > > > > 16550.inf > > > > > > > > > > > > > > > > PeCoffExtraActionLib|SourceLevelDebugPkg/Library/PeCoffExtraActionLi > > > > PeCoffExtraActionLib|bD > > > > > PeCoffExtraActionLib|ebu > > > > > g/PeCoffExtraActionLibDebug.inf > > > > > > > > > > > > > > > > > > TimerLib|UefiCpuPkg/Library/SecPeiDxeTimerLibUefiCpu/SecPeiDxeTimerL > > > > TimerLib|i > > > > b > > > > > TimerLib|Ue > > > > > fiCpu.inf > > > > > > > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > > > > > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > > > > > > > index d52945442e0e..a556a32b272c 100644 > > > > > > > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > > > > > > > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > > > > > > > @@ -174,6 +174,7 @@ [LibraryClasses] > > > > > > > # > > > > > > > > > > > > > > TimerLib|UefiPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.inf > > > > > > > > > > > > > > > > > > ResetSystemLib|UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib. > > > > ResetSystemLib|in > > > > > ResetSystemLib|f > > > > > > > + > > > > > > > > > SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseS > > > > SerialUartClockLib|er > > > > > SerialUartClockLib|ialU > > > > > artClockLib.inf > > > > > > > > > > > > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSeri > > > > > SerialPortLib|alPo > > > > > SerialPortLib|rtLib > > > > > 16550.inf > > > > > > > > > > > > > > > > > > PlatformHookLib|UefiPayloadPkg/Library/PlatformHookLib/PlatformHookL > > > > PlatformHookLib|ib > > > > > PlatformHookLib|.in > > > > > f > > > > > > > > > > > > > > > > > > PlatformBootManagerLib|UefiPayloadPkg/Library/PlatformBootManagerLib > > > > PlatformBootManagerLib|/ > > > > P > > > > > PlatformBootManagerLib|l > > > > > atformBootManagerLib.inf > > > > > > > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > > > > > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > > > > > > > index 0736cd995476..7e86375fe57d 100644 > > > > > > > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > > > > > > > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > > > > > > > @@ -175,6 +175,7 @@ [LibraryClasses] > > > > > > > # > > > > > > > > > > > > > > TimerLib|UefiPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.inf > > > > > > > > > > > > > > > > > > ResetSystemLib|UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib. > > > > ResetSystemLib|in > > > > > ResetSystemLib|f > > > > > > > + > > > > > > > > > SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseS > > > > SerialUartClockLib|er > > > > > SerialUartClockLib|ialU > > > > > artClockLib.inf > > > > > > > > > > > > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSeri > > > > > SerialPortLib|alPo > > > > > SerialPortLib|rtLib > > > > > 16550.inf > > > > > > > > > > > > > > > > > > PlatformHookLib|UefiPayloadPkg/Library/PlatformHookLib/PlatformHookL > > > > PlatformHookLib|ib > > > > > PlatformHookLib|.in > > > > > f > > > > > > > > > > > > > > > > > > PlatformBootManagerLib|UefiPayloadPkg/Library/PlatformBootManagerLib > > > > PlatformBootManagerLib|/ > > > > P > > > > > PlatformBootManagerLib|l > > > > > atformBootManagerLib.inf > > > > > > > -- > > > > > > > 2.17.1 > > > > > > > > > > > > > > > > > > > > >