public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io
Cc: Pierre Gondois <Pierre.Gondois@arm.com>,
	michael.d.kinney@intel.com, liming.gao@intel.com,
	Sami.Mujawar@arm.com, nd@arm.com
Subject: [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
Date: Mon, 30 Mar 2020 09:52:38 +0100	[thread overview]
Message-ID: <20200330085238.43376-1-pierre.gondois@arm.com> (raw)

From: Pierre Gondois <pierre.gondois@arm.com>

The ACPI specification, version 6.3, January 2019,
defines the Named Objects Encoding for FieldElements
in section '20.2.5.2 Named Objects Encoding'.
FieldElements can be one of the following:
NamedField | ReservedField | AccessField |
ExtendedAccessField | ConnectField

Some of these keywords are starting with an opcode,
allowing to identify their type.
E.g.: ReservedField := 0x00 PkgLength

This patch adds these FieldElement opcodes definitions to
the list of AML Opcode definitions.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---

The changes can be seen at https://github.com/PierreARM/edk2/commits/695_Add_FieldElement_OpCode_v1

Notes:
    v1:
     - Add AML Field Element OpCodes [Pierre]

 MdePkg/Include/IndustryStandard/AcpiAml.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/MdePkg/Include/IndustryStandard/AcpiAml.h b/MdePkg/Include/IndustryStandard/AcpiAml.h
index 3dd5408b359f9192e2fa9cedd0260a0f6bb5603a..74622e912ea42c2a04379362843473cac5ea5856 100644
--- a/MdePkg/Include/IndustryStandard/AcpiAml.h
+++ b/MdePkg/Include/IndustryStandard/AcpiAml.h
@@ -168,4 +168,12 @@
 #define AML_EXT_BANK_FIELD_OP        0x87
 #define AML_EXT_DATA_REGION_OP       0x88
 
+//
+// FieldElement OpCode
+//
+#define AML_FIELD_RESERVED_OP        0x00
+#define AML_FIELD_ACCESS_OP          0x01
+#define AML_FIELD_CONNECTION_OP      0x02
+#define AML_FIELD_EXT_ACCESS_OP      0x03
+
 #endif
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


             reply	other threads:[~2020-03-30  8:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-30  8:52 PierreGondois [this message]
2020-04-10  1:43 ` [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions Zhiguang Liu
2020-04-10  3:19   ` Liming Gao
2020-04-10  7:46     ` Sami Mujawar
2020-04-20 18:26     ` PierreGondois
2020-04-20 23:13       ` Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200330085238.43376-1-pierre.gondois@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox