* [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
@ 2020-03-30 8:52 PierreGondois
2020-04-10 1:43 ` [edk2-devel] " Zhiguang Liu
0 siblings, 1 reply; 6+ messages in thread
From: PierreGondois @ 2020-03-30 8:52 UTC (permalink / raw)
To: devel; +Cc: Pierre Gondois, michael.d.kinney, liming.gao, Sami.Mujawar, nd
From: Pierre Gondois <pierre.gondois@arm.com>
The ACPI specification, version 6.3, January 2019,
defines the Named Objects Encoding for FieldElements
in section '20.2.5.2 Named Objects Encoding'.
FieldElements can be one of the following:
NamedField | ReservedField | AccessField |
ExtendedAccessField | ConnectField
Some of these keywords are starting with an opcode,
allowing to identify their type.
E.g.: ReservedField := 0x00 PkgLength
This patch adds these FieldElement opcodes definitions to
the list of AML Opcode definitions.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
The changes can be seen at https://github.com/PierreARM/edk2/commits/695_Add_FieldElement_OpCode_v1
Notes:
v1:
- Add AML Field Element OpCodes [Pierre]
MdePkg/Include/IndustryStandard/AcpiAml.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/AcpiAml.h b/MdePkg/Include/IndustryStandard/AcpiAml.h
index 3dd5408b359f9192e2fa9cedd0260a0f6bb5603a..74622e912ea42c2a04379362843473cac5ea5856 100644
--- a/MdePkg/Include/IndustryStandard/AcpiAml.h
+++ b/MdePkg/Include/IndustryStandard/AcpiAml.h
@@ -168,4 +168,12 @@
#define AML_EXT_BANK_FIELD_OP 0x87
#define AML_EXT_DATA_REGION_OP 0x88
+//
+// FieldElement OpCode
+//
+#define AML_FIELD_RESERVED_OP 0x00
+#define AML_FIELD_ACCESS_OP 0x01
+#define AML_FIELD_CONNECTION_OP 0x02
+#define AML_FIELD_EXT_ACCESS_OP 0x03
+
#endif
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
2020-03-30 8:52 [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions PierreGondois
@ 2020-04-10 1:43 ` Zhiguang Liu
2020-04-10 3:19 ` Liming Gao
0 siblings, 1 reply; 6+ messages in thread
From: Zhiguang Liu @ 2020-04-10 1:43 UTC (permalink / raw)
To: devel@edk2.groups.io, pierre.gondois@arm.com
Cc: Kinney, Michael D, Gao, Liming, Sami.Mujawar@arm.com, nd@arm.com
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of PierreGondois
Sent: Monday, March 30, 2020 4:53 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois <Pierre.Gondois@arm.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Sami.Mujawar@arm.com; nd@arm.com
Subject: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
From: Pierre Gondois <pierre.gondois@arm.com>
The ACPI specification, version 6.3, January 2019,
defines the Named Objects Encoding for FieldElements
in section '20.2.5.2 Named Objects Encoding'.
FieldElements can be one of the following:
NamedField | ReservedField | AccessField |
ExtendedAccessField | ConnectField
Some of these keywords are starting with an opcode,
allowing to identify their type.
E.g.: ReservedField := 0x00 PkgLength
This patch adds these FieldElement opcodes definitions to
the list of AML Opcode definitions.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
The changes can be seen at https://github.com/PierreARM/edk2/commits/695_Add_FieldElement_OpCode_v1
Notes:
v1:
- Add AML Field Element OpCodes [Pierre]
MdePkg/Include/IndustryStandard/AcpiAml.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/AcpiAml.h b/MdePkg/Include/IndustryStandard/AcpiAml.h
index 3dd5408b359f9192e2fa9cedd0260a0f6bb5603a..74622e912ea42c2a04379362843473cac5ea5856 100644
--- a/MdePkg/Include/IndustryStandard/AcpiAml.h
+++ b/MdePkg/Include/IndustryStandard/AcpiAml.h
@@ -168,4 +168,12 @@
#define AML_EXT_BANK_FIELD_OP 0x87
#define AML_EXT_DATA_REGION_OP 0x88
+//
+// FieldElement OpCode
+//
+#define AML_FIELD_RESERVED_OP 0x00
+#define AML_FIELD_ACCESS_OP 0x01
+#define AML_FIELD_CONNECTION_OP 0x02
+#define AML_FIELD_EXT_ACCESS_OP 0x03
+
#endif
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
2020-04-10 1:43 ` [edk2-devel] " Zhiguang Liu
@ 2020-04-10 3:19 ` Liming Gao
2020-04-10 7:46 ` Sami Mujawar
2020-04-20 18:26 ` PierreGondois
0 siblings, 2 replies; 6+ messages in thread
From: Liming Gao @ 2020-04-10 3:19 UTC (permalink / raw)
To: Liu, Zhiguang, devel@edk2.groups.io, pierre.gondois@arm.com
Cc: Kinney, Michael D, Sami.Mujawar@arm.com, nd@arm.com
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Friday, April 10, 2020 9:44 AM
> To: devel@edk2.groups.io; pierre.gondois@arm.com
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Sami.Mujawar@arm.com; nd@arm.com
> Subject: RE: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
>
> Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of PierreGondois
> Sent: Monday, March 30, 2020 4:53 PM
> To: devel@edk2.groups.io
> Cc: Pierre Gondois <Pierre.Gondois@arm.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Sami.Mujawar@arm.com; nd@arm.com
> Subject: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
>
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> The ACPI specification, version 6.3, January 2019,
> defines the Named Objects Encoding for FieldElements
> in section '20.2.5.2 Named Objects Encoding'.
> FieldElements can be one of the following:
> NamedField | ReservedField | AccessField |
> ExtendedAccessField | ConnectField
>
> Some of these keywords are starting with an opcode,
> allowing to identify their type.
> E.g.: ReservedField := 0x00 PkgLength
>
> This patch adds these FieldElement opcodes definitions to
> the list of AML Opcode definitions.
>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
>
> The changes can be seen at https://github.com/PierreARM/edk2/commits/695_Add_FieldElement_OpCode_v1
>
> Notes:
> v1:
> - Add AML Field Element OpCodes [Pierre]
>
> MdePkg/Include/IndustryStandard/AcpiAml.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/AcpiAml.h b/MdePkg/Include/IndustryStandard/AcpiAml.h
> index 3dd5408b359f9192e2fa9cedd0260a0f6bb5603a..74622e912ea42c2a04379362843473cac5ea5856 100644
> --- a/MdePkg/Include/IndustryStandard/AcpiAml.h
> +++ b/MdePkg/Include/IndustryStandard/AcpiAml.h
> @@ -168,4 +168,12 @@
> #define AML_EXT_BANK_FIELD_OP 0x87
> #define AML_EXT_DATA_REGION_OP 0x88
>
> +//
> +// FieldElement OpCode
> +//
> +#define AML_FIELD_RESERVED_OP 0x00
> +#define AML_FIELD_ACCESS_OP 0x01
> +#define AML_FIELD_CONNECTION_OP 0x02
> +#define AML_FIELD_EXT_ACCESS_OP 0x03
> +
> #endif
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
2020-04-10 3:19 ` Liming Gao
@ 2020-04-10 7:46 ` Sami Mujawar
2020-04-20 18:26 ` PierreGondois
1 sibling, 0 replies; 6+ messages in thread
From: Sami Mujawar @ 2020-04-10 7:46 UTC (permalink / raw)
To: Gao, Liming, devel
[-- Attachment #1: Type: text/plain, Size: 78 bytes --]
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
[-- Attachment #2: Type: text/html, Size: 100 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
2020-04-10 3:19 ` Liming Gao
2020-04-10 7:46 ` Sami Mujawar
@ 2020-04-20 18:26 ` PierreGondois
2020-04-20 23:13 ` Liming Gao
1 sibling, 1 reply; 6+ messages in thread
From: PierreGondois @ 2020-04-20 18:26 UTC (permalink / raw)
To: devel@edk2.groups.io, liming.gao@intel.com, Liu, Zhiguang
Cc: Kinney, Michael D, Sami Mujawar, nd
Hello everyone,
Just to push the patch forward a bit: the patch has received reviewed-by from Liming Gao, Zhiguang Liu and Sami Mujawar,
Regards,
Pierre
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao via groups.io
Sent: Friday, April 10, 2020 4:19 AM
To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io; Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sami Mujawar <Sami.Mujawar@arm.com>; nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Friday, April 10, 2020 9:44 AM
> To: devel@edk2.groups.io; pierre.gondois@arm.com
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Sami.Mujawar@arm.com; nd@arm.com
> Subject: RE: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList
> OpCode definitions
>
> Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> PierreGondois
> Sent: Monday, March 30, 2020 4:53 PM
> To: devel@edk2.groups.io
> Cc: Pierre Gondois <Pierre.Gondois@arm.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Sami.Mujawar@arm.com; nd@arm.com
> Subject: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode
> definitions
>
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> The ACPI specification, version 6.3, January 2019, defines the Named
> Objects Encoding for FieldElements in section '20.2.5.2 Named Objects
> Encoding'.
> FieldElements can be one of the following:
> NamedField | ReservedField | AccessField | ExtendedAccessField |
> ConnectField
>
> Some of these keywords are starting with an opcode, allowing to
> identify their type.
> E.g.: ReservedField := 0x00 PkgLength
>
> This patch adds these FieldElement opcodes definitions to the list of
> AML Opcode definitions.
>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
>
> The changes can be seen at
> https://github.com/PierreARM/edk2/commits/695_Add_FieldElement_OpCode_
> v1
>
> Notes:
> v1:
> - Add AML Field Element OpCodes [Pierre]
>
> MdePkg/Include/IndustryStandard/AcpiAml.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/AcpiAml.h
> b/MdePkg/Include/IndustryStandard/AcpiAml.h
> index
> 3dd5408b359f9192e2fa9cedd0260a0f6bb5603a..74622e912ea42c2a043793628434
> 73cac5ea5856 100644
> --- a/MdePkg/Include/IndustryStandard/AcpiAml.h
> +++ b/MdePkg/Include/IndustryStandard/AcpiAml.h
> @@ -168,4 +168,12 @@
> #define AML_EXT_BANK_FIELD_OP 0x87
> #define AML_EXT_DATA_REGION_OP 0x88
>
> +//
> +// FieldElement OpCode
> +//
> +#define AML_FIELD_RESERVED_OP 0x00
> +#define AML_FIELD_ACCESS_OP 0x01
> +#define AML_FIELD_CONNECTION_OP 0x02
> +#define AML_FIELD_EXT_ACCESS_OP 0x03
> +
> #endif
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
2020-04-20 18:26 ` PierreGondois
@ 2020-04-20 23:13 ` Liming Gao
0 siblings, 0 replies; 6+ messages in thread
From: Liming Gao @ 2020-04-20 23:13 UTC (permalink / raw)
To: devel@edk2.groups.io, pierre.gondois@arm.com, Liu, Zhiguang,
Dong, Eric
Cc: Kinney, Michael D, Sami Mujawar, nd
It has been merged. https://github.com/tianocore/edk2/pull/521
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of PierreGondois
Sent: 2020年4月21日 2:27
To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sami Mujawar <Sami.Mujawar@arm.com>; nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
Hello everyone,
Just to push the patch forward a bit: the patch has received reviewed-by from Liming Gao, Zhiguang Liu and Sami Mujawar,
Regards,
Pierre
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao via groups.io
Sent: Friday, April 10, 2020 4:19 AM
To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io; Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sami Mujawar <Sami.Mujawar@arm.com>; nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Friday, April 10, 2020 9:44 AM
> To: devel@edk2.groups.io; pierre.gondois@arm.com
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Sami.Mujawar@arm.com; nd@arm.com
> Subject: RE: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList
> OpCode definitions
>
> Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> PierreGondois
> Sent: Monday, March 30, 2020 4:53 PM
> To: devel@edk2.groups.io
> Cc: Pierre Gondois <Pierre.Gondois@arm.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Sami.Mujawar@arm.com; nd@arm.com
> Subject: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode
> definitions
>
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> The ACPI specification, version 6.3, January 2019, defines the Named
> Objects Encoding for FieldElements in section '20.2.5.2 Named Objects
> Encoding'.
> FieldElements can be one of the following:
> NamedField | ReservedField | AccessField | ExtendedAccessField |
> ConnectField
>
> Some of these keywords are starting with an opcode, allowing to
> identify their type.
> E.g.: ReservedField := 0x00 PkgLength
>
> This patch adds these FieldElement opcodes definitions to the list of
> AML Opcode definitions.
>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
>
> The changes can be seen at
> https://github.com/PierreARM/edk2/commits/695_Add_FieldElement_OpCode_
> v1
>
> Notes:
> v1:
> - Add AML Field Element OpCodes [Pierre]
>
> MdePkg/Include/IndustryStandard/AcpiAml.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/AcpiAml.h
> b/MdePkg/Include/IndustryStandard/AcpiAml.h
> index
> 3dd5408b359f9192e2fa9cedd0260a0f6bb5603a..74622e912ea42c2a043793628434
> 73cac5ea5856 100644
> --- a/MdePkg/Include/IndustryStandard/AcpiAml.h
> +++ b/MdePkg/Include/IndustryStandard/AcpiAml.h
> @@ -168,4 +168,12 @@
> #define AML_EXT_BANK_FIELD_OP 0x87
> #define AML_EXT_DATA_REGION_OP 0x88
>
> +//
> +// FieldElement OpCode
> +//
> +#define AML_FIELD_RESERVED_OP 0x00
> +#define AML_FIELD_ACCESS_OP 0x01
> +#define AML_FIELD_CONNECTION_OP 0x02
> +#define AML_FIELD_EXT_ACCESS_OP 0x03
> +
> #endif
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-20 23:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-30 8:52 [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions PierreGondois
2020-04-10 1:43 ` [edk2-devel] " Zhiguang Liu
2020-04-10 3:19 ` Liming Gao
2020-04-10 7:46 ` Sami Mujawar
2020-04-20 18:26 ` PierreGondois
2020-04-20 23:13 ` Liming Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox