* [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.
@ 2020-03-31 6:49 Guomin Jiang
0 siblings, 0 replies; only message in thread
From: Guomin Jiang @ 2020-03-31 6:49 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Sean Brogan, Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2609
The copied pointer (SavedState) will be updated by LoadUnitTestCache
call. But the change of SavedState will not update source pointer, which
is NewFramework->SavedState in this case.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
---
UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
index b136992d99..71050b5618 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
@@ -209,7 +209,7 @@ InitUnitTestFramework (
EFI_STATUS Status;
UNIT_TEST_FRAMEWORK_HANDLE NewFrameworkHandle;
UNIT_TEST_FRAMEWORK *NewFramework;
- UNIT_TEST_SAVE_HEADER *SavedState;
+ UNIT_TEST_SAVE_HEADER **SavedState;
Status = EFI_SUCCESS;
NewFramework = NULL;
@@ -264,8 +264,8 @@ InitUnitTestFramework (
// If there is a persisted context, load it now.
//
if (DoesCacheExist (NewFrameworkHandle)) {
- SavedState = (UNIT_TEST_SAVE_HEADER *)NewFramework->SavedState;
- Status = LoadUnitTestCache (NewFrameworkHandle, &SavedState);
+ SavedState = (UNIT_TEST_SAVE_HEADER **)(&NewFramework->SavedState);
+ Status = LoadUnitTestCache (NewFrameworkHandle, SavedState);
if (EFI_ERROR (Status)) {
//
// Don't actually report it as an error, but emit a warning.
--
2.25.1.windows.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-31 6:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-31 6:49 [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer Guomin Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox