From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.4170.1585637383448383815 for ; Mon, 30 Mar 2020 23:49:43 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: guomin.jiang@intel.com) IronPort-SDR: EQKyAQVOEZ2o8C+crTwUVd4M2o9TDuz5ikK4h6kWUsie3CkFDPWS39emeMOzg6gd3J4479VTzN GArkuuYHIwpA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2020 23:49:42 -0700 IronPort-SDR: 8Z+sMWFeO7Xs1jA6sKeFds1Unxw8Ov5htxMGKaRJ92WOqfxd/T+qNXfL0qWjoR3vcqqPNoMGot mqSEoupUnxsw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,327,1580803200"; d="scan'208";a="252135643" Received: from guominji-mobl.ccr.corp.intel.com ([10.238.5.173]) by orsmga006.jf.intel.com with ESMTP; 30 Mar 2020 23:49:41 -0700 From: "Guomin Jiang" To: devel@edk2.groups.io Cc: Michael D Kinney , Sean Brogan , Bret Barkelew Subject: [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer. Date: Tue, 31 Mar 2020 14:49:40 +0800 Message-Id: <20200331064940.1739-1-guomin.jiang@intel.com> X-Mailer: git-send-email 2.25.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2609 The copied pointer (SavedState) will be updated by LoadUnitTestCache call. But the change of SavedState will not update source pointer, which is NewFramework->SavedState in this case. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Guomin Jiang --- UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c b/UnitT= estFrameworkPkg/Library/UnitTestLib/UnitTestLib.c index b136992d99..71050b5618 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c @@ -209,7 +209,7 @@ InitUnitTestFramework ( EFI_STATUS Status;=0D UNIT_TEST_FRAMEWORK_HANDLE NewFrameworkHandle;=0D UNIT_TEST_FRAMEWORK *NewFramework;=0D - UNIT_TEST_SAVE_HEADER *SavedState;=0D + UNIT_TEST_SAVE_HEADER **SavedState;=0D =0D Status =3D EFI_SUCCESS;=0D NewFramework =3D NULL;=0D @@ -264,8 +264,8 @@ InitUnitTestFramework ( // If there is a persisted context, load it now.=0D //=0D if (DoesCacheExist (NewFrameworkHandle)) {=0D - SavedState =3D (UNIT_TEST_SAVE_HEADER *)NewFramework->SavedState;=0D - Status =3D LoadUnitTestCache (NewFrameworkHandle, &SavedState);=0D + SavedState =3D (UNIT_TEST_SAVE_HEADER **)(&NewFramework->SavedState);= =0D + Status =3D LoadUnitTestCache (NewFrameworkHandle, SavedState);=0D if (EFI_ERROR (Status)) {=0D //=0D // Don't actually report it as an error, but emit a warning.=0D --=20 2.25.1.windows.1