From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.69]) by mx.groups.io with SMTP id smtpd.web10.4468.1585639607648355474 for ; Tue, 31 Mar 2020 00:26:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=w8aXIyKK; spf=pass (domain: arm.com, ip: 40.107.5.69, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JnqipNxqsH0coowZoxEe4GEdi4fhH9aJnkdBNGQ8/KI=; b=w8aXIyKKcym4gfpbaqrU32xMsVXn5UQcbKJEsnZW82XavGRAkMPrdMe9vhEtV59fUbLrfxwjaGgCiUny1ZoH6VflbohcVv693KL9FmgIfOwQepEMBfZutQeCrk1ONlZvTl60UuI4iuugoXpMRyoFZ/FSCGJfWCglXeJh+ZHqihM= Received: from AM6PR10CA0101.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::42) by VI1PR08MB2845.eurprd08.prod.outlook.com (2603:10a6:802:1f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.22; Tue, 31 Mar 2020 07:26:43 +0000 Received: from VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::91) by AM6PR10CA0101.outlook.office365.com (2603:10a6:209:8c::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Tue, 31 Mar 2020 07:26:43 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT036.mail.protection.outlook.com (10.152.19.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Tue, 31 Mar 2020 07:26:43 +0000 Received: ("Tessian outbound 9e48e1321951:v50"); Tue, 31 Mar 2020 07:26:42 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6b70d6330462dbee X-CR-MTA-TID: 64aa7808 Received: from c327598b9fae.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 924B0769-E136-48C4-B643-9A481A8F5F4B.1; Tue, 31 Mar 2020 07:26:33 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c327598b9fae.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 31 Mar 2020 07:26:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VgO5QjT1PNTjjuXxSE7nNgkAsjIad3gSecRlcTx31u8H/hCz0roAJAr6f9vQyONut3g3qoagd6oV7bVEauipRNC8euK8dFqyb95lGtIeczyFzuSWqJN9JpsEja16JQ3v1poQXd296wHEdO032ssDlli6hiMKO+3cCbQp85gqqWiWQedpLWeJQPDa7kDu/ol3EMjbYxpSCXmOF2SwYp7Y1C62ntmm29TxbMofbP8Cr0X5ugixX5AZSBHMMxDHStL3OM1CBsqYYH2QbhAb9XzAJEC6kO8F0smFmPwHOo6tRzO7pyQSXgYepha3VVG2RlW8fXKo0VIXtsQYPl0TefYMKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JnqipNxqsH0coowZoxEe4GEdi4fhH9aJnkdBNGQ8/KI=; b=EOOhjQteDLDx3Fwd/ku5IAOY/8ieCXOr5suT7UEREegfRcGJ17h8S6uvQxd9tZuMdfgp/uvbRAs2YY2hLryn5GFJYZOzoYI0Hq7LYNWwLOZgUyhkOKIZeB2qMVokmFoC3hz5nWND8dJkw55ukji+JHE0AU0CpiaySURTP3qvFDyzK+5Bs+ZC27PveVEP+HyhLt+e/eLFWYvVlWc7rANFjHs+yW532Tl7J42wNF9f/Cx+cklLNKeHDNcSnZDzFDnNrQm1VwpH86DUHQ/QTF9cQ7c+3uwkptIe5o2JHsgUwyNQi2wplhV1BLuNINmlSDT3GmCAjLREdcbnelK/ORXkGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JnqipNxqsH0coowZoxEe4GEdi4fhH9aJnkdBNGQ8/KI=; b=w8aXIyKKcym4gfpbaqrU32xMsVXn5UQcbKJEsnZW82XavGRAkMPrdMe9vhEtV59fUbLrfxwjaGgCiUny1ZoH6VflbohcVv693KL9FmgIfOwQepEMBfZutQeCrk1ONlZvTl60UuI4iuugoXpMRyoFZ/FSCGJfWCglXeJh+ZHqihM= Received: from AM4PR08CA0077.eurprd08.prod.outlook.com (2603:10a6:205:2::48) by AM0PR08MB4548.eurprd08.prod.outlook.com (2603:10a6:208:13f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Tue, 31 Mar 2020 07:26:31 +0000 Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:205:2:cafe::cb) by AM4PR08CA0077.outlook.office365.com (2603:10a6:205:2::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Tue, 31 Mar 2020 07:26:31 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Tue, 31 Mar 2020 07:26:30 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Tue, 31 Mar 2020 07:26:12 +0000 Received: from E107187.Arm.com (10.57.18.219) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Tue, 31 Mar 2020 07:26:11 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , Subject: [PATCH v2 1/2] DynamicTablesPkg: SRAT: Fix entry points Date: Tue, 31 Mar 2020 08:26:11 +0100 Message-ID: <20200331072611.28896-1-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(39860400002)(346002)(136003)(396003)(376002)(46966005)(81166006)(6916009)(4326008)(2616005)(316002)(44832011)(70586007)(47076004)(82740400003)(54906003)(36756003)(7696005)(356004)(2906002)(81156014)(1076003)(8936002)(86362001)(8676002)(70206006)(336012)(5660300002)(966005)(186003)(426003)(478600001)(26005);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e65a853a-0c40-4f42-1ad0-08d7d544dcd6 X-MS-TrafficTypeDiagnostic: AM0PR08MB4548:|VI1PR08MB2845: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:1247;OLM:1247; X-Forefront-PRVS: 0359162B6D X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: EIKK/GYo/aMsTEuA+kuQpZrRgE25cxObUZVXLdClB7cBXnUKFzu+VMkcVQlhe+YgOF6oQXw6CWWt/6Wc4++rlEqfGrzK92PBPS2yriMt0vHB4/+9M4prs0xevmSrZrV+6Qk9dXer1ltuhRes4AyhF8nr7C9sEh9lhQhpO/zBpOXuuyanqW8l55cbL7LfNtw2UD/7XG+LJCW3QcB1WampVtYx5U+xauV+bV/PJP+5LkOcYn9kHlW8tJU1rL82F9rZ0dUwfdsoztXn1zF3fmws7a7FB0wXyz/iSudF3+OIxl0qpljhtXEa3oY4P07DphQ7npC4WI1NaIIk8M3X4y2wccPF8Sv3xGOGsvcRCSrHrTTrej7EsCy9NRVW1x4LKKw0ne9g2Kv+x3oizb8XSQx1C0VLqylesnJ6hKwCC3E5JQPev3sAHBnMhjT1dKQrOpghy2braG/svgkSPTDF2n4tZjhV4UEUo2zZ3zR2K1IouPEmmnCl/iMxgXxvN9xOkdH2DtPB+Lyexh+BHMMwtXWEwAqgmgnSuj/cgjWO6FZ189o1MnehrOf0ROHs+lk+BmskPbZHrhudRxPPMeL7uu4PXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4548 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(136003)(346002)(39860400002)(396003)(46966005)(86362001)(70206006)(336012)(44832011)(47076004)(26826003)(6916009)(966005)(70586007)(7696005)(26005)(5660300002)(426003)(478600001)(36906005)(2906002)(186003)(316002)(54906003)(4326008)(81166006)(8936002)(81156014)(8676002)(36756003)(1076003)(2616005)(82740400003);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 95552d40-730a-4a83-dd3b-08d7d544d536 X-Forefront-PRVS: 0359162B6D X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YmkIcXEG7q6K1yZedMw5aBlj4OYA65+hHQLpEZSsoTddLfnfjY9VC87DZQuP5o59zvHPdFe44w+Q17+g28CgTlqquHGM8MWoBdMVoxKU72+XxoHZ9t6tiPNNZ02bGfTB90t7sDeI6YuAY6emj7ji0kyHt/VD8Uo28AGoA5//2SuZAYVaNQQhc+XbejIR7dhSHn6hU9XoGbLgDeW4Ry7e62fo39BPjS7o7eU6fccnQa5aejAUH/5R8/qGDo9lmnqyckew52Y7i6P7SWkXzm30JCZ03apJ2QwfkSh7D+vGnFKuG76P7e4oSj424hMLCWk06cyi3IjKeyk9t6HBoajVeu9GH/qJiaQ8zItddQ4QtKedD3mbruQ0CKZQIoIDGAXFWOghKa/g8xfyvm01Yjo08ckEsmxAAxKvefzxOTAahb8u7votsOWFqavzBHzrE8p1U2Sz60fxF+HJSCQOkdSjJ+bBPoF/mi2ecHf6H0m20u3JFSN6gSjtcvdpOR5mLSmx0K2JCv8fZhRpaKPSqWDyroCg0Ths54frb6iTr1s9KClPt//KfiBOe2Lb7SxKGXMLOBa0JvzyE2UV7wBVfc6e+A== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2020 07:26:43.4675 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e65a853a-0c40-4f42-1ad0-08d7d544dcd6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2845 Content-Type: text/plain VS2017 reports 'warning C4028: formal parameter 2 different from declaration' for the library constructor and destructor interfaces for the SRAT Generator modules. Remove the CONST qualifier for the ImageHandle and the SystemTable pointer in the library constructor and destructor to make it compatible with the formal declaration. Signed-off-by: Sami Mujawar --- The changes can be seen at: https://github.com/samimujawar/edk2/tree/702_srat_vs2017_compile_warning_v2 Notes: V2: - Update commit message to reflect the update to the CONST [SAMI] qualifier at 2 places in the constructor & destructor. DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c index 5d56af66608d862e6eca81da812d719f110867d2..74cb7d92a5d8cddd3df8334f3ab55e6fa3e7267a 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c @@ -800,8 +800,8 @@ ACPI_TABLE_GENERATOR SratGenerator = { EFI_STATUS EFIAPI AcpiSratLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -823,8 +823,8 @@ AcpiSratLibConstructor ( EFI_STATUS EFIAPI AcpiSratLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'