From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web12.6361.1585651852006714384 for ; Tue, 31 Mar 2020 03:50:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=ZeA2903Y; spf=pass (domain: nuviainc.com, ip: 209.85.128.66, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f66.google.com with SMTP id a81so2022992wmf.5 for ; Tue, 31 Mar 2020 03:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=d2m8byZHpA5NExMh2528QJVdf7iRGSzW3GaOjLVeBbA=; b=ZeA2903YqEBL/XnbiEu4fAOx5IfxPtCEMhT/QK3vbvOf63E54DnAL5Mmg312jqCq9B xFVAj/jSlMnDpm9uq2wrTeUw22+/kwyVA8zqh6Stf/aS4vzuLxmoDdDcZWzWNOGiw9qJ IygyjMMDg0xpcN0wORn7r3kkBeCJ3RoGK35kFifYfRy5BqMybfw9/ulsa8b1Ei5bcB4v V1xYOv7UzXYbjb3nq95Waf6DTv8sCyo5ydAcCv+dvA8075Cm4Zvi4f82gKH5zEtoHZe3 1WfxMMqXQYo12mKMVxPnnZX6Kb1zPRfwwoebgiHFIjaw4soEDIpWW4RP/AoyF+WK73Yd xgMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=d2m8byZHpA5NExMh2528QJVdf7iRGSzW3GaOjLVeBbA=; b=CalWY5ovoKBdGvhlOxB4MzUt5Av59TFldKIk7sAtInKbcjyJc0b2+DZ4EMq2CtkTdh Hsjw+VTF75EL4ApqIuz8S4Y1qqug0/E+d2iHL5BdMPtakH7v9UeHeiMsCEZe/yTXOLSR Nas4B7PmwMYaxyrWMbLidP3u4uBPaF3EHYagtpMec6t55AW3Kkb1N0kOPo/Wf6lwbYuO yuqMGeCAJzJIcqss3bhPqLMY1WPYwOh6VBM2yXF6Kak2HY8jhJX1skkVuWyZ9Q95vK2k LSWTwHJs+zYdt+fT9ZUYQX0KIuE8rbd2JhS/bKLShoPB2g77nx1YFL5eSYsIrwJO0hqD zDpQ== X-Gm-Message-State: ANhLgQ3ZEnAPbf7xjRqHCnAH93gdtHGg2H7cJTlDM3NWICV4B2JYezvT NKJZkYPYe9lBF4MKw6AMaI4eGA== X-Google-Smtp-Source: ADFU+vs7tDOQdbfUb2M7VmBG82F4JGSoxGi9P2va6xt7hcCl/cbHZsyLr8FpUTvSyRMSPjnK003MTw== X-Received: by 2002:a1c:9c85:: with SMTP id f127mr2945624wme.91.1585651850573; Tue, 31 Mar 2020 03:50:50 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id x6sm3236901wmi.2.2020.03.31.03.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 03:50:50 -0700 (PDT) Date: Tue, 31 Mar 2020 11:50:48 +0100 From: "Leif Lindholm" To: "Pankaj Bansal (OSS)" Cc: Meenakshi Aggarwal , Michael D Kinney , "devel@edk2.groups.io" , Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 28/28] Platform/NXP/LS1043aRdbPkg: Add PEI Phase Message-ID: <20200331105048.GC7468@vanye> References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-29-pankaj.bansal@oss.nxp.com> <20200330121859.GA7543@vanye> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 31, 2020 at 10:23:48 +0000, Pankaj Bansal (OSS) wrote: > > > -/*++ > > > - > > > -Routine Description: > > > - > > > - > > > - > > > -Arguments: > > > - > > > - FileHandle - Handle of the file being invoked. > > > - PeiServices - Describes the list of possible PEI Services. > > > - > > > -Returns: > > > - > > > - Status - EFI_SUCCESS if the boot mode could be set > > > - > > > ---*/ > > > > The above line caused me an unexpected level of excitement this > > morning, as my "put back the CRs SMTP strips out" script treated the > > --- as a diff separator. > > > > Now, I *have* seen the use of /*++ --*/ elsewhere in the tree, but > > this syntax is *not* described in the coding style and should not be > > used. While this is a delete statement, there is an addition below > > using the same format. The doxygen tags to use are /** and **/. > > > > Fortunately, I can't spot any of these in the rest of the set. > > > > Please send an updated version of this patch - alone if it's the only > > patch that needs changes, or with a v4 if such is required. > > I have not received any comments on other patches so far. > Does that mean all patches are OK (except above)? > If that is the case, then I can send only this patch after update. > If some rework is needed for other patches as well, I will send this patch along with other reworked patches in v3. No, sorry, going through them now. Had a lot of random interruptions. I commented on this first because it caused an error when I was importing the set. / Leif