* [PATCH] Maintainers.txt: Add Liran and Nikita as OvmfPkg/PvScsiDxe reviewers
@ 2020-03-31 11:02 Liran Alon
2020-03-31 21:32 ` Laszlo Ersek
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Liran Alon @ 2020-03-31 11:02 UTC (permalink / raw)
To: devel, lersek
Cc: nikita.leshchenko, aaron.young, jordan.l.justen, ard.biesheuvel,
Liran Alon
Laszlo suggested that as I have contributed the OvmfPkg PVSCSI driver, I
will also register myself as a reviewer in Maintainers.txt.
In addition, as Nikita have assisted the development of the PVSCSI
driver and have developed another similar OvmfPkg SCSI driver, add him
as a reviewer to PVSCSI driver as-well.
Cc: Nikita Leshenko <nikita.leshchenko@oracle.com>
Suggested-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Liran Alon <liran.alon@oracle.com>
---
Maintainers.txt | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 342bb8d0850c..de443ba7ba1f 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -435,6 +435,11 @@ OvmfPkg: CSM modules
F: OvmfPkg/Csm/
R: David Woodhouse <dwmw2@infradead.org>
+OvmfPkg: PVSCSI driver
+F: OvmfPkg/PvScsiDxe
+R: Liran Alon <liran.alon@oracle.com>
+R: Nikita Leshenko <nikita.leshchenko@oracle.com>
+
PcAtChipsetPkg
F: PcAtChipsetPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Maintainers.txt: Add Liran and Nikita as OvmfPkg/PvScsiDxe reviewers
2020-03-31 11:02 [PATCH] Maintainers.txt: Add Liran and Nikita as OvmfPkg/PvScsiDxe reviewers Liran Alon
@ 2020-03-31 21:32 ` Laszlo Ersek
2020-03-31 21:44 ` [edk2-devel] " Nikita Leshenko
2020-04-01 14:45 ` Laszlo Ersek
2 siblings, 0 replies; 4+ messages in thread
From: Laszlo Ersek @ 2020-03-31 21:32 UTC (permalink / raw)
To: Liran Alon, devel
Cc: nikita.leshchenko, aaron.young, jordan.l.justen, ard.biesheuvel
On 03/31/20 13:02, Liran Alon wrote:
> Laszlo suggested that as I have contributed the OvmfPkg PVSCSI driver, I
> will also register myself as a reviewer in Maintainers.txt.
>
> In addition, as Nikita have assisted the development of the PVSCSI
> driver and have developed another similar OvmfPkg SCSI driver, add him
> as a reviewer to PVSCSI driver as-well.
>
> Cc: Nikita Leshenko <nikita.leshchenko@oracle.com>
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Liran Alon <liran.alon@oracle.com>
> ---
> Maintainers.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 342bb8d0850c..de443ba7ba1f 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -435,6 +435,11 @@ OvmfPkg: CSM modules
> F: OvmfPkg/Csm/
> R: David Woodhouse <dwmw2@infradead.org>
>
> +OvmfPkg: PVSCSI driver
> +F: OvmfPkg/PvScsiDxe
A trailing slash character is missing from this pattern (see the "F:"
documentation near the top of this file), but I do take the blame for
that, because my suggestion didn't contain the trailing slash either. So
I can fix this up for you, before I push.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Nikita, can you please give your R-b as well?
Thanks,
Laszlo
> +R: Liran Alon <liran.alon@oracle.com>
> +R: Nikita Leshenko <nikita.leshchenko@oracle.com>
> +
> PcAtChipsetPkg
> F: PcAtChipsetPkg/
> W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] Maintainers.txt: Add Liran and Nikita as OvmfPkg/PvScsiDxe reviewers
2020-03-31 11:02 [PATCH] Maintainers.txt: Add Liran and Nikita as OvmfPkg/PvScsiDxe reviewers Liran Alon
2020-03-31 21:32 ` Laszlo Ersek
@ 2020-03-31 21:44 ` Nikita Leshenko
2020-04-01 14:45 ` Laszlo Ersek
2 siblings, 0 replies; 4+ messages in thread
From: Nikita Leshenko @ 2020-03-31 21:44 UTC (permalink / raw)
To: devel, liran.alon; +Cc: lersek, aaron.young, jordan.l.justen, ard.biesheuvel
> On 31 Mar 2020, at 14:02, Liran Alon <liran.alon@oracle.com> wrote:
>
> Laszlo suggested that as I have contributed the OvmfPkg PVSCSI driver, I
> will also register myself as a reviewer in Maintainers.txt.
>
> In addition, as Nikita have assisted the development of the PVSCSI
> driver and have developed another similar OvmfPkg SCSI driver, add him
> as a reviewer to PVSCSI driver as-well.
>
> Cc: Nikita Leshenko <nikita.leshchenko@oracle.com>
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Liran Alon <liran.alon@oracle.com>
> ---
> Maintainers.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 342bb8d0850c..de443ba7ba1f 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -435,6 +435,11 @@ OvmfPkg: CSM modules
> F: OvmfPkg/Csm/
> R: David Woodhouse <dwmw2@infradead.org>
>
> +OvmfPkg: PVSCSI driver
> +F: OvmfPkg/PvScsiDxe
> +R: Liran Alon <liran.alon@oracle.com>
> +R: Nikita Leshenko <nikita.leshchenko@oracle.com>
> +
> PcAtChipsetPkg
> F: PcAtChipsetPkg/
> W: https://urldefense.com/v3/__https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg__;!!GqivPVa7Brio!MOGqjthxmkgBKMVAnKhDxWbILitfHbgG_puzaCEDOatoBRhq0l6DSnrM-WOGI_dh-GTfLw$
> --
> 2.20.1
Reviewed-by: Nikita Leshenko <nikita.leshchenko@oracle.com>
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] Maintainers.txt: Add Liran and Nikita as OvmfPkg/PvScsiDxe reviewers
2020-03-31 11:02 [PATCH] Maintainers.txt: Add Liran and Nikita as OvmfPkg/PvScsiDxe reviewers Liran Alon
2020-03-31 21:32 ` Laszlo Ersek
2020-03-31 21:44 ` [edk2-devel] " Nikita Leshenko
@ 2020-04-01 14:45 ` Laszlo Ersek
2 siblings, 0 replies; 4+ messages in thread
From: Laszlo Ersek @ 2020-04-01 14:45 UTC (permalink / raw)
To: devel, liran.alon
Cc: nikita.leshchenko, aaron.young, jordan.l.justen, ard.biesheuvel
On 03/31/20 13:02, Liran Alon wrote:
> Laszlo suggested that as I have contributed the OvmfPkg PVSCSI driver, I
> will also register myself as a reviewer in Maintainers.txt.
>
> In addition, as Nikita have assisted the development of the PVSCSI
> driver and have developed another similar OvmfPkg SCSI driver, add him
> as a reviewer to PVSCSI driver as-well.
>
> Cc: Nikita Leshenko <nikita.leshchenko@oracle.com>
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Liran Alon <liran.alon@oracle.com>
> ---
> Maintainers.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 342bb8d0850c..de443ba7ba1f 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -435,6 +435,11 @@ OvmfPkg: CSM modules
> F: OvmfPkg/Csm/
> R: David Woodhouse <dwmw2@infradead.org>
>
> +OvmfPkg: PVSCSI driver
> +F: OvmfPkg/PvScsiDxe
> +R: Liran Alon <liran.alon@oracle.com>
> +R: Nikita Leshenko <nikita.leshchenko@oracle.com>
> +
> PcAtChipsetPkg
> F: PcAtChipsetPkg/
> W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>
Pushed as commit 335644f90f15fac8bfd5575f937fa65af4978a08, via
<https://github.com/tianocore/edk2/pull/491>.
Thanks,
Laszlo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-01 14:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-31 11:02 [PATCH] Maintainers.txt: Add Liran and Nikita as OvmfPkg/PvScsiDxe reviewers Liran Alon
2020-03-31 21:32 ` Laszlo Ersek
2020-03-31 21:44 ` [edk2-devel] " Nikita Leshenko
2020-04-01 14:45 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox