From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67])
 by mx.groups.io with SMTP id smtpd.web12.7671.1585657917487700452
 for <devel@edk2.groups.io>;
 Tue, 31 Mar 2020 05:31:57 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=XAkbHg0g;
 spf=pass (domain: nuviainc.com, ip: 209.85.221.67, mailfrom: leif@nuviainc.com)
Received: by mail-wr1-f67.google.com with SMTP id h9so25662454wrc.8
        for <devel@edk2.groups.io>; Tue, 31 Mar 2020 05:31:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=/GrthfVo5tR8KyspiiL6Fj68IWSjKaxs92WScD52pc4=;
        b=XAkbHg0gy2ysU8/5pUUti/KG9Cq44qcs4kD1lKdfouO9WZjFa4h8bWlsmvhapuqvTr
         idx7dleMNCpkfrw1saYlEH7VUuYtpHckQZnRG2/2PLUdjEGEz549LWuHG4da+YdNEwj7
         PWDoO08WrRAFIEPzukNSH3Dj0/rLumHnOndR8hKQu/OKpQmzr3eYOplWJuq2L5nH/c7P
         4ohXhhgyxB0vcv+Qu1HTxhvwMY0fiurRDkZC/iBQ+gxUZB5WAPIcv1futCbfXUEKMqGo
         kYG2adaqi19t/QSU2c6UTlBl6z7Ay7ENttTvcW5B43YZVvA1IXNeD2Uk4IDdqwHV/0rb
         dLvQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=/GrthfVo5tR8KyspiiL6Fj68IWSjKaxs92WScD52pc4=;
        b=D5oCJXwH4e7bdu8yWke55SX+HTAMdVd4CX7laZiYG309kD3hIhXQnbMwmdqQYVqb3h
         4AxRQFMuTKbxPg75Oq9y4YJtIzVsVQ2YsEJ6XUw5p33jjn6yLKfn7V2A7hssOMW6nNi7
         PjSVYghqSVyZlXz827EOU2VCEKBidmmXz6nIxfKS1Q6YgvVl408N+mX6wX5cSJgVQx3i
         kUQctNELDnpi2lVlF5BiyBFRlcSZUJ5JbJCxCZCHAP5SdRnfcdZrNMKU/mSse4c8rwt6
         UWf3pERLptFTowuhF1If4Ua3+wuUCWpyfPafuhgdXUq7rIQv/raOPIrF+aAtd6LPcLNN
         xnig==
X-Gm-Message-State: ANhLgQ0HSPA212yFkC7xH6RW5vgeGgV286I9ONVNHOB2aaNU8aUu9lBJ
	3OWUiwRBjDFFoq4zAHovGfAPWQ==
X-Google-Smtp-Source: ADFU+vts4bzHIAag3DK2/N1zg50LjJVNSGcezCTD0nBZB0fPwThX7xDOQztjq/dsBD37/JT2bkRe1w==
X-Received: by 2002:a5d:4284:: with SMTP id k4mr19864778wrq.310.1585657916096;
        Tue, 31 Mar 2020 05:31:56 -0700 (PDT)
Return-Path: <leif@nuviainc.com>
Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8])
        by smtp.gmail.com with ESMTPSA id n2sm27885752wro.25.2020.03.31.05.31.55
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 31 Mar 2020 05:31:55 -0700 (PDT)
Date: Tue, 31 Mar 2020 13:31:53 +0100
From: "Leif Lindholm" <leif@nuviainc.com>
To: Pankaj Bansal <pankaj.bansal@oss.nxp.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
	Michael D Kinney <michael.d.kinney@intel.com>, devel@edk2.groups.io,
	Varun Sethi <V.Sethi@nxp.com>,
	Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
	Jon Nettleton <jon@solid-run.com>
Subject: Re: [PATCH v2 05/28] Silicon/Maxim: Add comments in Ds1307RtcLib
Message-ID: <20200331123153.GG7468@vanye>
References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com>
 <20200320143543.18615-6-pankaj.bansal@oss.nxp.com>
MIME-Version: 1.0
In-Reply-To: <20200320143543.18615-6-pankaj.bansal@oss.nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Mar 20, 2020 at 20:05:20 +0530, Pankaj Bansal wrote:
> From: Pankaj Bansal <pankaj.bansal@nxp.com>
> 
> Add comments to explain the register read and write operation
> on Ds1307. These comments have been referred from data sheet:
> 
> https://datasheets.maximintegrated.com/en/ds/DS1307.pdf
> 
> Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>

> ---
>  Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c b/Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c
> index fd7a8696e405..444e01124811 100644
> --- a/Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c
> +++ b/Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c
> @@ -28,6 +28,11 @@ STATIC EFI_I2C_MASTER_PROTOCOL    *mI2cMaster;
>  
>  /**
>    Read RTC register.
> +  Data Read-Slave Transmitter Mode
> +
> +  <Slave Address> <Word Address (n)> <Slave Address> <Data(n)> <Data(n+1)> <Data(n+2)> <Data(n+X)>
> +
> +  The first byte is received and handled as in the slave receiver mode.
>  
>    @param  RtcRegAddr       Register offset of RTC to be read.
>  
> @@ -69,6 +74,9 @@ RtcRead (
>  
>  /**
>    Write RTC register.
> +  Data Write-Slave Receiver Mode
> +
> +  <Slave Address> <Word Address (n)> <Data(n)> <Data(n+1)> <Data(n+X)>
>  
>    @param  RtcRegAddr       Register offset of RTC to write.
>    @param  Val              Value to be written
> -- 
> 2.17.1
>