From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web11.2711.1585734151174462338 for ; Wed, 01 Apr 2020 02:42:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=Dy0n4x0C; spf=pass (domain: nuviainc.com, ip: 209.85.221.67, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f67.google.com with SMTP id m17so29680885wrw.11 for ; Wed, 01 Apr 2020 02:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2SnzShlxWE76eODGnGApXJ7aNyjwVmMVycbFL8H0n8c=; b=Dy0n4x0CZaP7HDnfJiYZ7SGriQWIK0ydDgoauhDTsR6NzubSiiMc//rsoMdnG/prCj 7SSTvcCnzs3T5ik1tKbtDPO03BKrXzXJxlBC1HIGT/Qq7RVyKXjuCQuKqOQEyF1AoBGT QTkWZGfJ5KHRthVRD6Ab35qeCG3j1shqYyEjm6WhdE1rHXeoO156p3HEeJq76QF5bXIZ hBnZ1bS90x/EgWfKibNQabQQ9RnO4yaJhSiXbe4S/qFgUjrFmKxdmiQGdycxFu54qr46 NoGEcdtvWfnxY0r+xiKLmI23MMUup/Oiozq6I0z5xPFqtSOWyXbvc71L2/4sNVAsukLr kgCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2SnzShlxWE76eODGnGApXJ7aNyjwVmMVycbFL8H0n8c=; b=LRrmX/ngdP0tuNQdiIw8+Wi+tWXfTDB6wLLLDB/BcquYY9ccyLD/H90lgXdsc7/WaN eMreCb3B/EoYu7sW3HNeKrtLB5BT+Y0y/6MZYphe44cvoFAtSjtfTmCrMIttVAz4aHRM OitC88G0zQV6OJC7GMsCsZ6/7nV705p3AvTYIELX00vdwmD5UVkY75fxUVffL9bZS0Te J2Sc1Bd4luqsShnBhCoj/iMMbolm7bxAK0SDNjE2pk18UcZiH6oqxPU4cBKRYclgNVb4 aSLIoz7is40WHJ7brIZlKLMVcPal1AZZb6png92WqJ7QuUvrGUXjjDzwWz/btXIKRt8o 34Sg== X-Gm-Message-State: ANhLgQ0R8ilV+9fbKuMKGgQasJVlkeel7jZL2vRxA+URZvmlAebhbNHj Sld+TKAALNMVHpAvuKepP5KMlw== X-Google-Smtp-Source: ADFU+vvRi5tldeyGaP6L2MeHnuc5g7GikVZZovcVwRdlKaujdLAhlCN1aWCdEN5vxcOfQ4UlLkTlfQ== X-Received: by 2002:a5d:6581:: with SMTP id q1mr24288658wru.17.1585734149720; Wed, 01 Apr 2020 02:42:29 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id j68sm2255013wrj.32.2020.04.01.02.42.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 02:42:28 -0700 (PDT) Date: Wed, 1 Apr 2020 10:42:26 +0100 From: "Leif Lindholm" To: Pankaj Bansal Cc: Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 06/28] NXP/LS1043aRdb: Move Soc specific components to soc files Message-ID: <20200401094226.GN7468@vanye> References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-7-pankaj.bansal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <20200320143543.18615-7-pankaj.bansal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 20, 2020 at 20:05:21 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Soc specific components ought to be part of Soc files and not > platform files. move the same to SOC files > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 7 +------ > Platform/NXP/NxpQoriqLs.dsc.inc | 2 ++ > Silicon/NXP/LS1043A/LS1043A.dsc.inc | 7 ++++++- > 3 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > index c8105593533f..802cccdce63b 100644 > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > @@ -2,7 +2,7 @@ > # > # LS1043ARDB Board package. > # > -# Copyright 2017-2019 NXP > +# Copyright 2017-2020 NXP > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -26,11 +26,7 @@ [Defines] > !include Silicon/NXP/LS1043A/LS1043A.dsc.inc > > [LibraryClasses.common] > - SocLib|Silicon/NXP/Library/SocLib/LS1043aSocLib.inf > ArmPlatformLib|Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > - ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > - SerialPortLib|Silicon/NXP/Library/DUartPortLib/DUartPortLib.inf > - IoAccessLib|Silicon/NXP/Library/IoAccessLib/IoAccessLib.inf > RealTimeClockLib|Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.inf > > [PcdsFixedAtBuild.common] > @@ -46,7 +42,6 @@ [PcdsFixedAtBuild.common] > # > # Board Specific Pcds > # > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x021c0500 > gNxpQoriqLsTokenSpaceGuid.PcdSerdes2Enabled|FALSE > gNxpQoriqLsTokenSpaceGuid.PcdPlatformFreqDiv|0x1 > > diff --git a/Platform/NXP/NxpQoriqLs.dsc.inc b/Platform/NXP/NxpQoriqLs.dsc.inc > index b28e0615f7ca..94d3e53a046b 100644 > --- a/Platform/NXP/NxpQoriqLs.dsc.inc > +++ b/Platform/NXP/NxpQoriqLs.dsc.inc > @@ -95,6 +95,8 @@ [LibraryClasses.common] > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > I2cLib|Silicon/NXP/Library/I2cLib/I2cLib.inf > + ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > + IoAccessLib|Silicon/NXP/Library/IoAccessLib/IoAccessLib.inf > > [LibraryClasses.common.SEC] > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > diff --git a/Silicon/NXP/LS1043A/LS1043A.dsc.inc b/Silicon/NXP/LS1043A/LS1043A.dsc.inc > index dbd680b0ad28..d2d4133428c3 100644 > --- a/Silicon/NXP/LS1043A/LS1043A.dsc.inc > +++ b/Silicon/NXP/LS1043A/LS1043A.dsc.inc > @@ -1,12 +1,16 @@ > # LS1043A.dsc > # LS1043A Soc package. > # > -# Copyright 2017-2019 NXP > +# Copyright 2017-2020 NXP > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > # > > +[LibraryClasses.common] > + SocLib|Silicon/NXP/Library/SocLib/LS1043aSocLib.inf > + SerialPortLib|Silicon/NXP/Library/DUartPortLib/DUartPortLib.inf > + > ################################################################################ > # > # Pcd Section - list of all EDK II PCD Entries defined by this Platform > @@ -20,6 +24,7 @@ [PcdsDynamicDefault.common] > gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x01402000 > > [PcdsFixedAtBuild.common] > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x021c0500 > > # > # CCSR Address Space and other attached Memories > -- > 2.17.1 >