From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web11.2825.1585734812981925139 for ; Wed, 01 Apr 2020 02:53:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=IM6mAeMU; spf=pass (domain: nuviainc.com, ip: 209.85.221.68, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f68.google.com with SMTP id h15so29730571wrx.9 for ; Wed, 01 Apr 2020 02:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MW5cpGgSOO3mcoTJ/teKT3KV04w8UL/lNtGcTlsIBEw=; b=IM6mAeMUQi4sNRQMsUAeZeCviLl60JBgIzSLnuIT95/0+Gs7Q3LGBA/wvjsm/k/Oeg avu/1keP10B0iXnSa9kaCPwR6Z59xFhuWK0oMCXyN4aOCoPozvDdKFVREpkRpgHQ8ePP 8ZpYupRzoZmfaFzCFIMguiLaSQE+Ij/AKFZ0EhD9vAdPxWZK6IWFwKK2KTviyHoHjanX NZytauf8hbq8xBBKN1+1pa0GCv09cDT71wCO99WBN1UwbIDk6jiW8M/rh6o7aEZsWDkQ 8G1wlY2qKi+7VtWBJ9pCNG7kTJ/Y26ncY9kMNTCMl0YSrJE2g4yjzGBm5cDt0IsiWTsB Y7ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MW5cpGgSOO3mcoTJ/teKT3KV04w8UL/lNtGcTlsIBEw=; b=tZhYBypGC/QSbGVVpJeU8WFuu1e7ONujFcdB1CRGYd1IV2kcp5ChPVq82Ig2gmnqD2 MwFDu3y+03LZ+vCwOmKY+V26qAgWy3Eaq0Qv4t4TDUlB7vzMug9qdf9dFoIlXhdQ/i3q nLOwCCPNTWUB7h9F8XumTtqP9Owpa03HJ5zywyx0htCl32iKw60LiqQITEFx7OCPvX6N 5lJxvJuj7x/Pnq4uUW7tyoy1lTJwHaSc8DO6XZ60RaE+NrFfmwRRhbHO7Pd32Y/kJrOL cl0d4iGc+CdWFoBKZpDN36Job0FmDmFIrg93rS1vwsA0UUUSznSjfMuaTC4zZHGPfr6g vfFQ== X-Gm-Message-State: AGi0PuYpzxBpcGwygnrr/Rr6boHTWBlBKT6jZ/sH/UslFN14qpv1tDey EkEdPGNV+uSjsl+hhGZbxrjvxg== X-Google-Smtp-Source: APiQypLCFgR19Gus14e0+rWrnFzwuQ0bARGhonFFOzRA9amycubaj3baN7v1yK6/t1FnCwKtBst5dA== X-Received: by 2002:a5d:6452:: with SMTP id d18mr4591079wrw.405.1585734811465; Wed, 01 Apr 2020 02:53:31 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id a13sm2245184wrh.80.2020.04.01.02.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 02:53:31 -0700 (PDT) Date: Wed, 1 Apr 2020 10:53:29 +0100 From: "Leif Lindholm" To: Pankaj Bansal Cc: Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib Message-ID: <20200401095329.GO7468@vanye> References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-8-pankaj.bansal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <20200320143543.18615-8-pankaj.bansal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 20, 2020 at 20:05:22 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Implement SerialUartClockLib for all NXP Layerscape Platforms. > > Signed-off-by: Pankaj Bansal > --- > .../SerialUartClockLib/SerialUartClockLib.c | 27 +++++++++++++++++++ > .../SerialUartClockLib/SerialUartClockLib.inf | 26 ++++++++++++++++++ I requested after the initial submission that you "either follow the manual git setup steps from https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers or execute edk2/BaseTools/Scripts/SetupGit.py in each of the tianocore repositories" Now, neither appears to have happened, as .c still comes before .inf and paths are still truncated. But in addition to that, we realised that git happily ignores settings for --stat. So, please, execute aforementioned script, but then generate v3 with --stat=1000 --stat-graph-width=20. For this particular patch, the side discussion on the edk2 portion may make it redundant, so I'm deferring review. / Leif > 2 files changed, 53 insertions(+) > create mode 100644 Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c > create mode 100644 Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf > > diff --git a/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c > new file mode 100644 > index 000000000000..9d49d7b4748b > --- /dev/null > +++ b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c > @@ -0,0 +1,27 @@ > +/** @file > +* > +* Copyright 2020 NXP > +* > +* SPDX-License-Identifier: BSD-2-Clause-Patent > +* > +**/ > + > +#include > + > +extern > +UINT64 > +GetBusFrequency ( > + VOID > + ); > + > +/** > + Return clock in for Uart IP > +**/ > +UINT32 > +EFIAPI > +BaseSerialPortGetClock ( > + VOID > + ) > +{ > + return GetBusFrequency (); > +} > diff --git a/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf > new file mode 100644 > index 000000000000..9a3e80cf521d > --- /dev/null > +++ b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf > @@ -0,0 +1,26 @@ > +# @file > +# Copyright 2020 NXP > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +# > + > +[Defines] > + INF_VERSION = 1.27 > + BASE_NAME = SerialUartClockLib > + FILE_GUID = fa65495e-d3c8-4ea3-9737-994e9ccbaf11 > + MODULE_TYPE = BASE > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = SerialUartClockLib > + > +[Packages] > + MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > + Silicon/NXP/NxpQoriqLs.dec > + > +[Sources.common] > + SerialUartClockLib.c > + > +[LibraryClasses] > + SocLib > + > -- > 2.17.1 >