From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web12.2888.1585734898436277234 for ; Wed, 01 Apr 2020 02:54:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=oaDI/3y6; spf=pass (domain: nuviainc.com, ip: 209.85.128.68, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f68.google.com with SMTP id e9so6448659wme.4 for ; Wed, 01 Apr 2020 02:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G0Sob39OOK262LdD1xb+HQg2eySNYroh/YTOu3S2I1k=; b=oaDI/3y6P/1Tq5AuJjdt/kygdSQ5QI6Q3MyFeVH40Ko29j1CQkYxpERITqzltedAWz h8AlaqdiJXQHX8GoMlMMDB6YsSWPu4ik9oaRrhmV0NfSRpU2ijiqSbZ0pZ4JVeRbVFcR YoQlLOfbpF/MSSUoxC6uS6wC6WJJpopY6Vg4l+f6+OYOC+bYEPSCWOlMqSER5PfKAOf+ iltPDxTtOYjUZYyJ2k01hXPSIfmiS/GWE1EZTIy5kwZjyeye4Kkl698bUaDmlLljamcd +LUWn6bFDuo65zAPzRsBaQzaL8rADvwv088yX2aFlnU/4z9f41s86OHjN6yZO1M2sY7j KlbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=G0Sob39OOK262LdD1xb+HQg2eySNYroh/YTOu3S2I1k=; b=uBgXPnQiCHKETy2HDRw0x7tQVmAJcfGP5M+WCHcxr6QTGHooYiZeGHqcPFB22dyom3 upt25x00DV8aRdjFCCaYeLbEyuyKhIWm8sdpk1JaIB5fRGnWjBniJghV3GyV1tJSUZHL 3cSt7tLaVcVGhqB0IVdLcLjy/oTiyHoZNW+M57ZYUL85EpoCPsrNCvQ0U8R3zsIlTA94 LpMTNNdaD8VMxoj4yDnqy17aCe1TUZCdS+hrfI2Wyq4/PbI24SloE1P/qL6OzzuaZXfy w+zVezI0q1uU42ZreP/XjX73CBUPFx8lf+OZ2VtTnw7NuNbc8JSU/ZLQRnMa2uca2Qho n/hw== X-Gm-Message-State: AGi0PublM30IMd7+uEDbJg1N3Juk1MBotn3m8LRYZlZlnu2JZpvzhY4n ne792ANMC+ZBrRg2IALeLwbQBQ== X-Google-Smtp-Source: APiQypI0W0irJ5whzeVg1fR5KPXF9jC+9UXPQdvVUeayZtCc1L4ekzmMpS3O+9NLCPLyZ7/e42YctA== X-Received: by 2002:a1c:dc8b:: with SMTP id t133mr3222999wmg.99.1585734897081; Wed, 01 Apr 2020 02:54:57 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id a7sm1909097wmm.34.2020.04.01.02.54.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 02:54:56 -0700 (PDT) Date: Wed, 1 Apr 2020 10:54:54 +0100 From: "Leif Lindholm" To: Pankaj Bansal Cc: Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 08/28] Silicon/NXP/LS1043A: Use BaseSerialPortLib16550 as SerialPortLib Message-ID: <20200401095454.GP7468@vanye> References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-9-pankaj.bansal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <20200320143543.18615-9-pankaj.bansal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 20, 2020 at 20:05:23 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > UART Programming model in LS1043A is compatible with PC16550D. > Therefore, BaseSerialPortLib16550 can be used instead of our own > implementation of SerialPortLib. > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm (If the need for SerialUartClockLib goes away, that line can be dropped without re-review being required.) > --- > Platform/NXP/NxpQoriqLs.dsc.inc | 3 +++ > Silicon/NXP/LS1043A/LS1043A.dsc.inc | 5 ++++- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Platform/NXP/NxpQoriqLs.dsc.inc b/Platform/NXP/NxpQoriqLs.dsc.inc > index 94d3e53a046b..234a5e2707cd 100644 > --- a/Platform/NXP/NxpQoriqLs.dsc.inc > +++ b/Platform/NXP/NxpQoriqLs.dsc.inc > @@ -98,6 +98,9 @@ [LibraryClasses.common] > ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > IoAccessLib|Silicon/NXP/Library/IoAccessLib/IoAccessLib.inf > > + PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf > + PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf > + > [LibraryClasses.common.SEC] > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf > diff --git a/Silicon/NXP/LS1043A/LS1043A.dsc.inc b/Silicon/NXP/LS1043A/LS1043A.dsc.inc > index d2d4133428c3..f6f15a482a85 100644 > --- a/Silicon/NXP/LS1043A/LS1043A.dsc.inc > +++ b/Silicon/NXP/LS1043A/LS1043A.dsc.inc > @@ -8,8 +8,10 @@ > # > > [LibraryClasses.common] > + PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull.inf > SocLib|Silicon/NXP/Library/SocLib/LS1043aSocLib.inf > - SerialPortLib|Silicon/NXP/Library/DUartPortLib/DUartPortLib.inf > + SerialUartClockLib|Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf > + SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > > ################################################################################ > # > @@ -25,6 +27,7 @@ [PcdsDynamicDefault.common] > > [PcdsFixedAtBuild.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x021c0500 > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|TRUE > > # > # CCSR Address Space and other attached Memories > -- > 2.17.1 >